[Bug 1426965] Review Request: go-i18n - Translate Go programs into multiple languages

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1426965

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2017-04-04 12:02:43



--- Comment #13 from Fedora Update System  ---
go-i18n-1.7.0-5.fc26 has been pushed to the Fedora 26 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1426965] Review Request: go-i18n - Translate Go programs into multiple languages

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1426965

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #12 from Fedora Update System  ---
go-i18n-1.7.0-5.fc26 has been pushed to the Fedora 26 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-a8dc79a021

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1426965] Review Request: go-i18n - Translate Go programs into multiple languages

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1426965

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1426965] Review Request: go-i18n - Translate Go programs into multiple languages

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1426965



--- Comment #11 from Fedora Update System  ---
go-i18n-1.7.0-5.fc26 has been submitted as an update to Fedora 26.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-a8dc79a021

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1426965] Review Request: go-i18n - Translate Go programs into multiple languages

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1426965

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #10 from Fedora Update System  ---
go-i18n-1.7.0-4.fc26 has been pushed to the Fedora 26 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-ec7e584128

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1426965] Review Request: go-i18n - Translate Go programs into multiple languages

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1426965



--- Comment #9 from Fedora Update System  ---
go-i18n-1.7.0-4.fc26 has been submitted as an update to Fedora 26.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-ec7e584128

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1426965] Review Request: go-i18n - Translate Go programs into multiple languages

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1426965

Fedora Update System  changed:

   What|Removed |Added

 Status|NEW |MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1426965] Review Request: go-i18n - Translate Go programs into multiple languages

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1426965



--- Comment #8 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/go-i18n

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1426965] Review Request: go-i18n - Translate Go programs into multiple languages

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1426965



--- Comment #7 from Athos Ribeiro  ---
Thank you, Fabio. I will change the typo!

I requested the package repository.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1426965] Review Request: go-i18n - Translate Go programs into multiple languages

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1426965

Fabio Valentini  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #6 from Fabio Valentini  ---
Looks very good now! Package approved.

PS: There's a typo in line 12 (s/loacles/locales) - just fix it before
committing the .spec in git.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1426965] Review Request: go-i18n - Translate Go programs into multiple languages

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1426965

Athos Ribeiro  changed:

   What|Removed |Added

Summary|Review Request: |Review Request: go-i18n -
   |golang-github-nicksnyder-go |Translate Go programs into
   |-i18n - Translate Go|multiple languages
   |programs into multiple  |
   |languages   |



--- Comment #5 from Athos Ribeiro  ---
Hello Fabio,

Thank you for the nice review!

1) Done.

2) Upstream names the project go-i18n, but names the main binary goi18n. I will
follow the guidelines, naming the package after upstream (go-i18n).

3) Done.

4) Done.

5) Done.

6) Done.

7) Done.

8) The codegen subpackage aims the generations of source code for new locales.
I do believe this should not be shipped, but sources are shipped within the
devel subpackage. I decided to keep the comments on the binary so if anyone
ever feels that The binary should be shipped, all we'd need to do is remove the
comments. I just added a new macro to build with codegen (deactivated) and some
comments on it.

Spec URL: https://athoscr.fedorapeople.org/packaging/go-i18n.spec
SRPM URL:
https://athoscr.fedorapeople.org/packaging/go-i18n-1.7.0-4.fc25.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org