[Bug 1435230] Review Request: python-ufo2ft - A bridge from UFOs to FontTool objects

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1435230

Athos Ribeiro  changed:

   What|Removed |Added

 Status|POST|CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2017-08-29 12:58:39



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1435230] Review Request: python-ufo2ft - A bridge from UFOs to FontTool objects

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1435230



--- Comment #9 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/python-ufo2ft

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1435230] Review Request: python-ufo2ft - A bridge from UFOs to FontTool objects

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1435230



--- Comment #8 from Athos Ribeiro  ---
Thanks for the review, Elliot!

I will add the version requirements as suggested :)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1435230] Review Request: python-ufo2ft - A bridge from UFOs to FontTool objects

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1435230

Elliott Sales de Andrade  changed:

   What|Removed |Added

 Status|NEW |POST
   Assignee|nob...@fedoraproject.org|quantum.anal...@gmail.com
  Flags||fedora-review+



--- Comment #7 from Elliott Sales de Andrade  ---
Package Review
==

Looks good; APPROVED.

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed

= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "MIT/X11 (BSD like)", "Apache (v2.0)", "Unknown or generated".
 73 files have unknown license. Detailed output of licensecheck in
 /home/elliott/rpmbuild/review/1435230-python-ufo2ft/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[?]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 20480 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: No rpmlint messages.
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
 process.
[x]: A package which is used by another package via an egg interface should
 provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep

= SHOULD items =

Generic:
[x]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
 Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
 python2-ufo2ft , python3-ufo2ft
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package 

[Bug 1435230] Review Request: python-ufo2ft - A bridge from UFOs to FontTool objects

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1435230



--- Comment #6 from Elliott Sales de Andrade  ---
It'd be useful to add a version requirement so it wouldn't try to build at all.

Not sure why I didn't get the updated compreffor (using Rawhide it should be
there immediately) as it seems to have been built a while ago, but maybe just
need to wait a little while for the mirrors to update.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1435230] Review Request: python-ufo2ft - A bridge from UFOs to FontTool objects

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1435230



--- Comment #5 from Athos Ribeiro  ---
(In reply to Elliott Sales de Andrade from comment #4)
> This seems to require a new version of compreffor, which doesn't seem to pip
> install properly (and should be using the Fedora package, anyway.)

It does use the fedora package (check the koji build). You should wait for the
new python-compreffor version to propagate to the mirrors if you are building
it locally.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1435230] Review Request: python-ufo2ft - A bridge from UFOs to FontTool objects

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1435230



--- Comment #4 from Elliott Sales de Andrade  ---
This seems to require a new version of compreffor, which doesn't seem to pip
install properly (and should be using the Fedora package, anyway.)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1435230] Review Request: python-ufo2ft - A bridge from UFOs to FontTool objects

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1435230

Athos Ribeiro  changed:

   What|Removed |Added

  Flags|needinfo?(athoscribeiro@gma |
   |il.com) |



--- Comment #3 from Athos Ribeiro  ---
Hi Elliott, thanks for the input! :)

Updated version and koji build

Spec URL: https://athoscr.fedorapeople.org/packaging/python-ufo2ft.spec
SRPM URL:
https://athoscr.fedorapeople.org/packaging/python-ufo2ft-0.6.2-1.fc26.src.rpm
Koji Build: https://koji.fedoraproject.org/koji/taskinfo?taskID=21450989

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1435230] Review Request: python-ufo2ft - A bridge from UFOs to FontTool objects

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1435230

Elliott Sales de Andrade  changed:

   What|Removed |Added

 CC||athoscribe...@gmail.com
  Flags||needinfo?(athoscribeiro@gma
   ||il.com)



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1435230] Review Request: python-ufo2ft - A bridge from UFOs to FontTool objects

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1435230
Bug 1435230 depends on bug 1434410, which changed state.

Bug 1434410 Summary: Review Request: python-compreffor - CFF table 
subroutinizer for FontTools
https://bugzilla.redhat.com/show_bug.cgi?id=1434410

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1435230] Review Request: python-ufo2ft - A bridge from UFOs to FontTool objects

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1435230

Elliott Sales de Andrade  changed:

   What|Removed |Added

 CC||quantum.anal...@gmail.com



--- Comment #2 from Elliott Sales de Andrade  ---
It looks like tests are not passing on this one. Also it's an outdated version.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1435230] Review Request: python-ufo2ft - A bridge from UFOs to FontTool objects

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1435230

Athos Ribeiro  changed:

   What|Removed |Added

 Blocks||1441023




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1441023
[Bug 1441023] Review Request: python-fontmake - Compile fonts from sources
to binary
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1435230] Review Request: python-ufo2ft - A bridge from UFOs to FontTool objects

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1435230



--- Comment #1 from Athos Ribeiro  ---
New version:

Spec URL: https://athoscr.fedorapeople.org/packaging/python-ufo2ft.spec
SRPM URL:
https://athoscr.fedorapeople.org/packaging/python-ufo2ft-0.4.2-1.fc25.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1435230] Review Request: python-ufo2ft - A bridge from UFOs to FontTool objects

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1435230

Athos Ribeiro  changed:

   What|Removed |Added

 Depends On||1434410




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1434410
[Bug 1434410] Review Request: python-compreffor - A CFF table subroutinizer
for FontTools
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org