[Bug 1438853] Review Request: lldpd - an ISC-licensed implementation of LLDP

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1438853

James Hogarth  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |CURRENTRELEASE
Last Closed||2017-05-11 16:56:01



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1438853] Review Request: lldpd - an ISC-licensed implementation of LLDP

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1438853



--- Comment #25 from Fedora Update System  ---
lldpd-0.9.7-5.el7 has been pushed to the Fedora EPEL 7 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1438853] Review Request: lldpd - an ISC-licensed implementation of LLDP

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1438853



--- Comment #24 from Fedora Update System  ---
lldpd-0.9.7-5.el6 has been pushed to the Fedora EPEL 6 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1438853] Review Request: lldpd - an ISC-licensed implementation of LLDP

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1438853



--- Comment #23 from Fedora Update System  ---
lldpd-0.9.7-5.fc25 has been pushed to the Fedora 25 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1438853] Review Request: lldpd - an ISC-licensed implementation of LLDP

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1438853



--- Comment #22 from Fedora Update System  ---
lldpd-0.9.7-5.fc24 has been pushed to the Fedora 24 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1438853] Review Request: lldpd - an ISC-licensed implementation of LLDP

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1438853



--- Comment #21 from Fedora Update System  ---
lldpd-0.9.7-5.fc26 has been pushed to the Fedora 26 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1438853] Review Request: lldpd - an ISC-licensed implementation of LLDP

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1438853



--- Comment #20 from Fedora Update System  ---
lldpd-0.9.7-5.fc26 has been pushed to the Fedora 26 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-7356de7a31

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1438853] Review Request: lldpd - an ISC-licensed implementation of LLDP

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1438853



--- Comment #19 from Fedora Update System  ---
lldpd-0.9.7-5.fc25 has been pushed to the Fedora 25 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-77fac90af3

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1438853] Review Request: lldpd - an ISC-licensed implementation of LLDP

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1438853



--- Comment #18 from Fedora Update System  ---
lldpd-0.9.7-5.fc24 has been pushed to the Fedora 24 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-8363c4e8ec

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1438853] Review Request: lldpd - an ISC-licensed implementation of LLDP

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1438853



--- Comment #17 from Fedora Update System  ---
lldpd-0.9.7-5.el7 has been pushed to the Fedora EPEL 7 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-fe76c20831

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1438853] Review Request: lldpd - an ISC-licensed implementation of LLDP

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1438853

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #16 from Fedora Update System  ---
lldpd-0.9.7-5.el6 has been pushed to the Fedora EPEL 6 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-6ab500b6b5

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1438853] Review Request: lldpd - an ISC-licensed implementation of LLDP

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1438853



--- Comment #15 from Fedora Update System  ---
lldpd-0.9.7-5.el7 has been submitted as an update to Fedora EPEL 7.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-fe76c20831

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1438853] Review Request: lldpd - an ISC-licensed implementation of LLDP

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1438853



--- Comment #12 from Fedora Update System  ---
lldpd-0.9.7-5.fc24 has been submitted as an update to Fedora 24.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-8363c4e8ec

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1438853] Review Request: lldpd - an ISC-licensed implementation of LLDP

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1438853



--- Comment #11 from Fedora Update System  ---
lldpd-0.9.7-5.fc25 has been submitted as an update to Fedora 25.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-77fac90af3

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1438853] Review Request: lldpd - an ISC-licensed implementation of LLDP

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1438853



--- Comment #14 from Fedora Update System  ---
lldpd-0.9.7-5.fc26 has been submitted as an update to Fedora 26.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-7356de7a31

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1438853] Review Request: lldpd - an ISC-licensed implementation of LLDP

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1438853



--- Comment #13 from Fedora Update System  ---
lldpd-0.9.7-5.el6 has been submitted as an update to Fedora EPEL 6.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-6ab500b6b5

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1438853] Review Request: lldpd - an ISC-licensed implementation of LLDP

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1438853



--- Comment #8 from Fedora Update System  ---
lldpd-0.9.7-4.fc25 has been submitted as an update to Fedora 25.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-676f5655d9

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1438853] Review Request: lldpd - an ISC-licensed implementation of LLDP

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1438853



--- Comment #10 from Fedora Update System  ---
lldpd-0.9.7-4.fc26 has been submitted as an update to Fedora 26.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-8741526fc3

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1438853] Review Request: lldpd - an ISC-licensed implementation of LLDP

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1438853

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1438853] Review Request: lldpd - an ISC-licensed implementation of LLDP

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1438853



--- Comment #9 from Fedora Update System  ---
lldpd-0.9.7-4.fc24 has been submitted as an update to Fedora 24.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-cedacd0aaf

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1438853] Review Request: lldpd - an ISC-licensed implementation of LLDP

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1438853



--- Comment #7 from Gwyn Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/lldpd

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1438853] Review Request: lldpd - an ISC-licensed implementation of LLDP

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1438853



--- Comment #6 from James Hogarth  ---
Thanks Dan ... and good news is it only required a minor maintainer patch to
get it built against EPEL6 as well :)

Letting the developer know the changes I made in the patch to see if he's
willing to upstream.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1438853] Review Request: lldpd - an ISC-licensed implementation of LLDP

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1438853

Dan Horák  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #5 from Dan Horák  ---
Looks good now, package is APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1438853] Review Request: lldpd - an ISC-licensed implementation of LLDP

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1438853



--- Comment #4 from James Hogarth  ---
Thanks for the feedback, both of you.

  * Source0 line updated
  * Summary changed to suggestion
  * configure option updated
  * requires added to subpackage on main package
  * looking at more detail it wanted not just doxygen but the pdf part as well
to produce pdf docs... that feels silly so I've pulled the BR

Koji builds:

F25: https://koji.fedoraproject.org/koji/taskinfo?taskID=18796508
F26: https://koji.fedoraproject.org/koji/taskinfo?taskID=18796713
RAW: https://koji.fedoraproject.org/koji/taskinfo?taskID=18796875
EL7: https://koji.fedoraproject.org/koji/taskinfo?taskID=18797292

Spec URL: https://fedorapeople.org/~jhogarth/lldpd/lldpd.spec
SRPM URL: https://fedorapeople.org/~jhogarth/lldpd/lldpd-0.9.7-2.fc27.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1438853] Review Request: lldpd - an ISC-licensed implementation of LLDP

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1438853



--- Comment #3 from Dan Horák  ---
formal review is here, see the notes explaining OK* and BAD statuses below:

OKsource files match upstream:
f3ed143ba16fb4232a237f51cddaee276af896c8  0.9.7.tar.gz
OKpackage meets naming and versioning guidelines.
OKspecfile is properly named, is cleanly written and uses macros
consistently.
OKdist tag is present.
OKlicense field matches the actual license.
OKlicense is open source-compatible (ISC). License text included in
package.
OKlatest version is being packaged.
OK*BuildRequires are proper.
OKcompiler flags are appropriate.
OKpackage builds in mock (Rawhide/x86_64).
OKdebuginfo package looks complete.
BADrpmlint is silent.
OKfinal provides and requires look sane.
N/A%check is present and all tests pass.
OKshared libraries are added to the regular linker search paths with
ldconfig call.
OKowns the directories it creates.
OKdoesn't own any directories it shouldn't.
OKno duplicates in %files.
OKfile permissions are appropriate.
OKcorrect scriptlets present.
OKcode, not content.
OKdocumentation is small, so no -docs subpackage is necessary.
OK%docs are not necessary for the proper functioning of the package.
OKheaders in devel subpackage
OKpkgconfig files in devel subpackage
OKno libtool .la droppings.
OKnot a GUI app.

- please do the 2 changes Ralf proposed, use %{name}-%{version}.tar.gz style
for the source and use a verbose build (easier to read the build log than
inspect *.o files for used compiler flags)
- doxygen is present in BR, but there are no docs generated
- rpmlint complains a bit
lldpd.x86_64: W: summary-not-capitalized C lldpd is an ISC-licensed
implementation of LLDP
lldpd.x86_64: W: name-repeated-in-summary C lldpd
lldpd.src: W: summary-not-capitalized C lldpd is an ISC-licensed implementation
of LLDP
lldpd.src: W: name-repeated-in-summary C lldpd
lldpd-devel.x86_64: W: summary-not-capitalized C lldpd is an ISC-licensed
implementation of LLDP
  -> Summary: ISC-licensed implementation of LLDP

lldpd.x86_64: W: non-standard-uid /var/lib/lldpd lldpd
lldpd.x86_64: W: non-standard-gid /var/lib/lldpd lldpd
lldpd-devel.x86_64: W: no-documentation
lldpd-devel.x86_64: W: only-non-binary-in-usr-lib
lldpd.x86_64: W: hidden-file-or-dir /usr/lib/.build-id
lldpd.x86_64: W: hidden-file-or-dir /usr/lib/.build-id
lldpd.x86_64: W: conffile-without-noreplace-flag /etc/lldpd.d/README.conf
  -> OK, can be ignored

lldpd.x86_64: E: zero-length /usr/share/doc/lldpd/ChangeLog
  -> drop the file from %doc, needs git tree and NEWS is sufficient,
Contribute.md can dropped too

lldpd.src:9: W: mixed-use-of-spaces-and-tabs (spaces: line 8, tab: line 9)
lldpd.x86_64: E: missing-call-to-chdir-with-chroot /usr/sbin/lldpd
lldpd.x86_64: W: shared-lib-calls-exit /usr/lib64/liblldpctl.so.4.8.0
exit@GLIBC_2.2.5
lldpd.x86_64: W: non-ghost-in-run /run/lldpd/chroot
lldpd.x86_64: W: non-ghost-in-run /run/lldpd
lldpd-devel.x86_64: W: no-dependency-on lldpd/lldpd-libs/liblldpd
  -> need fix or comment

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1438853] Review Request: lldpd - an ISC-licensed implementation of LLDP

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1438853

Dan Horák  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||d...@danny.cz
   Assignee|nob...@fedoraproject.org|d...@danny.cz
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1438853] Review Request: lldpd - an ISC-licensed implementation of LLDP

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1438853

Ralf Corsepius  changed:

   What|Removed |Added

 CC||rc040...@freenet.de



--- Comment #2 from Ralf Corsepius  ---
Not a formal review just some remarks:

- Building package is not verbose. 
Please append --disable-silent-rules to %configure.

- The package contains a tarball named "0.9.7.tar.gz"
I would propose to change Source0 into:
Source0:   
https://github.com/%{gh_owner}/%{name}/archive/%{version}.tar.gz#/%{name}-%{version}.tar.gz

This lets downloading from github create a tarball named "lldpd-0.9.7.tar.gz"

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1438853] Review Request: lldpd - an ISC-licensed implementation of LLDP

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1438853



--- Comment #1 from James Hogarth  ---
Koji scratch builds:

rawhide: https://koji.fedoraproject.org/koji/taskinfo?taskID=18782014
f26: https://koji.fedoraproject.org/koji/taskinfo?taskID=18782015
f25: https://koji.fedoraproject.org/koji/taskinfo?taskID=18782023
epel7: https://koji.fedoraproject.org/koji/taskinfo?taskID=18782022

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org