[Bug 1450144] Review Request: rubygem-yell - Yell - Your Extensible Logging Library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1450144



--- Comment #11 from Fedora Update System  ---
rubygem-yell-2.0.7-2.el7 has been pushed to the Fedora EPEL 7 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1450144] Review Request: rubygem-yell - Yell - Your Extensible Logging Library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1450144

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2017-09-21 19:52:47



--- Comment #10 from Fedora Update System  ---
rubygem-yell-2.0.7-2.fc26 has been pushed to the Fedora 26 stable repository.
If problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1450144] Review Request: rubygem-yell - Yell - Your Extensible Logging Library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1450144



--- Comment #9 from Fedora Update System  ---
rubygem-yell-2.0.7-2.fc26 has been pushed to the Fedora 26 testing repository.
If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-4c2ec42376

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1450144] Review Request: rubygem-yell - Yell - Your Extensible Logging Library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1450144

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #8 from Fedora Update System  ---
rubygem-yell-2.0.7-2.el7 has been pushed to the Fedora EPEL 7 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-cf8a47a2e8

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1450144] Review Request: rubygem-yell - Yell - Your Extensible Logging Library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1450144



--- Comment #7 from Fedora Update System  ---
rubygem-yell-2.0.7-2.el7 has been submitted as an update to Fedora EPEL 7.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-cf8a47a2e8

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1450144] Review Request: rubygem-yell - Yell - Your Extensible Logging Library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1450144

Fedora Update System  changed:

   What|Removed |Added

 Status|POST|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1450144] Review Request: rubygem-yell - Yell - Your Extensible Logging Library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1450144



--- Comment #6 from Fedora Update System  ---
rubygem-yell-2.0.7-2.fc26 has been submitted as an update to Fedora 26.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-4c2ec42376

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1450144] Review Request: rubygem-yell - Yell - Your Extensible Logging Library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1450144

František Dvořák  changed:

   What|Removed |Added

 Blocks|1483986 |




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1483986
[Bug 1483986] rOCCI-server-v2.0.0.beta.1 is available
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1450144] Review Request: rubygem-yell - Yell - Your Extensible Logging Library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1450144

František Dvořák  changed:

   What|Removed |Added

 Blocks||1483986




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1483986
[Bug 1483986] rOCCI-server-v2.0.0.beta.1 is available
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1450144] Review Request: rubygem-yell - Yell - Your Extensible Logging Library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1450144



--- Comment #5 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/rubygem-yell

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1450144] Review Request: rubygem-yell - Yell - Your Extensible Logging Library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1450144

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|ASSIGNED|POST
  Flags|fedora-review?  |fedora-review+



--- Comment #4 from Robert-André Mauchin  ---
All good then, package accepted.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1450144] Review Request: rubygem-yell - Yell - Your Extensible Logging Library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1450144



--- Comment #3 from František Dvořák  ---
Thanks for the review!

(In reply to Robert-André Mauchin from comment #1)
>  - There's two almost identical BR:
> 
> BuildRequires:  rubygem(rspec)
> BuildRequires:  rubygem(rspec) >= 3
> 
> Just keep the later one with the version requirement.
> 

You're right, fixed.

>  - There's an examples/ directory in the source files, it would be great to
> include it in %doc:
> 
> %files
> %doc examples
> 

Examples are in the -doc subpackage, but they has not been marked as %doc.
Fixed.

> 
>  - According to the guidelines for Rubygems
> (https://fedoraproject.org/wiki/Packaging:Ruby#RubyGems):
> 
> "There should not be Requires: ruby(release), unless you want to explicitly
> specify Ruby version compatibility. Automatically generated dependency on
> RubyGems (Requires: ruby(rubygems)) is enough"
> 
> So, you should probably remove Requires: ruby(release) but instead add a
> Requires:   ruby(rubygems)

Actually this is not a runtime dependency, only BuildRequires.

But it is true the explicit "BuildRequires: ruby(release)" is probably not
needed here (ruby interpreter is picked by rubygems package already, and ruby
is not launched directly in the spec file). Removed.


The new version:

Spec URL:
http://scientific.zcu.cz/fedora/rubygem-yell-2.0.7-2/rubygem-yell.spec
SRPM URL:
http://scientific.zcu.cz/fedora/rubygem-yell-2.0.7-2/rubygem-yell-2.0.7-2.fc25.src.rpm

* Sun Aug 27 2017 František Dvořák  - 2.0.7-2
- Better build dependencies
- Mark examples as documentation

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1450144] Review Request: rubygem-yell - Yell - Your Extensible Logging Library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1450144



--- Comment #2 from Robert-André Mauchin  ---
I forgot to paste the review:


Issues:
===
- Package contains Requires: ruby(release).


= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "MIT/X11 (BSD like)", "Unknown or generated". 61 files have
 unknown license. Detailed output of licensecheck in
 /home/bob/packaging/review/rubygem-yell/review-rubygem-
 yell/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package must own all directories that it creates.
 Note: Directories without known owners: /usr/share/gems,
 /usr/share/gems/doc
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

Ruby:
[x]: Platform dependent files must all go under %{gem_extdir_mri}, platform
 independent under %{gem_dir}.
[x]: Gem package must not define a non-gem subpackage
[x]: Macro %{gem_extdir} is deprecated.
[x]: Gem package is named rubygem-%{gem_name}
[x]: Package contains BuildRequires: rubygems-devel.
[x]: Gem package must define %{gem_name} macro.
[x]: Pure Ruby package must be built as noarch
[x]: Package does not contain Requires: ruby(abi).

= SHOULD items =

Generic:
[-]: Avoid bundling fonts in non-fonts packages.
 Note: Package contains font files
[x]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
 Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in rubygem-
 yell-doc
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
 translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
 

[Bug 1450144] Review Request: rubygem-yell - Yell - Your Extensible Logging Library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1450144

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||zebo...@gmail.com
   Assignee|nob...@fedoraproject.org|zebo...@gmail.com
  Flags||fedora-review?



--- Comment #1 from Robert-André Mauchin  ---
Hello,

 - There's two almost identical BR:

BuildRequires:  rubygem(rspec)
BuildRequires:  rubygem(rspec) >= 3

Just keep the later one with the version requirement.

 - There's an examples/ directory in the source files, it would be great to
include it in %doc:

%files
%doc examples


 - According to the guidelines for Rubygems
(https://fedoraproject.org/wiki/Packaging:Ruby#RubyGems):

"There should not be Requires: ruby(release), unless you want to explicitly
specify Ruby version compatibility. Automatically generated dependency on
RubyGems (Requires: ruby(rubygems)) is enough"

So, you should probably remove Requires: ruby(release) but instead add a
Requires:   ruby(rubygems)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1450144] Review Request: rubygem-yell - Yell - Your Extensible Logging Library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1450144

František Dvořák  changed:

   What|Removed |Added

 Blocks||1484600




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1484600
[Bug 1484600] rubygem-occi-core-5.0.0 is available
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org