[Bug 1457714] Review Request: plymouth-kcm - KCM for setting plymouth theme

https://bugzilla.redhat.com/show_bug.cgi?id=1457714 Rex Dieter changed: What|Removed |Added Status|ASSIGNED|CLOSED

[Bug 1457714] Review Request: plymouth-kcm - KCM for setting plymouth theme

https://bugzilla.redhat.com/show_bug.cgi?id=1457714 --- Comment #7 from Gwyn Ciesla --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/plymouth-kcm -- You are receiving this mail because: You are on the CC list for the bug. You are

[Bug 1457714] Review Request: plymouth-kcm - KCM for setting plymouth theme

https://bugzilla.redhat.com/show_bug.cgi?id=1457714 Jan Grulich changed: What|Removed |Added Flags|fedora-review? |fedora-review+

[Bug 1457714] Review Request: plymouth-kcm - KCM for setting plymouth theme

https://bugzilla.redhat.com/show_bug.cgi?id=1457714 --- Comment #5 from Martin Kyral --- Thanks for the feedback. I incorporated the proposed changes in the spec file, available in copr dist-git. Spec URL:

[Bug 1457714] Review Request: plymouth-kcm - KCM for setting plymouth theme

https://bugzilla.redhat.com/show_bug.cgi?id=1457714 --- Comment #4 from Jan Grulich --- 1) Why don't you use %find_lang? Also listing all localization as you did in %files is not how usually this is done. 2) This "%{_libdir}/qt5/plugins/kcms/kcm_plymouth.so" can be

[Bug 1457714] Review Request: plymouth-kcm - KCM for setting plymouth theme

https://bugzilla.redhat.com/show_bug.cgi?id=1457714 Jan Grulich changed: What|Removed |Added Status|NEW |ASSIGNED

[Bug 1457714] Review Request: plymouth-kcm - KCM for setting plymouth theme

https://bugzilla.redhat.com/show_bug.cgi?id=1457714 Rex Dieter changed: What|Removed |Added CC||rdie...@gmail.com

[Bug 1457714] Review Request: plymouth-kcm - KCM for setting plymouth theme

https://bugzilla.redhat.com/show_bug.cgi?id=1457714 --- Comment #2 from Martin Kyral --- Created attachment 1284033 --> https://bugzilla.redhat.com/attachment.cgi?id=1284033=edit patch to use dracut instead of update-alternatives -- You are receiving this mail because:

[Bug 1457714] Review Request: plymouth-kcm - KCM for setting plymouth theme

https://bugzilla.redhat.com/show_bug.cgi?id=1457714 --- Comment #1 from Martin Kyral --- Created attachment 1284031 --> https://bugzilla.redhat.com/attachment.cgi?id=1284031=edit spec file -- You are receiving this mail because: You are on the CC list for the bug. You