subject:"\[Bug 1460317\] Review Request\: gnome\-panel \- GNOME Flashback panel"

[Bug 1460317] Review Request: gnome-panel - GNOME Flashback panel

2017-08-16 Thread bugzilla

https://bugzilla.redhat.com/show_bug.cgi?id=1460317 Fabio Valentini changed: What|Removed |Added Status|NEW |CLOSED

[Bug 1460317] Review Request: gnome-panel - GNOME Flashback panel

2017-07-20 Thread bugzilla

https://bugzilla.redhat.com/show_bug.cgi?id=1460317 --- Comment #8 from Yaakov Selkowitz --- I'll try to get back to it this weekend. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and

[Bug 1460317] Review Request: gnome-panel - GNOME Flashback panel

2017-07-19 Thread bugzilla

https://bugzilla.redhat.com/show_bug.cgi?id=1460317 --- Comment #7 from Fabio Valentini --- Any progress on this? Otherwise I'll have to mark this package review as stalled. -- You are receiving this mail because: You are on the CC list for the bug. You are always

[Bug 1460317] Review Request: gnome-panel - GNOME Flashback panel

2017-06-20 Thread bugzilla

https://bugzilla.redhat.com/show_bug.cgi?id=1460317 --- Comment #6 from Fabio Valentini --- There are only a few minor issues left: Blocking positive review: 6) The license tag is still incorrect - according to licensecheck / fedora-review, no GFDL licensed files are

[Bug 1460317] Review Request: gnome-panel - GNOME Flashback panel

2017-06-19 Thread bugzilla

https://bugzilla.redhat.com/show_bug.cgi?id=1460317 --- Comment #5 from Yaakov Selkowitz --- I cleaned up a lot of the cruft. Files at the same location as comment 0. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified

[Bug 1460317] Review Request: gnome-panel - GNOME Flashback panel

2017-06-16 Thread bugzilla

https://bugzilla.redhat.com/show_bug.cgi?id=1460317 --- Comment #4 from Fabio Valentini --- That's why I wrote "where appropriate", because some of those points are only my opinion on how the "best possible" .spec file would look like, and not enforcible guidelines.

[Bug 1460317] Review Request: gnome-panel - GNOME Flashback panel

2017-06-15 Thread bugzilla

https://bugzilla.redhat.com/show_bug.cgi?id=1460317 --- Comment #3 from Yaakov Selkowitz --- This started as a reinstatement of the previously existing package with incremental changes, so there may be cruft. A lot of your points are stylistic, however. -- You are

[Bug 1460317] Review Request: gnome-panel - GNOME Flashback panel

2017-06-15 Thread bugzilla

https://bugzilla.redhat.com/show_bug.cgi?id=1460317 --- Comment #2 from Fabio Valentini --- There seems to be a LOT of outdated cruft in the .spec file. 1) The URL tag is pointing at the GNOME homepage, not a GNOME Panel page. 2) Don't use the Group: tag. 3) Remove