[Bug 1474392] Review Request: perl-Test-Exec - Test that some code calls exec without terminating testing

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1474392

Petr Pisar  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
   Fixed In Version||perl-Test-Exec-0.04-1.fc27
 Resolution|--- |RAWHIDE
Last Closed||2017-08-01 08:54:30



--- Comment #3 from Petr Pisar  ---
Thank you for the review and the repository. I added the dependency on make.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1474392] Review Request: perl-Test-Exec - Test that some code calls exec without terminating testing

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1474392



--- Comment #2 from Gwyn Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/perl-Test-Exec

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1474392] Review Request: perl-Test-Exec - Test that some code calls exec without terminating testing

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1474392

Jitka Plesnikova  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #1 from Jitka Plesnikova  ---
Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed

BuildRequires are almost ok
FIX: Please add build-requires 'make'

$ rpm -qp --requires perl-Test-Exec-0.04-1.fc27.noarch.rpm | sort | uniq -c
  1 perl(base)
  1 perl(Exporter)
  1 perl(:MODULE_COMPAT_5.26.0)
  1 perl(Return::MultiLevel)
  1 perl(strict)
  1 perl(Test2::API) >= 1.302015
  1 perl(warnings)
  1 rpmlib(CompressedFileNames) <= 3.0.4-1
  1 rpmlib(FileDigests) <= 4.6.0-1
  1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
  1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.

$ rpm -qp --provides perl-Test-Exec-0.04-1.fc27.noarch.rpm | sort | uniq -c
  1 perl(Test::Exec) = 0.04
  1 perl-Test-Exec = 0.04-1.fc27
Binary provides are Ok.

$ rpmlint ./perl-Test-Exec*
perl-Test-Exec.noarch: W: spelling-error %description -l en_US eval -> veal,
vela, val
perl-Test-Exec.src: W: spelling-error %description -l en_US eval -> veal, vela,
val
2 packages and 1 specfiles checked; 0 errors, 2 warnings. 
Rpmlint is ok

Please correct 'FIX' issue.

Otherwise the package looks good.
Approved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1474392] Review Request: perl-Test-Exec - Test that some code calls exec without terminating testing

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1474392

Jitka Plesnikova  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||jples...@redhat.com
   Assignee|nob...@fedoraproject.org|jples...@redhat.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1474392] Review Request: perl-Test-Exec - Test that some code calls exec without terminating testing

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1474392

Petr Pisar  changed:

   What|Removed |Added

 Blocks||1474425




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1474425
[Bug 1474425] Review Request: perl-Alien-Build - Build external
dependencies for use in CPAN
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org