[Bug 1475791] Review Request: golang-github-VividCortex-ewma - Exponentially Weighted Moving Average algorithms for Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1475791



--- Comment #13 from Fedora Update System  ---
golang-github-VividCortex-ewma-1.1.1-1.fc26 has been pushed to the Fedora 26
stable repository. If problems still persist, please make note of it in this
bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1475791] Review Request: golang-github-VividCortex-ewma - Exponentially Weighted Moving Average algorithms for Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1475791

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2017-08-28 18:22:18



--- Comment #12 from Fedora Update System  ---
golang-github-VividCortex-ewma-1.1.1-1.fc25 has been pushed to the Fedora 25
stable repository. If problems still persist, please make note of it in this
bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1475791] Review Request: golang-github-VividCortex-ewma - Exponentially Weighted Moving Average algorithms for Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1475791



--- Comment #11 from Fedora Update System  ---
golang-github-VividCortex-ewma-1.1.1-1.fc26 has been pushed to the Fedora 26
testing repository. If problems still persist, please make note of it in this
bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-0a91dca49f

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1475791] Review Request: golang-github-VividCortex-ewma - Exponentially Weighted Moving Average algorithms for Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1475791

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #10 from Fedora Update System  ---
golang-github-VividCortex-ewma-1.1.1-1.fc25 has been pushed to the Fedora 25
testing repository. If problems still persist, please make note of it in this
bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-f62d7b0d87

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1475791] Review Request: golang-github-VividCortex-ewma - Exponentially Weighted Moving Average algorithms for Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1475791

Fedora Update System  changed:

   What|Removed |Added

 Status|NEW |MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1475791] Review Request: golang-github-VividCortex-ewma - Exponentially Weighted Moving Average algorithms for Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1475791



--- Comment #9 from Fedora Update System  ---
golang-github-VividCortex-ewma-1.1.1-1.fc26 has been submitted as an update to
Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-0a91dca49f

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1475791] Review Request: golang-github-VividCortex-ewma - Exponentially Weighted Moving Average algorithms for Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1475791



--- Comment #8 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/golang-github-VividCortex-ewma

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1475791] Review Request: golang-github-VividCortex-ewma - Exponentially Weighted Moving Average algorithms for Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1475791

Fabio Valentini  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #7 from Fabio Valentini  ---
Package complies with Guidelines, and you've fixed the 2 issues I pointed out.
Approved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1475791] Review Request: golang-github-VividCortex-ewma - Exponentially Weighted Moving Average algorithms for Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1475791



--- Comment #6 from Robert-André Mauchin  ---
Okay done:

SPEC URL:
https://copr-be.cloud.fedoraproject.org/results/eclipseo/rclone/fedora-rawhide-x86_64/00591472-golang-github-VividCortex-ewma/golang-github-VividCortex-ewma.spec
SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/eclipseo/rclone/fedora-rawhide-x86_64/00591472-golang-github-VividCortex-ewma/golang-github-VividCortex-ewma-1.1.1-1.fc27.src.rpm

Thanks for your review!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1475791] Review Request: golang-github-VividCortex-ewma - Exponentially Weighted Moving Average algorithms for Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1475791



--- Comment #5 from Fabio Valentini  ---
I've found some minor issues:

1) Please don't remove the commit and shortcommit variables generated by gofed.
They are used to do automatic version tracking of golang packages in fedora,
even if they aren't part of the version string.

You can include something like this (look at some of my golang packages, e.g.
golang-github-calmh-du) to clarify that the version is exactly this commit:

%global commit  b24eb346a94c3ba12c1da1e564dbac1b498a77ce
%global shortcommit %(c=%{commit}; echo ${c:0:7})

# commit b24eb346a94c3ba12c1da1e564dbac1b498a77ce == version 1.1.1


2) Please don't use the "ugly" Source0 URL. There's a really nice way to get
tarballs of tags (without doing the #/XXX.tar.gz hack):

Source0:
https://%{provider_prefix}/archive/v%{version}/%{repo}-%{version}.tar.gz

This generates a tarball of the commit tagged with "v%{version}" with the name
"%{project}-%{version}.tar.gz" - which is exactly what you want, without hacks.

See (under GitHub):
https://fedoraproject.org/wiki/Packaging:SourceURL?rd=Packaging/SourceURL#Git_Tags

PS: For some golang projects, you might consider naming the tarball
"%{project}-%{repo}.tar.gz" in the Source URL, especially if the name %{repo}
is ambiguous, or if there's already a package with that name. That way you
won't run into possible collisions in the source lookaside cache. It's not an
issue with this package, but keep it in mind.


Otherwise:

Package Review
==

[x]: Package complies to the Packaging Guidelines


Please fix the 2 issues I pointed out, then the package is ready for approval.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1475791] Review Request: golang-github-VividCortex-ewma - Exponentially Weighted Moving Average algorithms for Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1475791

Fabio Valentini  changed:

   What|Removed |Added

 CC||decatho...@gmail.com
   Assignee|nob...@fedoraproject.org|decatho...@gmail.com
  Flags||fedora-review?



--- Comment #4 from Fabio Valentini  ---
Taking this.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1475791] Review Request: golang-github-VividCortex-ewma - Exponentially Weighted Moving Average algorithms for Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1475791



--- Comment #3 from Robert-André Mauchin  ---
SPEC URL:
https://copr-be.cloud.fedoraproject.org/results/eclipseo/rclone/fedora-rawhide-x86_64/00584409-golang-github-VividCortex-ewma/golang-github-VividCortex-ewma.spec
SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/eclipseo/rclone/fedora-rawhide-x86_64/00584409-golang-github-VividCortex-ewma/golang-github-VividCortex-ewma-1.1.1-1.fc27.src.rpm

FAS username: eclipseo

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1475791] Review Request: golang-github-VividCortex-ewma - Exponentially Weighted Moving Average algorithms for Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1475791



--- Comment #2 from Robert-André Mauchin  ---
Upstream already fixed the bug and released an update.

Spec URL:
https://github.com/eclipseo/packaging/blob/27c38cc/golang-github-VividCortex-ewma.spec
SRPM:
https://kojipkgs.fedoraproject.org//work/tasks/4305/20804305/golang-github-VividCortex-ewma-1.1.1-1.fc27.src.rpm
Koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=20804304

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1475791] Review Request: golang-github-VividCortex-ewma - Exponentially Weighted Moving Average algorithms for Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1475791



--- Comment #1 from Robert-André Mauchin  ---
Fixed ExclusiveArch issue

Spec URL:
https://github.com/eclipseo/packaging/blob/27b7add/golang-github-VividCortex-ewma.spec
SRPM:
https://kojipkgs.fedoraproject.org//work/tasks/2023/20802023/golang-github-VividCortex-ewma-0-0.1.git4cc8cc5.fc27.src.rpm
Koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=20802021

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1475791] Review Request: golang-github-VividCortex-ewma - Exponentially Weighted Moving Average algorithms for Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1475791

Robert-André Mauchin  changed:

   What|Removed |Added

 Blocks||1473314




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1473314
[Bug 1473314] Review Request: rclone - rsync for cloud storage
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org