[Bug 1481876] Review Request: python-pytest-shutil - A goodie-bag of unix shell and environment tools for py.test

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1481876

Kevin Fenzi  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2017-09-05 21:21:43



--- Comment #11 from Kevin Fenzi  ---
Built in rawhide.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1481876] Review Request: python-pytest-shutil - A goodie-bag of unix shell and environment tools for py.test

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1481876



--- Comment #10 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/python-pytest-shutil

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1481876] Review Request: python-pytest-shutil - A goodie-bag of unix shell and environment tools for py.test

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1481876



--- Comment #9 from Kevin Fenzi  ---
Thanks very much for the review.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1481876] Review Request: python-pytest-shutil - A goodie-bag of unix shell and environment tools for py.test

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1481876

Scott Talbert  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #8 from Scott Talbert  ---
Approved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1481876] Review Request: python-pytest-shutil - A goodie-bag of unix shell and environment tools for py.test

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1481876



--- Comment #7 from Kevin Fenzi  ---
(In reply to Scott Talbert from comment #6)
> Package Review
> ==
> 
> Legend:
> [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
> [ ] = Manual review needed
> 
> Summary of Issues:
> - Please check/fix the Requires

Good catch. Done. 

> - Please query upstream about the lack of LICENSE file

https://github.com/manahl/pytest-plugins/issues/68

> - Is there a reason you didn't package the latest version (1.2.11)?

Nope. This was the newest one on pypi at the time I initially packaged it. ;) 
Updating to 1.2.11 now. 

> - Your spec file doesn't match what's in the srpm

Yeah, I apparently added comments above the patch in the spec file pointing to
the upstream issue I filed on it. ;( Should be in sync now. Sorry about that. 

Spec URL:
http://www.scrye.com/~kevin/fedora/review/python-pytest-shutil/python-pytest-shutil.spec
SRPM URL:
http://www.scrye.com/~kevin/fedora/review/python-pytest-shutil/python-pytest-shutil-1.2.11-1.fc28.src.rpm

koji scratch build:
https://koji.fedoraproject.org/koji/taskinfo?taskID=21484310

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1481876] Review Request: python-pytest-shutil - A goodie-bag of unix shell and environment tools for py.test

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1481876



--- Comment #6 from Scott Talbert  ---
Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed

Summary of Issues:
- Please check/fix the Requires
- Please query upstream about the lack of LICENSE file
- Is there a reason you didn't package the latest version (1.2.11)?
- Your spec file doesn't match what's in the srpm

= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[-]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "Unknown or generated". 24 files have unknown license. Detailed
 output of licensecheck in /home/talbert/fedora-review/1481876-python-
 pytest-shutil/licensecheck.txt
[-]: License file installed when any subpackage combination is installed.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[!]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 20480 bytes in 4 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
 process.
[x]: A package which is used by another package via an egg interface should
 provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep

= SHOULD items =

Generic:
[!]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[-]: Fully versioned dependency in subpackages if applicable.
 Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python2
 -pytest-shutil , python3-pytest-shutil
[?]: Package functions as described.
[!]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Patches link to upstream bugs/comments/lists or are otherwise
 justified.
[-]: Description and summary sections in the package spec file contains
 translations for supported Non-English languages, if available.
[x]: Package should compile and 

[Bug 1481876] Review Request: python-pytest-shutil - A goodie-bag of unix shell and environment tools for py.test

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1481876

Scott Talbert  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED



--- Comment #5 from Scott Talbert  ---
OK, I think the dnf 100% CPU loop was normal, or at least if I wait long
enough, fedora-review completes.  :)  Sorry about that.

First comment: I believe that six, execnet, contextlib2, and mock need to be
Requires also.  setup.py also references path.py but quickly grepping the code
I don't see that being imported anyway.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1481876] Review Request: python-pytest-shutil - A goodie-bag of unix shell and environment tools for py.test

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1481876



--- Comment #4 from Scott Talbert  ---
(In reply to Kevin Fenzi from comment #3)
> Yeah it builds fine in koji here: 
> 
> http://koji.fedoraproject.org/koji/taskinfo?taskID=21332425
> 
> Were you building locally or in mock? 
> I don't think I am missing any buildrequires or it wouldnt work in koji
> either...

Building in mock via fedora-review.  It does seem to build fine now, must have
been some transient bad state in rawhide or something.  Now, though, when
fedora-review tries to install the package, it puts dnf into some sort of 100%
CPU loop.  Don't know exactly what's going on there.  :(

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1481876] Review Request: python-pytest-shutil - A goodie-bag of unix shell and environment tools for py.test

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1481876



--- Comment #3 from Kevin Fenzi  ---
Yeah it builds fine in koji here: 

http://koji.fedoraproject.org/koji/taskinfo?taskID=21332425

Were you building locally or in mock? 
I don't think I am missing any buildrequires or it wouldnt work in koji
either...

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1481876] Review Request: python-pytest-shutil - A goodie-bag of unix shell and environment tools for py.test

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1481876

Scott Talbert  changed:

   What|Removed |Added

 Blocks||1481875




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1481875
[Bug 1481875] Review Request: python-pytest-virtualenv - Virtualenv fixture
for py.test
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1481876] Review Request: python-pytest-shutil - A goodie-bag of unix shell and environment tools for py.test

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1481876



--- Comment #2 from Kevin Fenzi  ---
Odd. It built fine a few days ago... 

https://koji.fedoraproject.org/koji/taskinfo?taskID=21247929

will take a look.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1481876] Review Request: python-pytest-shutil - A goodie-bag of unix shell and environment tools for py.test

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1481876



--- Comment #1 from Scott Talbert  ---
Doesn't build on rawhide:
running install_scripts
Traceback (most recent call last):
  File "setup.py", line 48, in 
setup(**kwargs)
  File "/usr/lib64/python2.7/distutils/core.py", line 151, in setup
dist.run_commands()
  File "/usr/lib64/python2.7/distutils/dist.py", line 953, in run_commands
self.run_command(cmd)
  File "/usr/lib64/python2.7/distutils/dist.py", line 972, in run_command
cmd_obj.run()
  File "/usr/lib/python2.7/site-packages/setuptools/command/install.py", line
61, in run
return orig.install.run(self)
  File "/usr/lib64/python2.7/distutils/command/install.py", line 575, in run
self.run_command(cmd_name)
  File "/usr/lib64/python2.7/distutils/cmd.py", line 326, in run_command
self.distribution.run_command(command)
  File "/usr/lib64/python2.7/distutils/dist.py", line 972, in run_command
cmd_obj.run()
  File
"/usr/lib/python2.7/site-packages/setuptools/command/install_scripts.py", line
33, in run
bs_cmd = (self.get_finalized_command('build_scripts', create=False) or
  File "/usr/lib64/python2.7/distutils/cmd.py", line 312, in
get_finalized_command
cmd_obj.ensure_finalized()
AttributeError: 'NoneType' object has no attribute 'ensure_finalized'
RPM build errors:
error: Bad exit status from /var/tmp/rpm-tmp.LN9Lc5 (%install)
Bad exit status from /var/tmp/rpm-tmp.LN9Lc5 (%install)
Child return code was: 1
EXCEPTION: [Error()]

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1481876] Review Request: python-pytest-shutil - A goodie-bag of unix shell and environment tools for py.test

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1481876

Scott Talbert  changed:

   What|Removed |Added

 CC||s...@techie.net
   Assignee|nob...@fedoraproject.org|s...@techie.net
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org