[Bug 1481912] Review Request: jbuilder - A composable build system for OCaml

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1481912



--- Comment #12 from Fedora Update System  ---
jbuilder-1.0-0.3.beta12.fc27 has been pushed to the Fedora 27 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1481912] Review Request: jbuilder - A composable build system for OCaml

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1481912

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2017-09-11 00:20:13



--- Comment #11 from Fedora Update System  ---
jbuilder-1.0-0.3.beta12.fc26 has been pushed to the Fedora 26 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1481912] Review Request: jbuilder - A composable build system for OCaml

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1481912



--- Comment #10 from Fedora Update System  ---
jbuilder-1.0-0.3.beta12.fc26 has been pushed to the Fedora 26 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-2df5fe23b2

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1481912] Review Request: jbuilder - A composable build system for OCaml

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1481912

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #9 from Fedora Update System  ---
jbuilder-1.0-0.3.beta12.fc27 has been pushed to the Fedora 27 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-774ffdb48d

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1481912] Review Request: jbuilder - A composable build system for OCaml

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1481912



--- Comment #8 from Fedora Update System  ---
jbuilder-1.0-0.3.beta12.fc26 has been submitted as an update to Fedora 26.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-2df5fe23b2

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1481912] Review Request: jbuilder - A composable build system for OCaml

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1481912

Fedora Update System  changed:

   What|Removed |Added

 Status|POST|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1481912] Review Request: jbuilder - A composable build system for OCaml

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1481912



--- Comment #7 from Fedora Update System  ---
jbuilder-1.0-0.3.beta12.fc27 has been submitted as an update to Fedora 27.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-774ffdb48d

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1481912] Review Request: jbuilder - A composable build system for OCaml

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1481912



--- Comment #6 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/jbuilder

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1481912] Review Request: jbuilder - A composable build system for OCaml

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1481912



--- Comment #5 from Ben Rosser  ---
Great, thanks for the review!

> - Bump version to beta12? https://github.com/janestreet/jbuilder/releases

Yes, fortunately beta12 came out soon after I posted the review request; there
were not many changes upstream. I have updated the spec with this (and your
other comments) and will import beta12. For posterity:

Spec URL: https://tc01.fedorapeople.org/ocaml/jbuilder/jbuilder.spec
SRPM URL:
https://tc01.fedorapeople.org/ocaml/jbuilder/jbuilder-1.0-0.3.beta12.fc26.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1481912] Review Request: jbuilder - A composable build system for OCaml

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1481912

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|NEW |POST
 CC||zebo...@gmail.com
   Assignee|nob...@fedoraproject.org|zebo...@gmail.com
  Flags||fedora-review+



--- Comment #4 from Robert-André Mauchin  ---
Hello,

Just tiny details:

 - Use this URL for Source0:

Source0:   
https://github.com/janestreet/%{libname}/archive/%{commit0}/%{libname}-%{shortcommit0}.tar.gz

 - Make use of predefined macros:

make release %{?_smp_mflags}
make doc

  →

%make_build release
%make_build doc

 - Bump version to beta12? https://github.com/janestreet/jbuilder/releases

 - Typo in the description:

jbuilder.x86_64: W: spelling-error %description -l en_US developpers ->
developers, developer


None of this is blocking, just fix what you want in import.


Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "LGPL", "Unknown or generated", "BSD (unspecified)", "LGPL
 (v2.1)", "ISC", "*No copyright* Apache (v2.0)". 816 files have unknown
 license. Detailed output of licensecheck in
 /home/bob/packaging/review/jbuilder/review-jbuilder/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package requires other packages for directories it uses.
 Note: No known owner of /usr/share/doc/jbuilder
[x]: Package must own all directories that it creates.
 Note: Directories without known owners: /usr/share/doc/jbuilder,
 /usr/lib64/ocaml
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[-]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 30720 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must 

[Bug 1481912] Review Request: jbuilder - A composable build system for OCaml

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1481912



--- Comment #3 from Ben Rosser  ---
The main packaging problem is that jbuilder uses opam-installer to install
itself, but jbuilder is required to package opam... so I have to manually
install the package files. However this is not too difficult since it's
currently just a binary and a bunch of documentation.

The actual build is pretty straightforward (aside from the bundled
dependencies, which cannot easily be removed).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1481912] Review Request: jbuilder - A composable build system for OCaml

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1481912



--- Comment #2 from Richard W.M. Jones  ---
https://anonscm.debian.org/git/pkg-ocaml-maint/packages/jbuilder.git/

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1481912] Review Request: jbuilder - A composable build system for OCaml

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1481912



--- Comment #1 from Richard W.M. Jones  ---
For reference here's the Debian packaging bug:
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=870130

I meant to ask Stephane how he intends to package this since
it didn't look very straightforward.

Also this is a dependency of new ocaml-lwt and some other
packages.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1481912] Review Request: jbuilder - A composable build system for OCaml

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1481912

Ben Rosser  changed:

   What|Removed |Added

 Blocks||1481913




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1481913
[Bug 1481913] Review Request: ocaml-zed - Abstract engine for text edition
in OCaml
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org