[Bug 1484164] Review Request: libsocketpp - C++ Standard I/O TCP sockets

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1484164

Jonathan Wakely  changed:

   What|Removed |Added

 CC||jwak...@redhat.com



--- Comment #14 from Jonathan Wakely  ---
This code leaks memory and doesn't close sockets.

Fedora already has a number of mature C++ libraries providing similar
functionality (boost-asio, asio, poco-net, ...) so I don't see why we would
want this anyway.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1484164] Review Request: libsocketpp - C++ Standard I/O TCP sockets

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1484164

Charlie Sale  changed:

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution|--- |DEFERRED
Last Closed||2017-09-13 10:39:22



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1484164] Review Request: libsocketpp - C++ Standard I/O TCP sockets

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1484164



--- Comment #13 from Charlie Sale  ---
Hey Neal

I am actually retracting my submission due to C++20 releasing a networking
library, which makes libsocketpp redundant and therefore unnecessary. Thanks
for your time anyways!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1484164] Review Request: libsocketpp - C++ Standard I/O TCP sockets

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1484164



--- Comment #12 from Neal Gompa  ---
> %global gittag0 v1.0.0

This is unnecessary, as %{version} is already defined at 1.0.0

> Source0:
> https://github.com/softwaresale/%{name}/archive/%{gittag0}/%{name}-%{version}.tar.gz

Change usage of "%{gittag0}" to "v%{version}". This lets you control the
version bump from a single location.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1484164] Review Request: libsocketpp - C++ Standard I/O TCP sockets

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1484164



--- Comment #11 from Neal Gompa  ---
> %autosetup -n %{name}-%{version}

This is redundant, just use "%autosetup", as "-n %{name}-%{version}" is the
default

> make %{?_smp_mflags}

Use %make_build

> rm -f $RPM_BUILD_ROOT/%{_infodir}/dir
> rm -f $RPM_BUILD_ROOT/%{_libdir}/libsocketpp.la

Use %{buildroot} instead of $RPM_BUILD_ROOT

> ldconfig

Use "/sbin/ldconfig"

> %postun
> ldconfig

Use "%postun -p /sbin/ldconfig"

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1484164] Review Request: libsocketpp - C++ Standard I/O TCP sockets

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1484164



--- Comment #10 from Charlie Sale  ---
Hey Neal. Can I have an update on the review process of my package? Is there
anything I can fix for you?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1484164] Review Request: libsocketpp - C++ Standard I/O TCP sockets

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1484164



--- Comment #9 from Charlie Sale  ---
Thanks a ton Neal. Let me know if you have 
any questions for me regarding sponsorship. My email is 

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1484164] Review Request: libsocketpp - C++ Standard I/O TCP sockets

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1484164

Neal Gompa  changed:

   What|Removed |Added

   Assignee|nob...@fedoraproject.org|ngomp...@gmail.com
  Flags||fedora-review?



--- Comment #8 from Neal Gompa  ---
I can sponsor, and I'll take the review.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1484164] Review Request: libsocketpp - C++ Standard I/O TCP sockets

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1484164



--- Comment #7 from Charlie Sale  ---
Everything is up to date. Note, the URLS from above need to be updated. Here
they are:

Spec:
https://raw.githubusercontent.com/softwaresale/libsocketpp_rpm_build_files/master/libsocketpp.spec

SRPM:
https://raw.githubusercontent.com/softwaresale/libsocketpp_rpm_build_files/master/libsocketpp-1.0.0-1.fc26.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1484164] Review Request: libsocketpp - C++ Standard I/O TCP sockets

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1484164



--- Comment #6 from Charlie Sale  ---
Thanks. I'll get that fixed and uploaded very soon. Are any of you able to
formally review my package or sponsor me? That would be really helpful...

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1484164] Review Request: libsocketpp - C++ Standard I/O TCP sockets

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1484164

Neal Gompa  changed:

   What|Removed |Added

 CC||ngomp...@gmail.com



--- Comment #5 from Neal Gompa  ---
Well, actually, the package spec needs to be reorganized and the package does
need to be slightly renamed...

Here's a relatively simple example of how a library package looks:
https://src.fedoraproject.org/rpms/libbluray/blob/master/f/libbluray.spec

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1484164] Review Request: libsocketpp - C++ Standard I/O TCP sockets

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1484164



--- Comment #4 from chucks.8...@gmail.com ---
Ok. Thanks!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1484164] Review Request: libsocketpp - C++ Standard I/O TCP sockets

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1484164

Rex Dieter  changed:

   What|Removed |Added

 CC||rdie...@gmail.com



--- Comment #3 from Rex Dieter  ---
don't rename it, it's fine as-is

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1484164] Review Request: libsocketpp - C++ Standard I/O TCP sockets

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1484164



--- Comment #2 from chucks.8...@gmail.com ---
Thanks. I'll get that fixed up. Quick question: because this is a development
library, should I add the suffix "-devel" to my package or not?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1484164] Review Request: libsocketpp - C++ Standard I/O TCP sockets

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1484164

Iwicki Artur  changed:

   What|Removed |Added

 CC||fed...@svgames.pl



--- Comment #1 from Iwicki Artur  ---
>Group: Development/Tools
The "Group:" tag should not be used.
https://fedoraproject.org/wiki/Packaging:Guidelines#Tags_and_Sections

>License:   GPL+
"GPL+" should only be used when upstream doesn't specify the licence version.
You're using GPL v3 or later, so the tag should be "GPLv3+".
https://fedoraproject.org/wiki/Licensing:Main#Good_Licenses

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1484164] Review Request: libsocketpp - C++ Standard I/O TCP sockets

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1484164

chucks.8...@gmail.com changed:

   What|Removed |Added

 Blocks||177841 (FE-NEEDSPONSOR)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org