[Bug 1484835] Review Request: erlang-stdlib2 - Erlang stdlib extensions

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1484835



--- Comment #9 from Fedora Update System  ---
erlang-chronos-0.5.1-1.fc27, erlang-hyper-0-0.1.20161011git4b1abc4.fc27,
erlang-stdlib2-0-0.1.20170810git5ccd9b2.fc27 has been pushed to the Fedora 27
stable repository. If problems still persist, please make note of it in this
bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1484835] Review Request: erlang-stdlib2 - Erlang stdlib extensions

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1484835

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2017-09-09 19:52:25



--- Comment #8 from Fedora Update System  ---
erlang-chronos-0.5.1-1.fc26, erlang-hyper-0-0.1.20161011git4b1abc4.fc26,
erlang-stdlib2-0-0.1.20170810git5ccd9b2.fc26 has been pushed to the Fedora 26
stable repository. If problems still persist, please make note of it in this
bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1484835] Review Request: erlang-stdlib2 - Erlang stdlib extensions

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1484835

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #6 from Fedora Update System  ---
erlang-chronos-0.5.1-1.fc27, erlang-hyper-0-0.1.20161011git4b1abc4.fc27,
erlang-stdlib2-0-0.1.20170810git5ccd9b2.fc27 has been pushed to the Fedora 27
testing repository. If problems still persist, please make note of it in this
bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-0a4e5fa602

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1484835] Review Request: erlang-stdlib2 - Erlang stdlib extensions

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1484835



--- Comment #5 from Fedora Update System  ---
erlang-stdlib2-0-0.1.20170810git5ccd9b2.fc27 erlang-chronos-0.5.1-1.fc27 has
been submitted as an update to Fedora 27.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-0a4e5fa602

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1484835] Review Request: erlang-stdlib2 - Erlang stdlib extensions

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1484835



--- Comment #4 from Fedora Update System  ---
erlang-chronos-0.5.1-1.fc26 erlang-stdlib2-0-0.1.20170810git5ccd9b2.fc26 has
been submitted as an update to Fedora 26.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-df3fecadc4

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1484835] Review Request: erlang-stdlib2 - Erlang stdlib extensions

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1484835

Fedora Update System  changed:

   What|Removed |Added

 Status|POST|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1484835] Review Request: erlang-stdlib2 - Erlang stdlib extensions

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1484835



--- Comment #3 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/erlang-stdlib2

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1484835] Review Request: erlang-stdlib2 - Erlang stdlib extensions

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1484835

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|NEW |POST
   Assignee|nob...@fedoraproject.org|zebo...@gmail.com
  Flags||fedora-review+



--- Comment #2 from Robert-André Mauchin  ---
Eureka! The test fails because my /tmp/ dir is totally empty but the test
expects some files in return. I had to "touch" a file in %prep to make it work.

Anyway, the review:

 - You should query upstream for a LICENSE file.

 - You should add comments above your patch, explaining what they do, or
better,  link to an upstream bug report.

None of this is blocking, so the package is accepted.


Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[-]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "ISC", "Apache (v2.0)", "Unknown or generated". 29 files have
 unknown license. Detailed output of licensecheck in
 /home/bob/packaging/review/erlang-stdlib2/review-erlang-
 stdlib2/licensecheck.txt
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[-]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

= SHOULD items =

Generic:
[!]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[!]: Patches link to upstream bugs/comments/lists or are otherwise
 justified.
[-]: Description and summary sections in the package 

[Bug 1484835] Review Request: erlang-stdlib2 - Erlang stdlib extensions

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1484835

Robert-André Mauchin  changed:

   What|Removed |Added

 CC||zebo...@gmail.com



--- Comment #1 from Robert-André Mauchin  ---
HEllo,


Thank again for your reviews.

The Group: tag is not used in Fedora. See
https://fedoraproject.org/wiki/Packaging:Guidelines#Tags_and_Sections


I've got tests failures in Mock:

module 's2_sh'
  s2_sh: cp_test...[0.002 s] ok
  s2_sh: ls_test...*failed*
in function s2_sh:ls_test/0 (src/s2_sh.erl, line 62)
**error:{badmatch,[]}
  output:<<"">>
  s2_sh: ls_l_test...*failed*
in function s2_sh:ls_l_test/0 (src/s2_sh.erl, line 68)
**error:{badmatch,[]}
  output:<<"">>

Hence the build fails afterwards. I'm gonna take a look at your two other
packages and see this one later.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1484835] Review Request: erlang-stdlib2 - Erlang stdlib extensions

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1484835

Peter Lemenkov  changed:

   What|Removed |Added

 Blocks||1484846




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1484846
[Bug 1484846] Review Request: erlang-hyper - An implementation of the
HyperLogLog algorithm in Erlang
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org