[Bug 1485503] Review Request: ghc-uri-bytestring - Haskell URI parsing as ByteStrings

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1485503

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2017-09-09 19:51:21



--- Comment #5 from Fedora Update System  ---
ghc-uri-bytestring-0.2.3.3-2.fc26 has been pushed to the Fedora 26 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1485503] Review Request: ghc-uri-bytestring - Haskell URI parsing as ByteStrings

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1485503

Elliott Sales de Andrade  changed:

   What|Removed |Added

 Blocks||1488612




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1488612
[Bug 1488612] Review Request: ghc-esqueleto - Type-safe EDSL for SQL
queries on persistent backends
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1485503] Review Request: ghc-uri-bytestring - Haskell URI parsing as ByteStrings

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1485503

Elliott Sales de Andrade  changed:

   What|Removed |Added

 Blocks||1488614




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1488614
[Bug 1488614] Review Request: ghc-persistent-template - Type-safe,
non-relational, multi-backend persistence
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1485503] Review Request: ghc-uri-bytestring - Haskell URI parsing as ByteStrings

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1485503

Elliott Sales de Andrade  changed:

   What|Removed |Added

 Blocks||1488608




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1488608
[Bug 1488608] Review Request: ghc-persistent-sqlite - Backend for the
persistent library using sqlite3
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1485503] Review Request: ghc-uri-bytestring - Haskell URI parsing as ByteStrings

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1485503

Elliott Sales de Andrade  changed:

   What|Removed |Added

 Blocks||1487901




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1487901
[Bug 1487901] Review Request: ghc-persistent - Type-safe, multi-backend
data serialization
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1485503] Review Request: ghc-uri-bytestring - Haskell URI parsing as ByteStrings

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1485503

Fedora Update System  changed:

   What|Removed |Added

 Status|POST|ON_QA



--- Comment #4 from Fedora Update System  ---
ghc-uri-bytestring-0.2.3.3-2.fc26 has been pushed to the Fedora 26 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-be8f34722f

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1485503] Review Request: ghc-uri-bytestring - Haskell URI parsing as ByteStrings

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1485503

Elliott Sales de Andrade  changed:

   What|Removed |Added

 Blocks||1486580




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1486580
[Bug 1486580] Review Request: ghc-http-api-data - Converting to/from HTTP
API data like URL pieces, headers and query parameters
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1485503] Review Request: ghc-uri-bytestring - Haskell URI parsing as ByteStrings

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1485503



--- Comment #3 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/ghc-uri-bytestring

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1485503] Review Request: ghc-uri-bytestring - Haskell URI parsing as ByteStrings

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1485503



--- Comment #2 from Elliott Sales de Andrade  ---
Fixed; I'll apply it during import.

Spec URL: https://qulogic.fedorapeople.org/git-annex/ghc-uri-bytestring.spec
SRPM URL:
https://qulogic.fedorapeople.org/git-annex/ghc-uri-bytestring-0.2.3.3-2.git.0.faf8182.fc26.src.rpm
Description: Uri-bytestring aims to be an RFC3986 compliant URI parser that
uses efficient ByteStrings for parsing and representing the URI data.
Fedora Account System Username: qulogic

koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=21488480

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1485503] Review Request: ghc-uri-bytestring - Haskell URI parsing as ByteStrings

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1485503

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|NEW |POST
 CC||zebo...@gmail.com
   Assignee|nob...@fedoraproject.org|zebo...@gmail.com
  Flags||fedora-review+



--- Comment #1 from Robert-André Mauchin  ---
Hello,

> %license LICENSE
> %license licenses/http-types/LICENSE

  The issue with doing this is that the second file will overwrite the first
one when they are copied in /usr/share/licenses/ghc-uri-bytestring because they
have the same name.

  I think you should rename the second one in %install, like this:

mv licenses/http-types/LICENSE licenses/http-types/http-type.LICENSE

  Then add it to %license:

> %license licenses/http-types/http-type.LICENSE


Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
 Note: Unversioned so-files in private %_libdir subdirectory (see
 attachment). Verify they are not in ld path.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "BSD (3 clause)", "Unknown or generated". 15 files have unknown
 license. Detailed output of licensecheck in /home/bob/packaging/review
 /ghc-uri-bytestring/review-ghc-uri-bytestring/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[-]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 604160 bytes in 23 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names