[Bug 1485720] Review Request: golang-github-linuxdeepin-go-x11-client - A X11 client Go bindings for Deepin Desktop Environment

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1485720

Zamir SUN  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2018-07-22 09:29:31



--- Comment #9 from Zamir SUN  ---
This is already in Rawhide. Closing on behalf of the Deepin Desktop packaging
effort.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/XNYPHBQBSLXYGRKJHDW7MFNE57GLSMYA/

[Bug 1485720] Review Request: golang-github-linuxdeepin-go-x11-client - A X11 client Go bindings for Deepin Desktop Environment

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1485720

Zamir SUN  changed:

   What|Removed |Added

 CC||szts...@gmail.com
  Alias||golang-github-linuxdeepin-g
   ||o-x11-client



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1485720] Review Request: golang-github-linuxdeepin-go-x11-client - A X11 client Go bindings for Deepin Desktop Environment

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1485720

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #8 from Fedora Update System  ---
golang-github-linuxdeepin-go-x11-client-0-0.1.git7a984cd.fc27 has been pushed
to the Fedora 27 testing repository. If problems still persist, please make
note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-a3c4106dde

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1485720] Review Request: golang-github-linuxdeepin-go-x11-client - A X11 client Go bindings for Deepin Desktop Environment

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1485720



--- Comment #7 from Fedora Update System  ---
golang-github-linuxdeepin-go-x11-client-0-0.1.git7a984cd.fc27 has been
submitted as an update to Fedora 27.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-a3c4106dde

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1485720] Review Request: golang-github-linuxdeepin-go-x11-client - A X11 client Go bindings for Deepin Desktop Environment

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1485720

Fedora Update System  changed:

   What|Removed |Added

 Status|POST|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1485720] Review Request: golang-github-linuxdeepin-go-x11-client - A X11 client Go bindings for Deepin Desktop Environment

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1485720



--- Comment #6 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/golang-github-linuxdeepin-go-x11-client

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1485720] Review Request: golang-github-linuxdeepin-go-x11-client - A X11 client Go bindings for Deepin Desktop Environment

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1485720

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|ASSIGNED|POST
  Flags|fedora-review?  |fedora-review+



--- Comment #5 from Robert-André Mauchin  ---
All good, package accepted.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1485720] Review Request: golang-github-linuxdeepin-go-x11-client - A X11 client Go bindings for Deepin Desktop Environment

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1485720



--- Comment #4 from sensor@gmail.com ---
https://github.com/FZUG/repo/commit/d1b8d290160f41993293a54c185ecd6deafaee01

Removed :)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1485720] Review Request: golang-github-linuxdeepin-go-x11-client - A X11 client Go bindings for Deepin Desktop Environment

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1485720



--- Comment #3 from Robert-André Mauchin  ---
You bypassed test by adding ||: , why is that? The tests do not fail even
without it.

%if ! 0%{?gotest:1}
%global gotest go test
%endif

%gotest %{import_path}



Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "Unknown or generated". 44 files have unknown license. Detailed
 output of licensecheck in /home/bob/packaging/review/golang-github-
 linuxdeepin-go-x11-client/review-golang-github-linuxdeepin-
 go-x11-client/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package requires other packages for directories it uses.
 Note: No known owner of /usr/share/gocode/src/github.com/linuxdeepin
[x]: Package must own all directories that it creates.
 Note: Directories without known owners: /usr/share/gocode/src,
 /usr/share/gocode/src/github.com/linuxdeepin, /usr/share/gocode,
 /usr/share/gocode/src/github.com
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[-]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
 Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in golang-
 github-linuxdeepin-go-x11-client-devel , golang-github-linuxdeepin-
 go-x11-client-unit-test-devel
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Description and summary sections in the package spec file contains
 translations for supported Non-English languages, if available.
[x]: %check is present and all tests pass.
[x]: Packages 

[Bug 1485720] Review Request: golang-github-linuxdeepin-go-x11-client - A X11 client Go bindings for Deepin Desktop Environment

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1485720



--- Comment #2 from sensor@gmail.com ---
SPEC: 
https://copr-be.cloud.fedoraproject.org/results/mosquito/deepin/fedora-26-x86_64/00594664-golang-github-linuxdeepin-go-x11-client/golang-github-linuxdeepin-go-x11-client.spec
SRPM: 
https://copr-be.cloud.fedoraproject.org/results/mosquito/deepin/fedora-26-x86_64/00594664-golang-github-linuxdeepin-go-x11-client/golang-github-linuxdeepin-go-x11-client-0-0.1.git7a984cd.fc26.src.rpm

Fixed, thanks.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1485720] Review Request: golang-github-linuxdeepin-go-x11-client - A X11 client Go bindings for Deepin Desktop Environment

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1485720

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||zebo...@gmail.com
   Assignee|nob...@fedoraproject.org|zebo...@gmail.com
  Flags||fedora-review?



--- Comment #1 from Robert-André Mauchin  ---
Hello,

The summary is wrong: "A fork" Please describe what this does succinctly.

There is absolutely no license indicated anywhere, how do you even know it's
GPLv3? Please query upstream about adding a license file. In any case, I can't
accept this without any proof of the license. It's not even specified in the
debian/copyright file.

You must own the following directory:
 /usr/share/gocode/src/github.com/linuxdeepin/go-x11-client/util,
 /usr/share/gocode/src/github.com/linuxdeepin/go-x11-client/util/wm,
 /usr/share/gocode/src/github.com/linuxdeepin/go-x11-client/ext

with:

%dir %{gopath}/src/%{import_path}/util
%dir %{gopath}/src/%{import_path}/util/wm
%dir %{gopath}/src/%{import_path}/ext

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1485720] Review Request: golang-github-linuxdeepin-go-x11-client - A X11 client Go bindings for Deepin Desktop Environment

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1485720

sensor@gmail.com changed:

   What|Removed |Added

 Blocks||1465889
   ||(DeepinDEPackageReview)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1465889
[Bug 1465889] Tracking: Deepin Desktop related package review tracker
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org