[Bug 1485975] Review Request: rubygem-activestorage - Attach cloud and local files in Rails applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1485975



--- Comment #7 from Pavel Valena  ---
Right, thanks.
It was just merged into Rails :).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/ATBQIUUJ5LU3VZF7WSX66FMBYA5ILBJM/

[Bug 1485975] Review Request: rubygem-activestorage - Attach cloud and local files in Rails applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1485975

Robert-André Mauchin  changed:

   What|Removed |Added

 CC||pval...@redhat.com



--- Comment #6 from Robert-André Mauchin  ---
*** Bug 1584100 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/YXZBNEQVFRARWYQ3CFCURFXIYKUJDVXH/

[Bug 1485975] Review Request: rubygem-activestorage - Attach cloud and local files in Rails applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1485975

Vít Ondruch  changed:

   What|Removed |Added

 Status|POST|CLOSED
   Fixed In Version||rubygem-activestorage-0.1-1
   ||.fc28
 Resolution|--- |RAWHIDE
Last Closed||2017-09-05 02:05:33



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1485975] Review Request: rubygem-activestorage - Attach cloud and local files in Rails applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1485975



--- Comment #5 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/rubygem-activestorage

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1485975] Review Request: rubygem-activestorage - Attach cloud and local files in Rails applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1485975



--- Comment #4 from Vít Ondruch  ---
(In reply to Robert-André Mauchin from comment #3)
> Ok, package accepted.

Thx

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1485975] Review Request: rubygem-activestorage - Attach cloud and local files in Rails applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1485975

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|ASSIGNED|POST
  Flags|fedora-review?  |fedora-review+



--- Comment #3 from Robert-André Mauchin  ---
Ok, package accepted.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1485975] Review Request: rubygem-activestorage - Attach cloud and local files in Rails applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1485975



--- Comment #2 from Vít Ondruch  ---
(In reply to Robert-André Mauchin from comment #1)
> Hello,
> 
> Shouldn't you add:
> 
> Requires:   ruby(rubygems)
> Provides:   rubygem(%{gem_name}) = %{version}-%{release}
> 
> It seems to me it's needed for other packages to be able to depend on
> rubygem(activestorage).

These are autogenerated:

~~~
$ rpm -qp --requires
https://kojipkgs.fedoraproject.org//work/tasks/8047/21518047/rubygem-activestorage-0.1-1.fc28.noarch.rpm
rpmlib(CompressedFileNames) <= 3.0.4-1
rpmlib(FileDigests) <= 4.6.0-1
rpmlib(PayloadFilesHavePrefix) <= 4.0-1
rpmlib(PayloadIsXz) <= 5.2-1
ruby(rubygems)
rubygem(actionpack) >= 5.1
rubygem(activejob) >= 5.1
rubygem(activerecord) >= 5.1
rubygem(activesupport) >= 5.1

$ rpm -qp --provides
https://kojipkgs.fedoraproject.org//work/tasks/8047/21518047/rubygem-activestorage-0.1-1.fc28.noarch.rpm
rubygem(activestorage) = 0.1-1
rubygem-activestorage = 0.1-1.fc28
~~~

Guidelines [1] mention this as well.

Thx for the review!


[1] https://fedoraproject.org/wiki/Packaging:Ruby#RubyGems

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1485975] Review Request: rubygem-activestorage - Attach cloud and local files in Rails applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1485975

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||zebo...@gmail.com
   Assignee|nob...@fedoraproject.org|zebo...@gmail.com
  Flags||fedora-review?



--- Comment #1 from Robert-André Mauchin  ---
Hello,

Shouldn't you add:

Requires:   ruby(rubygems)
Provides:   rubygem(%{gem_name}) = %{version}-%{release}

It seems to me it's needed for other packages to be able to depend on
rubygem(activestorage).

No issue besides that. I'll accept the package once I've got your answer on
this.


Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "MIT/X11 (BSD like)", "Unknown or generated". 40 files have
 unknown license. Detailed output of licensecheck in
 /home/bob/packaging/review/rubygem-activestorage/review-rubygem-
 activestorage/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package must own all directories that it creates.
 Note: Directories without known owners: /usr/share/gems,
 /usr/share/gems/doc
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

Ruby:
[x]: Platform dependent files must all go under %{gem_extdir_mri}, platform
 independent under %{gem_dir}.
[x]: Gem package must not define a non-gem subpackage
[x]: Macro %{gem_extdir} is deprecated.
[x]: Gem package is named rubygem-%{gem_name}
[x]: Package contains BuildRequires: rubygems-devel.
[x]: Gem package must define %{gem_name} macro.
[x]: Pure Ruby package must be built as noarch
[x]: Package does not contain Requires: ruby(abi).

= SHOULD items =

Generic:
[x]: Avoid