[Bug 1486068] Review Request: ocaml-dose3 - Framework for managing distribution packages and dependencies

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1486068

Ben Rosser  changed:

   What|Removed |Added

 Status|POST|CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2018-01-23 13:03:22



--- Comment #8 from Ben Rosser  ---
This has since been built for Rawhide, and more recently, stable branches.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1486068] Review Request: ocaml-dose3 - Framework for managing distribution packages and dependencies

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1486068
Bug 1486068 depends on bug 1480794, which changed state.

Bug 1480794 Summary: Review Request: ocaml-cudf - Format for describing upgrade 
scenarios
https://bugzilla.redhat.com/show_bug.cgi?id=1480794

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1486068] Review Request: ocaml-dose3 - Framework for managing distribution packages and dependencies

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1486068



--- Comment #7 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/ocaml-dose3

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1486068] Review Request: ocaml-dose3 - Framework for managing distribution packages and dependencies

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1486068



--- Comment #6 from Ben Rosser  ---
> It's reviewed already, but yes I believe you are correct about
> the subpackage.  The main package is an OCaml library so it of
> course does need to remain ocaml-*, as is the case.

Thanks for the confirmation!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1486068] Review Request: ocaml-dose3 - Framework for managing distribution packages and dependencies

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1486068



--- Comment #5 from Richard W.M. Jones  ---
(In reply to Ben Rosser from comment #3)
> Switched to using the configure macro.
> 
> Spec URL: https://tc01.fedorapeople.org/ocaml/opam/ocaml-dose3.spec
> SRPM URL:
> https://tc01.fedorapeople.org/ocaml/opam/ocaml-dose3-5.0.1-2.fc25.src.rpm
> 
> I also removed the unnecessary Requires on the main package from the
> dose3-tools subpackage. This makes me reasonably confident that the
> package's name shouldn't have an ocaml- prefix. Let me know if you disagree.

It's reviewed already, but yes I believe you are correct about
the subpackage.  The main package is an OCaml library so it of
course does need to remain ocaml-*, as is the case.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1486068] Review Request: ocaml-dose3 - Framework for managing distribution packages and dependencies

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1486068

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|ASSIGNED|POST
  Flags|fedora-review?  |fedora-review+



--- Comment #4 from Robert-André Mauchin  ---
All good, package accepted.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1486068] Review Request: ocaml-dose3 - Framework for managing distribution packages and dependencies

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1486068



--- Comment #3 from Ben Rosser  ---
Switched to using the configure macro.

Spec URL: https://tc01.fedorapeople.org/ocaml/opam/ocaml-dose3.spec
SRPM URL:
https://tc01.fedorapeople.org/ocaml/opam/ocaml-dose3-5.0.1-2.fc25.src.rpm

I also removed the unnecessary Requires on the main package from the
dose3-tools subpackage. This makes me reasonably confident that the package's
name shouldn't have an ocaml- prefix. Let me know if you disagree.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1486068] Review Request: ocaml-dose3 - Framework for managing distribution packages and dependencies

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1486068
Bug 1486068 depends on bug 1174036, which changed state.

Bug 1174036 Summary: Review Request: ocaml-re - OCaml regular expression library
https://bugzilla.redhat.com/show_bug.cgi?id=1174036

   What|Removed |Added

 Status|POST|CLOSED
 Resolution|--- |RAWHIDE



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1486068] Review Request: ocaml-dose3 - Framework for managing distribution packages and dependencies

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1486068

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||zebo...@gmail.com
   Assignee|nob...@fedoraproject.org|zebo...@gmail.com
  Flags||fedora-review?



--- Comment #2 from Robert-André Mauchin  ---
Hello,

Instead of:

./configure --with-zip --with-oUnit --with-rpm4 --with-xml --prefix %{_prefix}
--libdir %{_libdir} --bindir %{_bindir}

You should use:

%configure --with-zip --with-oUnit --with-rpm4 --with-xml



Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
 Note: Unversioned so-files in private %_libdir subdirectory (see
 attachment). Verify they are not in ld path.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "LGPL", "GPL (v3 or later)", "Unknown or generated", "GPL (v3
 or later) LGPL (v3 or later)", "*No copyright* LGPL", "LGPL (v3 or
 later)", "LGPL (v3)". 105 files have unknown license. Detailed output
 of licensecheck in /home/bob/packaging/review/ocaml-dose3/review-
 ocaml-dose3/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 368640 bytes in 6 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Ocaml:
[x]: This should never happen

= SHOULD 

[Bug 1486068] Review Request: ocaml-dose3 - Framework for managing distribution packages and dependencies

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1486068

Ben Rosser  changed:

   What|Removed |Added

 Depends On||1480794




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1480794
[Bug 1480794] Review Request: ocaml-cudf - Format for describing upgrade
scenarios
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1486068] Review Request: ocaml-dose3 - Framework for managing distribution packages and dependencies

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1486068

Ben Rosser  changed:

   What|Removed |Added

 Blocks||1185099
 CC||j...@recoil.org



--- Comment #1 from Ben Rosser  ---
*** Bug 1183826 has been marked as a duplicate of this bug. ***


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1185099
[Bug 1185099] Review Request: opam - A source-based package manager for
OCaml
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1486068] Review Request: ocaml-dose3 - Framework for managing distribution packages and dependencies

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1486068

Ben Rosser  changed:

   What|Removed |Added

 Depends On||1174036




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1174036
[Bug 1174036] Review Request: ocaml-re - OCaml regular expression library
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org