[Bug 1487542] Review Request: R-sp - Classes and Methods for Spatial Data

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1487542



--- Comment #11 from Fedora Update System  ---
R-sp-1.2.5-3.fc27 has been pushed to the Fedora 27 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1487542] Review Request: R-sp - Classes and Methods for Spatial Data

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1487542

Elliott Sales de Andrade  changed:

   What|Removed |Added

 Blocks||1489340




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1489340
[Bug 1489340] Review Request: R-jsonlite - A Robust, High Performance JSON
Parser and Generator for R
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1487542] Review Request: R-sp - Classes and Methods for Spatial Data

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1487542

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2017-09-18 23:25:19



--- Comment #10 from Fedora Update System  ---
R-sp-1.2.5-3.fc26 has been pushed to the Fedora 26 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1487542] Review Request: R-sp - Classes and Methods for Spatial Data

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1487542



--- Comment #9 from Fedora Update System  ---
R-sp-1.2.5-3.fc26 has been pushed to the Fedora 26 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-1f412b5197

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1487542] Review Request: R-sp - Classes and Methods for Spatial Data

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1487542

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #8 from Fedora Update System  ---
R-sp-1.2.5-3.fc27 has been pushed to the Fedora 27 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-2d62b6e845

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1487542] Review Request: R-sp - Classes and Methods for Spatial Data

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1487542



--- Comment #7 from Fedora Update System  ---
R-sp-1.2.5-3.fc27 has been submitted as an update to Fedora 27.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-2d62b6e845

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1487542] Review Request: R-sp - Classes and Methods for Spatial Data

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1487542

Fedora Update System  changed:

   What|Removed |Added

 Status|POST|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1487542] Review Request: R-sp - Classes and Methods for Spatial Data

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1487542



--- Comment #6 from Fedora Update System  ---
R-sp-1.2.5-3.fc26 has been submitted as an update to Fedora 26.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-1f412b5197

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1487542] Review Request: R-sp - Classes and Methods for Spatial Data

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1487542



--- Comment #5 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/R-sp

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1487542] Review Request: R-sp - Classes and Methods for Spatial Data

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1487542

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|ASSIGNED|POST
  Flags|fedora-review?  |fedora-review+



--- Comment #4 from Robert-André Mauchin  ---
Rpmlint is happy, package accepted!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1487542] Review Request: R-sp - Classes and Methods for Spatial Data

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1487542



--- Comment #3 from Elliott Sales de Andrade  ---
Fixed.

Spec URL:
https://copr-be.cloud.fedoraproject.org/results/qulogic/IRkernel/fedora-rawhide-x86_64/00597336-R-sp/R-sp.spec
SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/qulogic/IRkernel/fedora-rawhide-x86_64/00597336-R-sp/R-sp-1.2.5-3.fc28.src.rpm
Description: Classes and methods for spatial data; the classes document where
the spatial location information resides, for 2D or 3D data. Utility functions
are provided, e.g. for plotting data as maps, spatial selection, as well as
methods for retrieving coordinates, for subsetting, print, summary, etc.
Fedora Account System Username: qulogic

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1487542] Review Request: R-sp - Classes and Methods for Spatial Data

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1487542



--- Comment #2 from Elliott Sales de Andrade  ---
No, you're right. These should have been put in a -devel subpackage:
https://fedoraproject.org/wiki/Packaging:R#R_headers

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1487542] Review Request: R-sp - Classes and Methods for Spatial Data

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1487542

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||zebo...@gmail.com
   Assignee|nob...@fedoraproject.org|zebo...@gmail.com
  Flags||fedora-review?



--- Comment #1 from Robert-André Mauchin  ---
Hello Elliott,

 - There's an extra rm -rf in %install, I guess you forgot to remove it from
the template:

%install
rm -rf %{buildroot}

 - No license file: you should query upstream for inclusion of one.

 - I'm not knowledgeable enough regarding all the subtlety of R packaging, but
could you explain why there *.h and *.c files in
%{rlibdir}/%{packname}/include? Shouldn't they be in a -devel subpackage?
Rpmlint is not happy about these, but maybe they are needed in the main
package?


Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
 Note: Unversioned so-files in private %_libdir subdirectory (see
 attachment). Verify they are not in ld path.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[-]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "Unknown or generated". 207 files have unknown license.
 Detailed output of licensecheck in
 /home/bob/packaging/review/R-sp/review-R-sp/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package does not own files or directories owned by other packages.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[!]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
 Note: rm -rf %{buildroot} present but not required
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.