[Bug 1512226] Review Request: python3-flask-cors - Cross Origin Resource Sharing ( CORS ) support for Flask

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1512226



--- Comment #14 from František Zatloukal  ---
New Review Request was created:
https://bugzilla.redhat.com/show_bug.cgi?id=1671273

David, thanks for your work on initial packaging.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1512226] Review Request: python3-flask-cors - Cross Origin Resource Sharing ( CORS ) support for Flask

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1512226



--- Comment #13 from Miro Hrončok  ---
Make sure to name the source package python-flask-cors and feel free to CC me
on the review request, I'll try to review it promptly.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1512226] Review Request: python3-flask-cors - Cross Origin Resource Sharing ( CORS ) support for Flask

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1512226

František Zatloukal  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Blocks|177841 (FE-NEEDSPONSOR) |201449 (FE-DEADREVIEW)
 Resolution|--- |NOTABUG
  Flags|fedora-review?  |
Last Closed||2019-01-31 09:31:51



--- Comment #12 from František Zatloukal  ---
Closing since there is no reply from original submitter as per
https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews . I'll create
new review request for this soon.


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor
https://bugzilla.redhat.com/show_bug.cgi?id=201449
[Bug 201449] FE-DEADREVIEW -- Reviews stalled due to lack of submitter response
should be blocking this bug.
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1512226] Review Request: python3-flask-cors - Cross Origin Resource Sharing ( CORS ) support for Flask

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1512226

František Zatloukal  changed:

   What|Removed |Added

 CC||fzatl...@redhat.com



--- Comment #11 from František Zatloukal  ---
This review is stalled [0] .

David, please respond within one week if you are still interested in packaging
python3-flask-cors or I am going to close this ticket and take care of
packaging python3-flask-cors myself in one week.

[0] https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1512226] Review Request: python3-flask-cors - Cross Origin Resource Sharing ( CORS ) support for Flask

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1512226

Robert-André Mauchin  changed:

   What|Removed |Added

 CC||zebo...@gmail.com
  Flags||needinfo?(ddavidcarlos1392@
   ||gmail.com)



--- Comment #10 from Robert-André Mauchin  ---
Sell interested by packaging David?

I'm proposing you to review
https://bugzilla.redhat.com/show_bug.cgi?id=1636111

Please be thorough. The guidelines are here to help you:
https://docs.fedoraproject.org/en-US/packaging-guidelines

If you want to be extra diligent, you can look at the recent Packaging 
Committee issue: https://pagure.io/packaging-committee/issues

Please include a reference to the appropriate guideline for most errors you 
find.

Post the review here or send me an email.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1512226] Review Request: python3-flask-cors - Cross Origin Resource Sharing ( CORS ) support for Flask

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1512226



--- Comment #9 from Athos Ribeiro  ---
Hi David,

Your package looks good to me and we are ready to moving forward on sponsoring
you into the packagers group. Any news on those informal package reviews? You
can link them here :)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1512226] Review Request: python3-flask-cors - Cross Origin Resource Sharing ( CORS ) support for Flask

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1512226



--- Comment #8 from Aivar Annamaa  ---
This looks good to my (beginner) eye!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1512226] Review Request: python3-flask-cors - Cross Origin Resource Sharing ( CORS ) support for Flask

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1512226



--- Comment #7 from David Carlos  ---
I have generated another build fixing some issues

Copr build:
https://copr-be.cloud.fedoraproject.org/results/davidcarlos/flask-cors/fedora-rawhide-x86_64/00677820-python-flask-cors/
Spec:
https://copr-be.cloud.fedoraproject.org/results/davidcarlos/flask-cors/fedora-rawhide-x86_64/00677820-python-flask-cors/python-flask-cors.spec
Srpm:
https://copr-be.cloud.fedoraproject.org/results/davidcarlos/flask-cors/fedora-rawhide-x86_64/00677820-python-flask-cors/python-flask-cors-3.0.3-5.fc28.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1512226] Review Request: python3-flask-cors - Cross Origin Resource Sharing ( CORS ) support for Flask

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1512226



--- Comment #6 from David Carlos  ---
Hello,

Thanks for the review. I have generated a new release of python-cors package,
based on your reviews.

Copr build:
https://copr.fedorainfracloud.org/coprs/davidcarlos/flask-cors/build/677573/
Spec:
https://copr-be.cloud.fedoraproject.org/results/davidcarlos/flask-cors/fedora-rawhide-x86_64/00677573-flask-cors/flask-cors.spec
Srpm:
https://copr-be.cloud.fedoraproject.org/results/davidcarlos/flask-cors/fedora-rawhide-x86_64/00677573-flask-cors/flask-cors-3.0.3-3.fc28.src.rpm
Rpm:
https://copr-be.cloud.fedoraproject.org/results/davidcarlos/flask-cors/fedora-rawhide-x86_64/00677573-flask-cors/python3-flask-cors-3.0.3-3.fc28.noarch.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1512226] Review Request: python3-flask-cors - Cross Origin Resource Sharing ( CORS ) support for Flask

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1512226



--- Comment #5 from Miro Hrončok  ---
(In reply to Aivar Annamaa from comment #4)
> - "Requres:" part is missing. I would use "Requires: %{py3_dist flask six}". 
>   Not sure how it should be if common Python 2 + Python 3 package is wanted.
>   Looks like in some case it's done with conditionals
>   (eg. https://apps.fedoraproject.org/packages/python-flask-wtf/sources/spec)
>   but if I've understood correctly then 
>   "Requires: %{py2_dist flask six} %{py3_dist flask six}" would also do the
> right thing

Each subpackage has it's own Requires. In this case, the only subpackage should
have %{py3_dist flask six} (or similar).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1512226] Review Request: python3-flask-cors - Cross Origin Resource Sharing ( CORS ) support for Flask

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1512226

Aivar Annamaa  changed:

   What|Removed |Added

 CC||aivar.anna...@gmail.com



--- Comment #4 from Aivar Annamaa  ---
Here is my unofficial review. (It is also my first package review.)
I did not repeat the issues reported by Athos.

During review I also created an alternative spec-file which fixed some of the
problems listed below. Should I post this as well?

General comments: I think it's a useful package. The spec file was clearly
written but requires more work.

Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated


Issues:
===
- Source package name should be python-flask-cors and python3-flask-cors 
  should defined as subpackage (as Miro already said).
  See also
https://fedoraproject.org/wiki/Packaging:Naming?rd=Packaging:NamingGuidelines#Python_source_package_naming
  This would allow providing binary packages for both Python 2 and Python 3
  (I tried this approach and was able to build both).

- "Requres:" part is missing. I would use "Requires: %{py3_dist flask six}". 
  Not sure how it should be if common Python 2 + Python 3 package is wanted.
  Looks like in some case it's done with conditionals
  (eg. https://apps.fedoraproject.org/packages/python-flask-wtf/sources/spec)
  but if I've understood correctly then 
  "Requires: %{py2_dist flask six} %{py3_dist flask six}" would also do the
right thing
 
(https://fedoraproject.org/wiki/Packaging:Python#Requires_and_BuildRequires_with_standardized_names).

- I would use %py3_build instead of `%{__python3} setup.py build` 
  and %py3_install instead of `%{__python3} setup.py install -O1 --skip-build
--root $RPM_BUILD_ROOT`

- Sources used to build the package match the upstream source, as provided
  in the spec URL.
  Note: Upstream MD5sum check error, diff:
- Only in upstream-unpacked/Source0: flask-cors-3.0.3
- Only in srpm-unpacked/3.0.3.tar.gz-extract: python3-flask-cors-3.0.3
  Looks like in the tar.gz in srpm, the top directory has been renamed.

- Why are there spaces between CORS and parentheses in Summary?


= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[!]: Package is named according to the Package Naming Guidelines.
 Note: See the "Issues" section above
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[!]: Requires correct, justified where necessary.
 Note: Requires is missing. See the "Issues" section above
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 30720 bytes in 4 files.
[x]: Package complies to the Packaging Guidelines
 Note: Python specific problems listed separately.
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set 

[Bug 1512226] Review Request: python3-flask-cors - Cross Origin Resource Sharing ( CORS ) support for Flask

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1512226

Miro Hrončok  changed:

   What|Removed |Added

 CC||mhron...@redhat.com



--- Comment #3 from Miro Hrončok  ---
Since python-flask-cors is not in Fedora, the source package should be named
just python-flask-cors and the package should produce the python3-flask-cors
subpackage (no need for python2-flask-cors at all, but the structure must allow
it).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1512226] Review Request: python3-flask-cors - Cross Origin Resource Sharing ( CORS ) support for Flask

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1512226



--- Comment #2 from Athos Ribeiro  ---
- You should use the python macros for building and installing the package. See
[1].

- The docs directory contains the sources for the package documentation, not
the actual documentation. You want to either compile the docs and provide them
compiled or not provide them at all (I'd prefer the first option). Also, The
README and CHANGELOG files should also go in %doc since they may contain useful
information for users.

- Please, see [2] to set the proper Source URL for the package according to
Fedora guidelines.

Note that the package does not build at the moment: 

cd python3-flask-cors-3.0.3
/var/tmp/rpm-tmp.4frmkX: line 38: cd: python3-flask-cors-3.0.3: No such file or
directory

It cannot find the proper directory. This will be fixed when you address the
source name issue, but it could also be addressed by passing the source dir
name to %autosetup (do stick with the first option: fix the source url).

When you make changes during this review, please bump the package release so I
can see you can properly do so.

Please, provide a koji scratch build (or a copr build) of the package so I can
see your package does build without the need to build it here (I will build the
package during the review, but I want to see you took the time to make sure it
does build correctly).

[1] https://fedoraproject.org/wiki/Packaging:Python
[2]
https://fedoraproject.org/wiki/Packaging:SourceURL?rd=Packaging/SourceURL#Git_Tags

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1512226] Review Request: python3-flask-cors - Cross Origin Resource Sharing ( CORS ) support for Flask

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1512226

Athos Ribeiro  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||athoscribe...@gmail.com
   Assignee|nob...@fedoraproject.org|athoscribe...@gmail.com
  Flags||fedora-review?



--- Comment #1 from Athos Ribeiro  ---
Hi David,

As we have spoken before, I will sponsor you in the packagers group. While I
review your package, it would be nice to see a few informal package reviews
from you. [1] and [2] may help you with that. You can post the links for your
informal reviews in this bug.

Also, please send an email to the devel mailing list introducing yourself with
a link to this bug.

[1] https://fedoraproject.org/wiki/Packaging:ReviewGuidelines
[2] https://fedoraproject.org/wiki/Package_Review_Process

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1512226] Review Request: python3-flask-cors - Cross Origin Resource Sharing ( CORS ) support for Flask

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1512226

David Carlos  changed:

   What|Removed |Added

 CC||ddavidcarlos1...@gmail.com
 Blocks||177841 (FE-NEEDSPONSOR)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org