[Bug 1532042] Review Request: compton - Compositor for X11

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1532042



--- Comment #37 from Fedora Update System  ---
compton-0.1-0.1.beta3.fc28 has been pushed to the Fedora 28 stable repository.
If problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1532042] Review Request: compton - Compositor for X11

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1532042

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed|2018-03-31 00:41:38 |2018-04-04 13:09:58



--- Comment #36 from Fedora Update System  ---
compton-0.1-0.1.beta3.fc27 has been pushed to the Fedora 27 stable repository.
If problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1532042] Review Request: compton - Compositor for X11

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1532042



--- Comment #35 from Fedora Update System  ---
compton-0.1-0.1.beta3.fc28 has been pushed to the Fedora 28 testing repository.
If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2018-b49f47d617

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1532042] Review Request: compton - Compositor for X11

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1532042

Fedora Update System  changed:

   What|Removed |Added

 Status|CLOSED  |ON_QA
 Resolution|CURRENTRELEASE  |---
   Keywords||Reopened



--- Comment #34 from Fedora Update System  ---
compton-0.1-0.1.beta3.fc27 has been pushed to the Fedora 27 testing repository.
If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2018-2c82c86437

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1532042] Review Request: compton - Compositor for X11

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1532042



--- Comment #33 from Fedora Update System  ---
compton-0.1-0.1.beta3.fc28 has been submitted as an update to Fedora 28.
https://bodhi.fedoraproject.org/updates/FEDORA-2018-b49f47d617

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1532042] Review Request: compton - Compositor for X11

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1532042



--- Comment #32 from Fedora Update System  ---
compton-0.1-0.1.beta3.fc27 has been submitted as an update to Fedora 27.
https://bodhi.fedoraproject.org/updates/FEDORA-2018-2c82c86437

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1532042] Review Request: compton - Compositor for X11

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1532042

Abhiram K <4kuch...@gmail.com> changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |CURRENTRELEASE
Last Closed||2018-03-31 00:41:38



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1532042] Review Request: compton - Compositor for X11

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1532042



--- Comment #31 from Jaroslav Škarvada  ---
(In reply to Abhiram K from comment #30)
> (In reply to Jaroslav Škarvada from comment #29)
> > (In reply to Abhiram K from comment #28)
> > > I'm not a packager yet. I would like to be sponsored though.
> > > 
> > > The issue wasn't thrown by a tool. I was able to request a repo, but my
> > > request was denied because this review request was 'approved by a user and
> > > not a packager'.
> > 
> > OK, thanks for info. I will sponsor you. Please give me your FAS account
> > name and please sign "Fedora Project Contributor Agreement" in FAS (in case
> > you haven't already done it).
> 
> My FAS: axeld
> 
> I already have CLA+1 on FAS.
> 
> Thanks for sponsoring me! :D

OK, you are sponsored now, enjoy :) Feel free to ask me anytime if you need
help.

Give it few minutes for the change to propagate, then try the new repo request
again. If it's denied, please provide me the link to the denied request.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1532042] Review Request: compton - Compositor for X11

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1532042



--- Comment #30 from Abhiram K <4kuch...@gmail.com> ---
(In reply to Jaroslav Škarvada from comment #29)
> (In reply to Abhiram K from comment #28)
> > I'm not a packager yet. I would like to be sponsored though.
> > 
> > The issue wasn't thrown by a tool. I was able to request a repo, but my
> > request was denied because this review request was 'approved by a user and
> > not a packager'.
> 
> OK, thanks for info. I will sponsor you. Please give me your FAS account
> name and please sign "Fedora Project Contributor Agreement" in FAS (in case
> you haven't already done it).

My FAS: axeld

I already have CLA+1 on FAS.

Thanks for sponsoring me! :D

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1532042] Review Request: compton - Compositor for X11

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1532042

Jaroslav Škarvada  changed:

   What|Removed |Added

 Blocks|177841 (FE-NEEDSPONSOR) |



--- Comment #29 from Jaroslav Škarvada  ---
(In reply to Abhiram K from comment #28)
> I'm not a packager yet. I would like to be sponsored though.
> 
> The issue wasn't thrown by a tool. I was able to request a repo, but my
> request was denied because this review request was 'approved by a user and
> not a packager'.

OK, thanks for info. I will sponsor you. Please give me your FAS account name
and please sign "Fedora Project Contributor Agreement" in FAS (in case you
haven't already done it).


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1532042] Review Request: compton - Compositor for X11

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1532042



--- Comment #28 from Abhiram K <4kuch...@gmail.com> ---
(In reply to Jaroslav Škarvada from comment #27)
> (In reply to Jaroslav Škarvada from comment #26)
> > (In reply to Jaroslav Škarvada from comment #25)
> > > (In reply to Abhiram K from comment #24)
> > > > What exactly should I title the ticket?
> > > > I'm not quite sure what I should name it.
> > > 
> > > New ticket:
> > > https://pagure.io/fedora-infrastructure/new_issue
> > > 
> > > It depends what tool returned you the error. I would write there something
> > > like "Unable to request repo for reviewed package" or similar. I could 
> > > open
> > > it myself, but I don't know the details nor could provide more information
> > > if requested.
> > 
> > Ah sorry, are you already packager?
> > 
> > Maybe the problem is not about James but you, are you sponsored by someone?
> 
> I noticed:
> FE-NEEDSPONSOR flag
> 
> If you aren't sponsored, I can sponsor you, because you fulfilled the
> requirements to be sponsored.

I'm not a packager yet. I would like to be sponsored though.

The issue wasn't thrown by a tool. I was able to request a repo, but my request
was denied because this review request was 'approved by a user and not a
packager'.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1532042] Review Request: compton - Compositor for X11

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1532042



--- Comment #27 from Jaroslav Škarvada  ---
(In reply to Jaroslav Škarvada from comment #26)
> (In reply to Jaroslav Škarvada from comment #25)
> > (In reply to Abhiram K from comment #24)
> > > What exactly should I title the ticket?
> > > I'm not quite sure what I should name it.
> > 
> > New ticket:
> > https://pagure.io/fedora-infrastructure/new_issue
> > 
> > It depends what tool returned you the error. I would write there something
> > like "Unable to request repo for reviewed package" or similar. I could open
> > it myself, but I don't know the details nor could provide more information
> > if requested.
> 
> Ah sorry, are you already packager?
> 
> Maybe the problem is not about James but you, are you sponsored by someone?

I noticed:
FE-NEEDSPONSOR flag

If you aren't sponsored, I can sponsor you, because you fulfilled the
requirements to be sponsored.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1532042] Review Request: compton - Compositor for X11

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1532042



--- Comment #26 from Jaroslav Škarvada  ---
(In reply to Jaroslav Škarvada from comment #25)
> (In reply to Abhiram K from comment #24)
> > What exactly should I title the ticket?
> > I'm not quite sure what I should name it.
> 
> New ticket:
> https://pagure.io/fedora-infrastructure/new_issue
> 
> It depends what tool returned you the error. I would write there something
> like "Unable to request repo for reviewed package" or similar. I could open
> it myself, but I don't know the details nor could provide more information
> if requested.

Ah sorry, are you already packager?

Maybe the problem is not about James but you, are you sponsored by someone?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1532042] Review Request: compton - Compositor for X11

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1532042



--- Comment #25 from Jaroslav Škarvada  ---
(In reply to Abhiram K from comment #24)
> What exactly should I title the ticket?
> I'm not quite sure what I should name it.

New ticket:
https://pagure.io/fedora-infrastructure/new_issue

It depends what tool returned you the error. I would write there something like
"Unable to request repo for reviewed package" or similar. I could open it
myself, but I don't know the details nor could provide more information if
requested.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1532042] Review Request: compton - Compositor for X11

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1532042



--- Comment #24 from Abhiram K <4kuch...@gmail.com> ---
(In reply to Jaroslav Škarvada from comment #23)
> (In reply to Abhiram K from comment #22)
> > (In reply to James Paul Turner from comment #21)
> > > No problem Abhiram. Everything seems to be OK. koji scratch builds 
> > > passing:
> > > 
> > > https://koji.fedoraproject.org/koji/taskinfo?taskID=26019541
> > > https://koji.fedoraproject.org/koji/taskinfo?taskID=26019531
> > > 
> > > I'm marking thins as accepted. You may now proceed with the
> > > import/build/update process, and then close this ticket once complete. 
> > > Post
> > > a comment here if you get stuck.
> > 
> > I'm not able to request a repo because "The Bugzilla bug's review is
> > approved by a user that is not a packager".
> 
> Hmm, strange, I am sponsor of James (FAS nick: jamesturner246), he is
> already in the packager group. Could you please open infrastructure ticket
> about it and link it here? I could approve the review myself, but I think
> the problem should be resolved, not workarounded.

What exactly should I title the ticket?
I'm not quite sure what I should name it.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1532042] Review Request: compton - Compositor for X11

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1532042



--- Comment #23 from Jaroslav Škarvada  ---
(In reply to Abhiram K from comment #22)
> (In reply to James Paul Turner from comment #21)
> > No problem Abhiram. Everything seems to be OK. koji scratch builds passing:
> > 
> > https://koji.fedoraproject.org/koji/taskinfo?taskID=26019541
> > https://koji.fedoraproject.org/koji/taskinfo?taskID=26019531
> > 
> > I'm marking thins as accepted. You may now proceed with the
> > import/build/update process, and then close this ticket once complete. Post
> > a comment here if you get stuck.
> 
> I'm not able to request a repo because "The Bugzilla bug's review is
> approved by a user that is not a packager".

Hmm, strange, I am sponsor of James (FAS nick: jamesturner246), he is already
in the packager group. Could you please open infrastructure ticket about it and
link it here? I could approve the review myself, but I think the problem should
be resolved, not workarounded.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1532042] Review Request: compton - Compositor for X11

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1532042



--- Comment #22 from Abhiram K <4kuch...@gmail.com> ---
(In reply to James Paul Turner from comment #21)
> No problem Abhiram. Everything seems to be OK. koji scratch builds passing:
> 
> https://koji.fedoraproject.org/koji/taskinfo?taskID=26019541
> https://koji.fedoraproject.org/koji/taskinfo?taskID=26019531
> 
> I'm marking thins as accepted. You may now proceed with the
> import/build/update process, and then close this ticket once complete. Post
> a comment here if you get stuck.

I'm not able to request a repo because "The Bugzilla bug's review is approved
by a user that is not a packager".

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1532042] Review Request: compton - Compositor for X11

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1532042

James Paul Turner  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #21 from James Paul Turner  ---
No problem Abhiram. Everything seems to be OK. koji scratch builds passing:

https://koji.fedoraproject.org/koji/taskinfo?taskID=26019541
https://koji.fedoraproject.org/koji/taskinfo?taskID=26019531

I'm marking thins as accepted. You may now proceed with the import/build/update
process, and then close this ticket once complete. Post a comment here if you
get stuck.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1532042] Review Request: compton - Compositor for X11

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1532042



--- Comment #20 from Abhiram K <4kuch...@gmail.com> ---
(In reply to Jaroslav Škarvada from comment #16)
> The versioning is still wrong, see [1] and [2] for details. It should be:
> 
> Version: 0.1
> Release: 0.1.beta3%{?dist}
> 
> And you should fix Source0 tag and add '-n %{name}-%{version}_beta3' after
> the autosetup.
> 
> Of course you can use macros, e.g.:
> 
> %global ver 0.1
> %global prever beta3
> 
> Version: %{ver}
> Release: 0.1%{?prever:.%{prever}}%{?dist}
> ...
> Source0:
> https://github.com/AxelSilverdew/compton/archive/v%{version}%{?prever:
> _%{prever}}.tar.gz#/%{name}-%{version}%{?prever:_%{prever}}.tar.gz
> ...
> %autosetup -n %{name}-%{version}%{?prever:_%{prever}}
> 
> Also note the #/ part in Source0, it's to give the resulting archive proper
> name, it's described in [3].
> 
> [1] https://fedoraproject.org/wiki/Packaging:Versioning#Prerelease_versions
> [2] https://fedoraproject.org/wiki/Package_Versioning_Examples
> [3] https://fedoraproject.org/wiki/Packaging:SourceURL#Troublesome_URLs

Hey, sorry for taking so long to reply.
I made the changes that you recommended, and you can find the new links below:

SPEC URL:
https://copr-be.cloud.fedoraproject.org/results/axeld/compton/fedora-27-x86_64/00733045-compton/compton.spec
SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/axeld/compton/fedora-27-x86_64/00733045-compton/compton-0.1-0.1.beta3.fc27.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1532042] Review Request: compton - Compositor for X11

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1532042

Abhiram K <4kuch...@gmail.com> changed:

   What|Removed |Added

  Flags|needinfo?(4kuch...@gmail.co |
   |m)  |



--- Comment #19 from Abhiram K <4kuch...@gmail.com> ---
(In reply to James Paul Turner from comment #18)
> As per the procedure for stalled package reviews [1], I am marking this
> package review as stalled. Please respond as soon as possible to ensure that
> this review can be finished. You have a further week from this date to
> respond. Thanks.
> 
> [1] https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews

Hey, I was just pushing an update.
I've been caught up with work on my end.
Sorry, for taking so long.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1532042] Review Request: compton - Compositor for X11

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1532042

James Paul Turner  changed:

   What|Removed |Added

 CC||4kuch...@gmail.com
  Flags||fedora-review?
   ||needinfo?(4kuch...@gmail.co
   ||m)



--- Comment #18 from James Paul Turner  ---
As per the procedure for stalled package reviews [1], I am marking this package
review as stalled. Please respond as soon as possible to ensure that this
review can be finished. You have a further week from this date to respond.
Thanks.

[1] https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1532042] Review Request: compton - Compositor for X11

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1532042



--- Comment #17 from Mamoru TASAKA  ---
Would someone update the status of this review request?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1532042] Review Request: compton - Compositor for X11

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1532042

James Paul Turner  changed:

   What|Removed |Added

   Assignee|ignate...@redhat.com|jamesturner...@gmail.com



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1532042] Review Request: compton - Compositor for X11

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1532042

Jaroslav Škarvada  changed:

   What|Removed |Added

 CC||jskar...@redhat.com



--- Comment #16 from Jaroslav Škarvada  ---
The versioning is still wrong, see [1] and [2] for details. It should be:

Version: 0.1
Release: 0.1.beta3%{?dist}

And you should fix Source0 tag and add '-n %{name}-%{version}_beta3' after the
autosetup.

Of course you can use macros, e.g.:

%global ver 0.1
%global prever beta3

Version: %{ver}
Release: 0.1%{?prever:.%{prever}}%{?dist}
...
Source0:
https://github.com/AxelSilverdew/compton/archive/v%{version}%{?prever:_%{prever}}.tar.gz#/%{name}-%{version}%{?prever:_%{prever}}.tar.gz
...
%autosetup -n %{name}-%{version}%{?prever:_%{prever}}

Also note the #/ part in Source0, it's to give the resulting archive proper
name, it's described in [3].

[1] https://fedoraproject.org/wiki/Packaging:Versioning#Prerelease_versions
[2] https://fedoraproject.org/wiki/Package_Versioning_Examples
[3] https://fedoraproject.org/wiki/Packaging:SourceURL#Troublesome_URLs

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1532042] Review Request: compton - Compositor for X11

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1532042



--- Comment #15 from James Paul Turner  ---
(In reply to Dominik Schubert from comment #13)
> (In reply to James Paul Turner from comment #12)
> > - I am unable to install compton without libconfig. Should libconfig be a
> >   'Requires', rather than a 'BuildRequires'?
> 
> I'm not quite sure what you mean. According to your output, compton already
> requires libconfig.so.9()(64bit) which is provided by libconfig.

Yes, you're quite right. I forgot that rpm, by itself, does not resolve
dependencies. Thank you.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1532042] Review Request: compton - Compositor for X11

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1532042



--- Comment #14 from Abhiram K <4kuch...@gmail.com> ---
(In reply to James Paul Turner from comment #12)
> - Package does not use a name that already exists.
>   Note: A package with this name already exists. Please check
>   https://src.fedoraproject.org/rpms/compton

That package has been orphaned. This review request was created in order for me
to un-orphan it and continue maintaining it. :D

I will look into the other issues you have mentioned and update as necessary.
Thank you for pointing them out.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1532042] Review Request: compton - Compositor for X11

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1532042



--- Comment #13 from Dominik Schubert  ---
(In reply to James Paul Turner from comment #12)
> - I am unable to install compton without libconfig. Should libconfig be a
>   'Requires', rather than a 'BuildRequires'?

I'm not quite sure what you mean. According to your output, compton already
requires libconfig.so.9()(64bit) which is provided by libconfig.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1532042] Review Request: compton - Compositor for X11

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1532042

James Paul Turner  changed:

   What|Removed |Added

 CC||jamesturner...@gmail.com



--- Comment #12 from James Paul Turner  ---
Note: the following review is by a non-packager-group member.
It was produced with help from fedora-review.


Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated


Issues:
===

- I am unable to install compton without libconfig. Should libconfig be a
  'Requires', rather than a 'BuildRequires'?

- Package does not use a name that already exists.
  Note: A package with this name already exists. Please check
  https://src.fedoraproject.org/rpms/compton

- Changelog entries should include - to indicate which
  revision number a change applies to.

- Rpmlint warned that Changelog timestamps aren't sane (Feb 19 2018 was a
  Friday, not a Tuesday).


= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
[x]: License file installed when any subpackage combination is installed.
[x]: Package does not own files or directories owned by other packages.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.

[!]: Changelog in prescribed format.

[x]: Sources contain only permissible code or content.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).

[!]: Package is named according to the Package Naming Guidelines.

[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[x]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Package installs a %{name}.desktop using desktop-file-install or
 desktop-file-validate if there is such a file.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[-]: Fully versioned dependency in subpackages if applicable.
 Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in compton-
 debuginfo , compton-debugsource
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text 

[Bug 1532042] Review Request: compton - Compositor for X11

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1532042



--- Comment #11 from Abhiram K <4kuch...@gmail.com> ---
Thank you so much for the sponser!

I removed the scriptlets and made the changes to those two lines as you
suggested.

SPEC URL:
https://copr-be.cloud.fedoraproject.org/results/axeld/compton/fedora-27-x86_64/00712491-compton/compton.spec

SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/axeld/compton/fedora-27-x86_64/00712491-compton/compton-0.1_beta3-0.1_beta3.fc27.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1532042] Review Request: compton - Compositor for X11

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1532042

Igor Gnatenko  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|nob...@fedoraproject.org|ignate...@redhat.com



--- Comment #10 from Igor Gnatenko  ---
I will sponsor you and take this review.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1532042] Review Request: compton - Compositor for X11

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1532042



--- Comment #9 from Igor Gnatenko  ---
%post
update-desktop-database &> /dev/null || :
touch --no-create %{_datadir}/icons/hicolor &>/dev/null
gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || :

%postun
update-desktop-database &> /dev/null || :
if [ $1 -eq 0 ] ; then
touch --no-create %{_datadir}/icons/hicolor &>/dev/null
gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || :
fi


Please remove those scriptlets.

> %__make
> %__make docs
%make_build
%make_build docs

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1532042] Review Request: compton - Compositor for X11

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1532042



--- Comment #8 from Abhiram K <4kuch...@gmail.com> ---
Made the suggested changes, please find the new links down below:

SPEC URL:
https://copr-be.cloud.fedoraproject.org/results/axeld/compton/fedora-27-x86_64/00712261-compton/compton.spec

SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/axeld/compton/fedora-27-x86_64/00712261-compton/compton-0.1_beta3-0.1_beta3.fc27.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1532042] Review Request: compton - Compositor for X11

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1532042

Dominik Schubert  changed:

   What|Removed |Added

 CC||m...@dschubert.net



--- Comment #7 from Dominik Schubert  ---
First of all, thanks for taking this on. I had actually considered submitting
it myself, but felt I couldn't properly support a package where upstream is
basically dead without some insight into the code-base. So in the end I decided
to leave it in Copr and maintain that on a best-effort basis. But I'll try to
help if I can.

There used to be a compton package in the past:
https://src.fedoraproject.org/rpms/compton/blob/master/f/dead.package
I think this means you have to unretire it, there's a process for that...
(https://fedoraproject.org/wiki/Orphaned_package_that_need_new_maintainers#Claiming_Ownership_of_a_Retired_Package)

(In reply to Iwicki Artur from comment #1)
> >Release: 0
> The "Release:" tag should start at 1.
> https://fedoraproject.org/wiki/Packaging:Versioning#Simple_versioning

As I understand it, simple versioning does not apply here (0.1_beta2 would be
higher than 0.1, which is wrong). So the correct way to do this should be:
> Version: 0.1
> Release: 0.1.beta2%{?dist}
(https://fedoraproject.org/wiki/Package_Versioning_Examples has some examples
to this end)

Some other possible issues:

- the dist tag is missing
(https://fedoraproject.org/wiki/Packaging:DistTag)
- BuildRequires: gcc is now required
(https://fedoraproject.org/wiki/Packaging:C_and_C%2B%2B)
- libdrm-devel and libXfixes-devel should be explicitly listed as build
dependencies; they get pulled in by mesa-libGL-devel, but you shouldn't rely on
that
(https://fedoraproject.org/wiki/Packaging:Guidelines#Build-Time_Dependencies_.28BuildRequires.29)
- BUT, the Makefile uses pkg-config for x11, xcomposite, xfixes, xdamage,
xrender, xext, xrandr, xinerama, libconfig, libdrm and dbus-1, so
pkgconfig(x11), pkgconfig(xcomposite) and so on should be listed insted
(https://fedoraproject.org/wiki/Packaging:PkgConfigBuildRequires)
- compton-trans needs xprop or xwininfo, which are in xorg-x11-utils, so this
should be a (runtime) dependency
- hicolor-icon-theme probably shouldn't be a build dependency, it is only
needed so that there is a package owning the directory structure when it is
installed (and for running gtk-update-icon-cache, see next point).
> dnf repoquery --repo rawhide-source --whatrequires hicolor-icon-theme
does list a couple of packages that have BuildRequires: hicolor-icon-theme (and
actually lack the runtime dependency!). But I'm pretty sure those are just
bugs.
- the icon cache scriptlets are no longer needed, there have been file triggers
for those for some time now (rpm -q --filetriggers hicolor-icon-theme)
(https://fedoraproject.org/w/index.php?title=Packaging%3AScriptlets=revision=508538=500930
https://pagure.io/packaging-committee/issue/736)
- the same is true for update-desktop-database (which was actually only needed
for .desktop files containing MIME types in the first place)
- however, the .desktop file still needs to be validated
> %check
> desktop-file-validate %{buildroot}/%{_datadir}/applications/compton.desktop
This also needs BuildRequires: desktop-file-utils
(https://fedoraproject.org/wiki/Packaging:Guidelines#desktop-file-install_usage)

(In reply to Abhiram K from comment #6)
> I'm not sure if this is the right way to go about doing this, but I created
> a fork of the upstream repo to create a new release and I pointed the spec
> file to that fork.
You can always package the current master as a snapshot version
(see my Copr build for an example
https://copr-be.cloud.fedoraproject.org/results/dschubert/compton/fedora-27-x86_64/00688196-compton/compton.spec)
and add any additional changes as patch files. It's not exactly pretty, but at
least it's clear from the spec file what the changes are relative to upstream.
I think if you want to maintain a proper fork, it would be better to have a
different (package) name for it. Otherwise we will be left with a nasty mess,
if there is ever another upstream release.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1532042] Review Request: compton - Compositor for X11

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1532042



--- Comment #6 from Abhiram K <4kuch...@gmail.com> ---
(In reply to Iwicki Artur from comment #5)
> Given that there's been quite a few commits in the repository since the
> v0.1_beta2 tag (over 60, if I'm counting correctly), I think it would be
> preferable to use latest git snapshot for packaging.

I'm not sure if this is the right way to go about doing this, but I created a
fork of the upstream repo to create a new release and I pointed the spec file
to that fork.

It looks like the original creator stopped taking pull requests some time ago,
so any future updates and issue fixes should be happening on my fork.

Please find the new spec file and srpm linked below:

Spec URL:
https://copr-be.cloud.fedoraproject.org/results/axeld/compton/fedora-27-x86_64/00699864-compton/compton.spec

SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/axeld/compton/fedora-27-x86_64/00699864-compton/compton-0.1_beta3-1.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1532042] Review Request: compton - Compositor for X11

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1532042



--- Comment #5 from Iwicki Artur  ---
Given that there's been quite a few commits in the repository since the
v0.1_beta2 tag (over 60, if I'm counting correctly), I think it would be
preferable to use latest git snapshot for packaging.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1532042] Review Request: compton - Compositor for X11

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1532042



--- Comment #4 from Abhiram K <4kuch...@gmail.com> ---
(In reply to Raphael Groner from comment #3)
> v0.1_beta2: Second beta release ( 3 Nov 2013 )
> 
> Are you sure we can expect any further release or even bug fixes?
> https://github.com/chjj/compton/releases

I can't guarantee that we'll get any more updates or bug fixes from chjj
them-self. Most bugfixes seem to be coming from the community side these days.
However, I'll be trying to keep the package as up-to-date as possible regarding
any bugs and fixes.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1532042] Review Request: compton - Compositor for X11

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1532042

Raphael Groner  changed:

   What|Removed |Added

 CC||projects...@smart.ms



--- Comment #3 from Raphael Groner  ---
v0.1_beta2: Second beta release ( 3 Nov 2013 )

Are you sure we can expect any further release or even bug fixes?
https://github.com/chjj/compton/releases

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1532042] Review Request: compton - Compositor for X11

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1532042



--- Comment #2 from Abhiram K <4kuch...@gmail.com> ---
Made the necessary changes, please find the new links below:

Spec URL:
https://copr-be.cloud.fedoraproject.org/results/axeld/compton/fedora-27-x86_64/00697980-compton/compton.spec

SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/axeld/compton/fedora-27-x86_64/00697980-compton/compton-0.1_beta2-1.src.rpm

Please let me know if there are any further changes to be made.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1532042] Review Request: compton - Compositor for X11

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1532042

Iwicki Artur  changed:

   What|Removed |Added

 CC||fed...@svgames.pl



--- Comment #1 from Iwicki Artur  ---
>Release: 0
The "Release:" tag should start at 1.
https://fedoraproject.org/wiki/Packaging:Versioning#Simple_versioning

>Group: System/X11/Utilities
The "Group:" tag is not used in Fedora.
>BuildRoot: %{_tmppath}/%{name}-%{version}-build
The "BuildRoot:" tag should not be used in Fedora.
https://fedoraproject.org/wiki/Packaging:Guidelines#Tags_and_Sections

>Source0: https://github.com/chjj/compton/archive/v0.1_beta2.tar.gz
You can use the %{version} macro inside the URL so you don't have to edit it
when a new version comes out.

>%__make
>make DESTDIR=%{buildroot} install
Why the mix of macro and "raw" make calls?

>%doc README.md LICENSE
The LICENSE file should be marked as %license, not %doc.

>%{_mandir}/man1/compton.1.gz
>%{_mandir}/man1/compton-trans.1.gz
You should not assume gzip compression will be used for manpages. Instead, use
a wildcard that can match both compressed and non-compressed files.
https://fedoraproject.org/wiki/Packaging:Guidelines#Manpages

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1532042] Review Request: compton - Compositor for X11

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1532042

Abhiram K <4kuch...@gmail.com> changed:

   What|Removed |Added

 Blocks||177841 (FE-NEEDSPONSOR)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1532042] Review Request: compton - Compositor for X11

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1532042

Igor Gnatenko  changed:

   What|Removed |Added

Summary|Review Request:  - |Review Request: compton -
   ||Compositor for X11



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org