[Bug 1534446] Review Request: timeshift - System restore tool for Linux

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1534446



--- Comment #29 from Fedora Update System  ---
timeshift-18.1.1-4.el7 has been pushed to the Fedora EPEL 7 stable repository.
If problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1534446] Review Request: timeshift - System restore tool for Linux

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1534446



--- Comment #28 from Fedora Update System  ---
timeshift-18.1.1-4.fc27 has been pushed to the Fedora 27 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1534446] Review Request: timeshift - System restore tool for Linux

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1534446

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2018-02-06 05:49:44



--- Comment #27 from Fedora Update System  ---
timeshift-18.1.1-4.fc26 has been pushed to the Fedora 26 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1534446] Review Request: timeshift - System restore tool for Linux

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1534446



--- Comment #26 from Fedora Update System  ---
timeshift-18.1.1-4.fc26 has been pushed to the Fedora 26 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2018-f67cb13026

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1534446] Review Request: timeshift - System restore tool for Linux

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1534446



--- Comment #25 from Fedora Update System  ---
timeshift-18.1.1-4.fc27 has been pushed to the Fedora 27 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2018-132058f52d

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1534446] Review Request: timeshift - System restore tool for Linux

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1534446



--- Comment #24 from Fedora Update System  ---
timeshift-18.1.1-4.el7 has been pushed to the Fedora EPEL 7 testing repository.
If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2018-2034535a48

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1534446] Review Request: timeshift - System restore tool for Linux

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1534446



--- Comment #23 from Fedora Update System  ---
timeshift-18.1.1-2.fc27 has been pushed to the Fedora 27 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2018-e8ccaa9e31

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1534446] Review Request: timeshift - System restore tool for Linux

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1534446



--- Comment #22 from Fedora Update System  ---
timeshift-18.1.1-2.fc26 has been pushed to the Fedora 26 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2018-d465f39a50

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1534446] Review Request: timeshift - System restore tool for Linux

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1534446

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #21 from Fedora Update System  ---
timeshift-18.1.1-2.el7 has been pushed to the Fedora EPEL 7 testing repository.
If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2018-c4a955e60b

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1534446] Review Request: timeshift - System restore tool for Linux

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1534446



--- Comment #20 from Fedora Update System  ---
timeshift-18.1.1-4.el7 has been submitted as an update to Fedora EPEL 7.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2018-2034535a48

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1534446] Review Request: timeshift - System restore tool for Linux

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1534446



--- Comment #19 from Fedora Update System  ---
timeshift-18.1.1-4.fc26 has been submitted as an update to Fedora 26.
https://bodhi.fedoraproject.org/updates/FEDORA-2018-f67cb13026

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1534446] Review Request: timeshift - System restore tool for Linux

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1534446



--- Comment #18 from Fedora Update System  ---
timeshift-18.1.1-4.fc27 has been submitted as an update to Fedora 27.
https://bodhi.fedoraproject.org/updates/FEDORA-2018-132058f52d

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1534446] Review Request: timeshift - System restore tool for Linux

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1534446

Björn 'besser82' Esser  changed:

   What|Removed |Added

 CC||besse...@fedoraproject.org



--- Comment #17 from Björn 'besser82' Esser  ---
This package does not follow the packaging guidelines, as it does NOT apply the
systems LDFLAGS properly!  I've fixed that in dist-git [1] and triggered a
rebuild for all distros.


[1]  https://src.fedoraproject.org/rpms/timeshift/c/483bd66

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1534446] Review Request: timeshift - System restore tool for Linux

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1534446



--- Comment #16 from Fedora Update System  ---
timeshift-18.1.1-2.el7 has been submitted as an update to Fedora EPEL 7.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2018-c4a955e60b

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1534446] Review Request: timeshift - System restore tool for Linux

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1534446



--- Comment #15 from Fedora Update System  ---
timeshift-18.1.1-2.fc26 has been submitted as an update to Fedora 26.
https://bodhi.fedoraproject.org/updates/FEDORA-2018-d465f39a50

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1534446] Review Request: timeshift - System restore tool for Linux

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1534446



--- Comment #14 from Fedora Update System  ---
timeshift-18.1.1-2.fc27 has been submitted as an update to Fedora 27.
https://bodhi.fedoraproject.org/updates/FEDORA-2018-e8ccaa9e31

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1534446] Review Request: timeshift - System restore tool for Linux

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1534446

Fedora Update System  changed:

   What|Removed |Added

 Status|POST|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1534446] Review Request: timeshift - System restore tool for Linux

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1534446



--- Comment #13 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/timeshift

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1534446] Review Request: timeshift - System restore tool for Linux

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1534446

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|NEW |POST
   Assignee|nob...@fedoraproject.org|zebo...@gmail.com
  Flags||fedora-review+



--- Comment #12 from Robert-André Mauchin  ---
Package is approved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1534446] Review Request: timeshift - System restore tool for Linux

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1534446



--- Comment #11 from srakitnican  ---
Spec URL:
https://copr-be.cloud.fedoraproject.org/results/srakitnican/default/fedora-rawhide-x86_64/00705772-timeshift/timeshift.spec
SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/srakitnican/default/fedora-rawhide-x86_64/00705772-timeshift/timeshift-18.1.1-2.fc28.src.rpm

timeshift-18.1.1-2

* Patched location of AppData file
* Added validation for AppData file
* Updated description

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1534446] Review Request: timeshift - System restore tool for Linux

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1534446



--- Comment #10 from Robert-André Mauchin  ---
>_is this implemented anywhere yet, or there are still some places where it is 
>expected to be in /usr/share/appdata.

I don't know to be honest.

The guidelines always reflect what should be done for Rawhide, not previous
release.

You could move the file in install to but it in the right location. You could
also notify upstream that %{_datadir}/appdata is a legacy location as explained
by https://freedesktop.org/software/appstream/docs/chap-Metadata.html

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1534446] Review Request: timeshift - System restore tool for Linux

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1534446



--- Comment #9 from srakitnican  ---
After looking more carefully it was indeed changed [1]. Since upstream is
installing this file, I am wondering how this should be approached. Should I
suggest upstream to change it e.g. is this implemented anywhere yet, or there
are still some places where it is expected to be in /usr/share/appdata.

[1]
https://fedoraproject.org/w/index.php?title=Packaging%3AAppData=revision=501456=486600

The last comment from the following issue implies that it doesn't work on
previous Fedora releases. Nothing mentioned in the Guidelines about that.
https://pagure.io/packaging-committee/issue/704#comment-486000

Any suggestions welcome.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1534446] Review Request: timeshift - System restore tool for Linux

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1534446



--- Comment #8 from srakitnican  ---
Hmm, metainfo is for add-on packages or "components". It should not be present
ordinarily if application does not provide one. Appdata is used to describe the
application itself. Or am I missing something.

I will add validation for the appdata, forgot to do that.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1534446] Review Request: timeshift - System restore tool for Linux

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1534446



--- Comment #7 from Robert-André Mauchin  ---
 - I missed something:

%{_datadir}/appdata/*.appdata.xml

   New guidelines say Appdata files must be installed in %{_datadir}/metainfo/
See https://fedoraproject.org/wiki/Packaging:AppData

Also the appdata file must be validated with appstream-util. See
https://fedoraproject.org/wiki/Packaging:AppData#app-data-validate_usage

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1534446] Review Request: timeshift - System restore tool for Linux

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1534446



--- Comment #6 from srakitnican  ---
Spec URL:
https://copr-be.cloud.fedoraproject.org/results/srakitnican/default/fedora-rawhide-x86_64/00705513-timeshift/timeshift.spec
SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/srakitnican/default/fedora-rawhide-x86_64/00705513-timeshift/timeshift-18.1.1-1.fc28.src.rpm

Updated from timeshift-18.1-1 to timeshift-18.1.1-1

* Added runtime dependencies for cron, icons and polkit
* Changed license to GPLv3+ or LGPLv3+
* Removed brackets around make_build and make_install
* Use %autosetup instead of %setup

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1534446] Review Request: timeshift - System restore tool for Linux

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1534446



--- Comment #5 from Robert-André Mauchin  ---
>or
> * (at your option) any later version

Timeshift author choose the later version.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1534446] Review Request: timeshift - System restore tool for Linux

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1534446



--- Comment #4 from srakitnican  ---
(In reply to Robert-André Mauchin from comment #3)
> (In reply to srakitnican from comment #2)
> > 
> > I am confused about that one, I've added this file because it is the only
> > text that describes the actual license used (GPLv2+). COPYING and LICENSE.md
> > contains license text for GPLv3 and LGPLv3 respectively. I am not an expert,
> > but I think there is quiet a difference between the two, and I would say
> > there is at least some difference between GPLv2 and GPLv3.
> 
> Nothing indicates that this app is GPLv2+. License: should be GPLv3+ or
> LGPLv3+ and you should include both  COPYING and LICENSE.md in %license.

Well, *.vala files contains header that specifies that is GPLv2+. no?

For example:

/*
 * DeleteWindow.vala
 *
 * Copyright 2012-17 Tony George 
 *
 * This program is free software; you can redistribute it and/or modify
 * it under the terms of the GNU General Public License as published by
 * the Free Software Foundation; either version 2 of the License, or
 * (at your option) any later version.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 * GNU General Public License for more details.
 *
 * You should have received a copy of the GNU General Public License
 * along with this program; if not, write to the Free Software
 * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston,
 * MA 02110-1301, USA.
 *
 *
 */

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1534446] Review Request: timeshift - System restore tool for Linux

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1534446



--- Comment #3 from Robert-André Mauchin  ---
(In reply to srakitnican from comment #2)
> 
> I am confused about that one, I've added this file because it is the only
> text that describes the actual license used (GPLv2+). COPYING and LICENSE.md
> contains license text for GPLv3 and LGPLv3 respectively. I am not an expert,
> but I think there is quiet a difference between the two, and I would say
> there is at least some difference between GPLv2 and GPLv3.

Nothing indicates that this app is GPLv2+. License: should be GPLv3+ or LGPLv3+
and you should include both  COPYING and LICENSE.md in %license.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1534446] Review Request: timeshift - System restore tool for Linux

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1534446



--- Comment #2 from srakitnican  ---
Thank you for your review!

(In reply to Robert-André Mauchin from comment #1)
>  - I don't think it's necessary to add Debian packaging files, remove
> %license debian/copyright

I am confused about that one, I've added this file because it is the only text
that describes the actual license used (GPLv2+). COPYING and LICENSE.md
contains license text for GPLv3 and LGPLv3 respectively. I am not an expert,
but I think there is quiet a difference between the two, and I would say there
is at least some difference between GPLv2 and GPLv3.

>  - Add a "Requires:   hicolor-icon-theme" to own the icons directories
> 
>  - Add a "Requires:   polkit" to own /usr/share/polkit-1 and 
> /usr/share/polkit-1/actions
> 
>  - Add a "Requires:   cronie" to own /etc/cron.d
> 
>  - Add "%config(noreplace)" for this file unless you don't expect it to be
> modified by the user:
> 
> timeshift.x86_64: W: conffile-without-noreplace-flag
> /etc/default/timeshift.json

I don't think this file is supposed to be modified by user since the program
creates and maintaines /etc/timeshift.json.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1534446] Review Request: timeshift - System restore tool for Linux

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1534446

Robert-André Mauchin  changed:

   What|Removed |Added

 CC||zebo...@gmail.com



--- Comment #1 from Robert-André Mauchin  ---
 - I don't think it's necessary to add Debian packaging files, remove %license
debian/copyright

 - Add a "Requires:   hicolor-icon-theme" to own the icons directories

 - Add a "Requires:   polkit" to own /usr/share/polkit-1 and 
/usr/share/polkit-1/actions

 - Add a "Requires:   cronie" to own /etc/cron.d

 - Add "%config(noreplace)" for this file unless you don't expect it to be
modified by the user:

timeshift.x86_64: W: conffile-without-noreplace-flag
/etc/default/timeshift.json


Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "GPL (v2 or later)", "GPL (v3 or later)", "Unknown or
 generated". 138 files have unknown license. Detailed output of
 licensecheck in /home/bob/packaging/review/timeshift/review-
 timeshift/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[!]: Package must own all directories that it creates.
 Note: Directories without known owners: /usr/share/polkit-1,
 /etc/cron.d, /usr/share/polkit-1/actions
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: %config files are marked noreplace or the reason is justified.
 Note: No (noreplace) in %config /etc/default/timeshift.json
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: The spec file handles locales properly.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 20480 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Package installs a %{name}.desktop using desktop-file-install or
 desktop-file-validate if there is such a file.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: No %config files under /usr.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager