[Bug 1550740] Review request: webextension-token-signing - Firefox extension for signing with your eID on the web

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1550740



--- Comment #23 from Fedora Update System  ---
webextension-token-signing-1.0.6-4.fc28 has been pushed to the Fedora 28 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1550740] Review request: webextension-token-signing - Firefox extension for signing with your eID on the web

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1550740

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2018-03-22 12:59:57



--- Comment #22 from Fedora Update System  ---
webextension-token-signing-1.0.6-4.fc27 has been pushed to the Fedora 27 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1550740] Review request: webextension-token-signing - Firefox extension for signing with your eID on the web

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1550740



--- Comment #21 from Fedora Update System  ---
webextension-token-signing-1.0.6-4.fc27 has been pushed to the Fedora 27
testing repository. If problems still persist, please make note of it in this
bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2018-6dcee533d9

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1550740] Review request: webextension-token-signing - Firefox extension for signing with your eID on the web

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1550740

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #20 from Fedora Update System  ---
webextension-token-signing-1.0.6-4.fc28 has been pushed to the Fedora 28
testing repository. If problems still persist, please make note of it in this
bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2018-1608d21400

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1550740] Review request: webextension-token-signing - Firefox extension for signing with your eID on the web

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1550740



--- Comment #19 from Fedora Update System  ---
webextension-token-signing-1.0.6-4.fc28 has been submitted as an update to
Fedora 28. https://bodhi.fedoraproject.org/updates/FEDORA-2018-1608d21400

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1550740] Review request: webextension-token-signing - Firefox extension for signing with your eID on the web

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1550740
Bug 1550740 depends on bug 1552371, which changed state.

Bug 1552371 Summary: Implement -DCMAKE_INSTALL_LIBDIR:PATH=%{_libdir}  qmake 
equivalent
https://bugzilla.redhat.com/show_bug.cgi?id=1552371

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution|--- |ERRATA



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1550740] Review request: webextension-token-signing - Firefox extension for signing with your eID on the web

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1550740

Fedora Update System  changed:

   What|Removed |Added

 Status|POST|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1550740] Review request: webextension-token-signing - Firefox extension for signing with your eID on the web

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1550740



--- Comment #18 from Fedora Update System  ---
webextension-token-signing-1.0.6-4.fc27 has been submitted as an update to
Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2018-6dcee533d9

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1550740] Review request: webextension-token-signing - Firefox extension for signing with your eID on the web

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1550740



--- Comment #17 from Germano Massullo  ---
Some new infos

https://lists.fedoraproject.org/archives/list/de...@lists.fedoraproject.org/message/APKC62MK7GDMDSGIQ6LITVHH2IULK7KZ/

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1550740] Review request: webextension-token-signing - Firefox extension for signing with your eID on the web

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1550740



--- Comment #16 from Germano Massullo  ---
Proof that the package needs the QMAKE equivalent of cmake flag
-DCMAKE_INSTALL_LIBDIR:PATH=%{_libdir}
https://github.com/open-eid/chrome-token-signing/issues/80#issuecomment-372034703

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1550740] Review request: webextension-token-signing - Firefox extension for signing with your eID on the web

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1550740



--- Comment #15 from Germano Massullo  ---
Because on 64bit systems the package tries to install files under
/usr/lib/...
instead of
/usr/lib64/...
This can happen only for noarch packages, and this is not a noarch package.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1550740] Review request: webextension-token-signing - Firefox extension for signing with your eID on the web

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1550740



--- Comment #14 from Robert-André Mauchin  ---
(In reply to Germano Massullo from comment #13)
> I need to add the QMAKE equivalent of cmake flag
> -DCMAKE_INSTALL_LIBDIR:PATH=%{_libdir}

Why? This is not needed at all.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1550740] Review request: webextension-token-signing - Firefox extension for signing with your eID on the web

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1550740

Germano Massullo  changed:

   What|Removed |Added

 Depends On||1552371




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1552371
[Bug 1552371] Implement -DCMAKE_INSTALL_LIBDIR:PATH=%{_libdir}  qmake
equivalent
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1550740] Review request: webextension-token-signing - Firefox extension for signing with your eID on the web

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1550740



--- Comment #13 from Germano Massullo  ---
I need to add the QMAKE equivalent of cmake flag
-DCMAKE_INSTALL_LIBDIR:PATH=%{_libdir}

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1550740] Review request: webextension-token-signing - Firefox extension for signing with your eID on the web

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1550740



--- Comment #12 from Germano Massullo  ---
My fault, I replaced %_prefix/lib/ with %{_libdir}

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1550740] Review request: webextension-token-signing - Firefox extension for signing with your eID on the web

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1550740

Robert-André Mauchin  changed:

   What|Removed |Added

  Flags|needinfo?(zebo...@gmail.com |
   |)   |



--- Comment #11 from Robert-André Mauchin  ---
Here's my fixed SPEC:


# original upstream name: chrome-token-signing
# it is a native messaging solution for firefox/chrome signing support
# chrome and firefox dropped legacy npapi support form browsers
# https://developer.chrome.com/apps/nativeMessaging
# and Estonia ID card software now use native messaging to talk with smartcards
# over javascript to create digital signatures.
# Information source user zomps from #esteid Freenode IRC channel
%global upstream_name chrome-token-signing

Name:webextension-token-signing
Version:1.0.6
Release:1%{?dist}
Summary:Firefox extension for signing with your eID on the web
License:LGPLv2+
URL:https://github.com/open-eid/chrome-token-signing
Source0:   
%{url}/archive/v%{version}.tar.gz#/%{upstream_name}-%{version}.tar.gz


BuildRequires:  qt5-qtbase-devel
BuildRequires:  pkgconfig(openssl)
BuildRequires:  pkgconfig(libpcsclite)
Requires:   esteidcerts
Requires:   opensc%{?_isa}
Requires:   pcsc-lite%{?_isa}
Requires:   pcsc-lite-ccid%{?_isa}
# mozilla-filesystem is required to install files into
# %%_prefix/lib/mozilla and
# %%{_datadir}/mozilla/extensions/
Requires:   mozilla-filesystem

%description
Firefox extension for signing with your eID on the web 


%prep
%setup -q -n %{upstream_name}-%{version}

sed -i "s|qmake|%{_qt5_bindir}/qmake \
  QMAKE_CFLAGS_DEBUG=\"%optflags\" \
  QMAKE_CFLAGS_RELEASE=\"%optflags\" \
  QMAKE_CXXFLAGS_DEBUG=\"%optflags\" \
  QMAKE_CXXFLAGS_RELEASE=\"%optflags\" \
  QMAKE_LFLAGS_DEBUG=\"%{?__global_ldflags}\" \
  QMAKE_LFLAGS_RELEASE=\"%{?__global_ldflags}\" \
  QMAKE_STRIP=|" host-linux/GNUmakefile

%build
make %{?_smp_mflags}

%install
# make -C host-linux install DESTDIR=%%{buildroot}
make -C host-linux install INSTALL_ROOT=%{buildroot}

# Firefox is the browser installed by default on Fedora
# Chrome is not available in Fedora repository, so
# the following Chrome files will be removed

rm -f
$RPM_BUILD_ROOT/opt/google/chrome/extensions/ckjefchnfjhjfedoccjbhjpbncimppeg.json
rm -f
$RPM_BUILD_ROOT/etc/opt/google/chrome/native-messaging-hosts/ee.ria.esteid.json
rm -f
$RPM_BUILD_ROOT/opt/chrome/extensions/ckjefchnfjhjfedoccjbhjpbncimppeg.json
rm -f $RPM_BUILD_ROOT/etc/opt/chrome/native-messaging-hosts/ee.ria.esteid.json


%files
%{_bindir}/chrome-token-signing
# %%{_datadir} is a macro for /usr/share
%{_datadir}/mozilla/extensions/*
# %% dir creates a directory under a specific path
%dir %_prefix/lib/mozilla/native-messaging-hosts/
# %%_prefix is a macro for /usr directory
%_prefix/lib/mozilla/native-messaging-hosts/ee.ria.esteid.json


%doc README.md AUTHORS RELEASE-NOTES.md

%license LICENSE.LGPL

%changelog
* Thu Feb 22 2018 Germano Massullo  - 1.0.6-1
- first release




It builds in Koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=25522841

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1550740] Review request: webextension-token-signing - Firefox extension for signing with your eID on the web

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1550740

Germano Massullo  changed:

   What|Removed |Added

  Flags||needinfo?(zebo...@gmail.com
   ||)



--- Comment #10 from Germano Massullo  ---
Build failed
https://koji.fedoraproject.org/koji/taskinfo?taskID=25522720

(In reply to Robert-André Mauchin from comment #9)
> My bad, I used hardcoded flags. Replace the sed line with:
> 
> sed -i "s|qmake|/usr/lib64/qt5/bin/qmake \
>   QMAKE_CFLAGS_DEBUG=\"%optflags\" \
>   QMAKE_CFLAGS_RELEASE=\"%optflags\" \
>   QMAKE_CXXFLAGS_DEBUG=\"%optflags\" \
>   QMAKE_CXXFLAGS_RELEASE=\"%optflags\" \
>   QMAKE_LFLAGS_DEBUG=\"%{?__global_ldflags}\" \
>   QMAKE_LFLAGS_RELEASE=\"%{?__global_ldflags}\" \
>   QMAKE_STRIP=|" host-linux/GNUmakefile

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1550740] Review request: webextension-token-signing - Firefox extension for signing with your eID on the web

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1550740

Robert-André Mauchin  changed:

   What|Removed |Added

  Flags|needinfo?(zebo...@gmail.com |
   |)   |



--- Comment #9 from Robert-André Mauchin  ---
My bad, I used hardcoded flags. Replace the sed line with:

sed -i "s|qmake|/usr/lib64/qt5/bin/qmake \
  QMAKE_CFLAGS_DEBUG=\"%optflags\" \
  QMAKE_CFLAGS_RELEASE=\"%optflags\" \
  QMAKE_CXXFLAGS_DEBUG=\"%optflags\" \
  QMAKE_CXXFLAGS_RELEASE=\"%optflags\" \
  QMAKE_LFLAGS_DEBUG=\"%{?__global_ldflags}\" \
  QMAKE_LFLAGS_RELEASE=\"%{?__global_ldflags}\" \
  QMAKE_STRIP=|" host-linux/GNUmakefile

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1550740] Review request: webextension-token-signing - Firefox extension for signing with your eID on the web

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1550740

Germano Massullo  changed:

   What|Removed |Added

  Flags||needinfo?(zebo...@gmail.com
   ||)



--- Comment #8 from Germano Massullo  ---
Hi Robert-André, it looks like we have some problems on non x86_64
architectures
https://koji.fedoraproject.org/koji/taskinfo?taskID=25424160

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1550740] Review request: webextension-token-signing - Firefox extension for signing with your eID on the web

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1550740



--- Comment #7 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/webextension-token-signing

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1550740] Review request: webextension-token-signing - Firefox extension for signing with your eID on the web

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1550740

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|NEW |POST
   Assignee|nob...@fedoraproject.org|zebo...@gmail.com
  Flags||fedora-review+



--- Comment #6 from Robert-André Mauchin  ---
Package approved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1550740] Review request: webextension-token-signing - Firefox extension for signing with your eID on the web

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1550740



--- Comment #5 from Germano Massullo  ---
IMHO if there is not anything else to correct, we could proceed

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1550740] Review request: webextension-token-signing - Firefox extension for signing with your eID on the web

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1550740



--- Comment #4 from Germano Massullo  ---
Okay thank you

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1550740] Review request: webextension-token-signing - Firefox extension for signing with your eID on the web

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1550740



--- Comment #3 from Robert-André Mauchin  ---
(In reply to Germano Massullo from comment #2)
> https://germano.fedorapeople.org/package_reviews/webextension-token-signing/
> webextension-token-signing.spec
> 
> https://germano.fedorapeople.org/package_reviews/webextension-token-signing/
> webextension-token-signing-1.0.6-1.fc27.src.rpm
> 
> 
> Done everything
> 
> (In reply to Robert-André Mauchin from comment #1)
> > [...]
> > %build
> > make %{?_smp_mflags}
> 
> in the spec file I have
> 
> %build
> export PATH=$PATH:%{_qt5_bindir}
> make %{?_smp_mflags}
> 
> should I remove also line
> export PATH=$PATH:%{_qt5_bindir}
> ?

Not needed since we're linking to the bin directly.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1550740] Review request: webextension-token-signing - Firefox extension for signing with your eID on the web

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1550740



--- Comment #2 from Germano Massullo  ---
https://germano.fedorapeople.org/package_reviews/webextension-token-signing/webextension-token-signing.spec

https://germano.fedorapeople.org/package_reviews/webextension-token-signing/webextension-token-signing-1.0.6-1.fc27.src.rpm


Done everything

(In reply to Robert-André Mauchin from comment #1)
> [...]
> %build
> make %{?_smp_mflags}

in the spec file I have

%build
export PATH=$PATH:%{_qt5_bindir}
make %{?_smp_mflags}

should I remove also line
export PATH=$PATH:%{_qt5_bindir}
?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1550740] Review request: webextension-token-signing - Firefox extension for signing with your eID on the web

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1550740

Robert-André Mauchin  changed:

   What|Removed |Added

 CC||zebo...@gmail.com



--- Comment #1 from Robert-André Mauchin  ---
 - Don't do that:

# following line solves errors on debugsources
%global debug_package %{nil}


  Instead make sure qmake use Fedora build flags:

%prep
%setup -q -n %{upstream_name}-%{version}

sed -i "s|qmake|/usr/lib64/qt5/bin/qmake \
  QMAKE_CFLAGS_DEBUG=\"${CFLAGS:--O2 -g -pipe -Wall -Werror=format-security
-Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -fexceptions
-fstack-protector-strong -grecord-gcc-switches
-specs=/usr/lib/rpm/redhat/redhat-hardened-cc1
-specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -m64 -mtune=generic
-fasynchronous-unwind-tables -fstack-clash-protection -mcet -fcf-protection }\"
\
  QMAKE_CFLAGS_RELEASE=\"${CFLAGS:--O2 -g -pipe -Wall -Werror=format-security
-Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -fexceptions
-fstack-protector-strong -grecord-gcc-switches
-specs=/usr/lib/rpm/redhat/redhat-hardened-cc1
-specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -m64 -mtune=generic
-fasynchronous-unwind-tables -fstack-clash-protection -mcet -fcf-protection }\"
\
  QMAKE_CXXFLAGS_DEBUG=\"${CXXFLAGS:--O2 -g -pipe -Wall -Werror=format-security
-Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -fexceptions
-fstack-protector-strong -grecord-gcc-switches
-specs=/usr/lib/rpm/redhat/redhat-hardened-cc1
-specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -m64 -mtune=generic
-fasynchronous-unwind-tables -fstack-clash-protection -mcet -fcf-protection }\"
\
  QMAKE_CXXFLAGS_RELEASE=\"${CXXFLAGS:--O2 -g -pipe -Wall
-Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS
-fexceptions -fstack-protector-strong -grecord-gcc-switches
-specs=/usr/lib/rpm/redhat/redhat-hardened-cc1
-specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -m64 -mtune=generic
-fasynchronous-unwind-tables -fstack-clash-protection -mcet -fcf-protection }\"
\
  QMAKE_LFLAGS_DEBUG=\"${LDFLAGS:--Wl,-z,relro 
-specs=/usr/lib/rpm/redhat/redhat-hardened-ld}\" \
  QMAKE_LFLAGS_RELEASE=\"${LDFLAGS:--Wl,-z,relro 
-specs=/usr/lib/rpm/redhat/redhat-hardened-ld}\" \
  QMAKE_STRIP=|" host-linux/GNUmakefile

%build
make %{?_smp_mflags}

 - mixed-use-of-spaces-and-tabs (spaces: line 19, tab: line 10)

Either use tabs or spacs, but not both.

 - Use either %{buildroot} or $RPM_BUILD_ROOT, not both.




Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
===
- Package uses either %{buildroot} or $RPM_BUILD_ROOT
  Note: Using both %{buildroot} and $RPM_BUILD_ROOT
  See: http://fedoraproject.org/wiki/Packaging/Guidelines#macros


= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "LGPL (v2.1 or later)", "Unknown or generated", "*No copyright*
 LGPL (v2.1 or later)". 47 files have unknown license. Detailed output
 of licensecheck in /home/bob/packaging/review/webextension-token-
 signing/review-webextension-token-signing/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package does not own files or directories owned by other packages.
 Note: Dirs in package are owned also by:
 /usr/share/mozilla/extensions/{ec8030f7-c20a-464f-9b0e-13a3a9e97384
 }(firefox-nightly, firefox)
[!]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: 

[Bug 1550740] Review request: webextension-token-signing - Firefox extension for signing with your eID on the web

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1550740

Germano Massullo  changed:

   What|Removed |Added

 Blocks||1550743




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1550743
[Bug 1550743] Review request: open-eid - Meta-package for Estonian
Electronic Identity Software
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org