[Bug 1551402] Review Request: falkon - Modern web browser

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1551402



--- Comment #19 from Kevin Kofler  ---
I filed updates with QupZilla 2.2.6:
F27: https://bodhi.fedoraproject.org/updates/FEDORA-2018-46b0560ccc
F26: https://bodhi.fedoraproject.org/updates/FEDORA-2018-f9e35683fa
Functionality-wise, they should be more or less equivalent to Falkon 3.0.0.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1551402] Review Request: falkon - Modern web browser

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1551402



--- Comment #18 from Kevin Kofler  ---
Maybe with 3.0.1, when the configuration migration will be in place. For 3.0.0,
no, because it does not migrate configuration from QupZilla.

What I want to do is to push QupZilla 2.2.6, the final release of QupZilla,
which has the features from Falkon 3.0.0 backported.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1551402] Review Request: falkon - Modern web browser

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1551402

Luke  changed:

   What|Removed |Added

 CC||lu...@wp.pl



--- Comment #17 from Luke  ---
Is there a chance to package Falkon for Fedora 27 as well?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1551402] Review Request: falkon - Modern web browser

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1551402

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2018-03-30 09:20:45



--- Comment #16 from Fedora Update System  ---
falkon-3.0.0-3.fc28 has been pushed to the Fedora 28 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1551402] Review Request: falkon - Modern web browser

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1551402

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #15 from Fedora Update System  ---
falkon-3.0.0-3.fc28 has been pushed to the Fedora 28 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2018-53e38ed770

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1551402] Review Request: falkon - Modern web browser

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1551402

Fedora Update System  changed:

   What|Removed |Added

 Status|NEW |MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1551402] Review Request: falkon - Modern web browser

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1551402



--- Comment #14 from Fedora Update System  ---
falkon-3.0.0-3.fc28 has been submitted as an update to Fedora 28.
https://bodhi.fedoraproject.org/updates/FEDORA-2018-53e38ed770

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1551402] Review Request: falkon - Modern web browser

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1551402



--- Comment #13 from Kevin Kofler  ---
> ! Ownership of icon file directories is not known ambiguous due to lack of
> "Requires: hicolor-icon-theme".

Fixed:

* Sun Mar 25 2018 Kevin Kofler  - 3.0.0-3
- add Requires: hicolor-icon-theme for directory ownership
- add obsolete_qupzilla flag to Obsolete/Provide qupzilla, enable it on F28+

https://src.fedoraproject.org/cgit/rpms/falkon.git/commit/?id=7f6f0bc5acfbecdbcdd444b389a668c5f432b2c7

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1551402] Review Request: falkon - Modern web browser

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1551402



--- Comment #12 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/falkon

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1551402] Review Request: falkon - Modern web browser

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1551402



--- Comment #11 from Kevin Kofler  ---
I always add that "Requires: hicolor-icon-theme" when I package a GUI app from
scratch, it's missing here because this is based on the old qupzilla.spec, I
will fix that.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1551402] Review Request: falkon - Modern web browser

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1551402

Neal Gompa  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #10 from Neal Gompa  ---
Review notes:

+ Package builds and installs successfully
+ Package follows guidelines on naming
+ Licensing is appropriately marked and license files are correctly installed
+ Macros are correctly and consistently used
+ Patches are well documented
+ Handling of desktop files and AppStream data is per guidelines

! Ownership of icon file directories is not known ambiguous due to lack of
"Requires: hicolor-icon-theme".

However, the one issue is minor, and historically we've not directly mandated
it.

I'd appreciate if the Requires was added on import, but I'm not going to block
this review any further.

PACKAGE APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1551402] Review Request: falkon - Modern web browser

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1551402



--- Comment #9 from Neal Gompa  ---
Apologies, I had issues trying to get it to build locally. I managed to do this
now, so I'm working on the review as we speak.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1551402] Review Request: falkon - Modern web browser

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1551402

Neal Gompa  changed:

   What|Removed |Added

  Flags|needinfo?(ngomp...@gmail.co |
   |m)  |



--- Comment #8 from Neal Gompa  ---
Apologizes, I had issues trying to get it to build locally. I managed to do
this now, so I'm working on the review as we speak.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1551402] Review Request: falkon - Modern web browser

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1551402

Kevin Kofler  changed:

   What|Removed |Added

  Flags||needinfo?(ngomp...@gmail.co
   ||m)



--- Comment #7 from Kevin Kofler  ---
Ping? Can we move forward with this?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1551402] Review Request: falkon - Modern web browser

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1551402



--- Comment #6 from Kevin Kofler  ---
Successful scratch build:
https://koji.fedoraproject.org/koji/taskinfo?taskID=25501009

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1551402] Review Request: falkon - Modern web browser

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1551402



--- Comment #5 from Kevin Kofler  ---
Fixed these:

Spec URL: https://repo.calcforge.org/fedora-review/falkon.spec
SRPM URL: https://repo.calcforge.org/fedora-review/falkon-3.0.0-2.fc29.src.rpm

* Mon Mar 05 2018 Kevin Kofler  - 3.0.0-2
- don't use braces for the cmake_kf5 command macro
- remove obsolete scriptlets, add ldconfig_scriptlets transitional macro for
now

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1551402] Review Request: falkon - Modern web browser

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1551402



--- Comment #4 from Neal Gompa  ---
Initial spec review notes:

> %{cmake_kf5} ..

We don't typically do braces around command macros. It doesn't hurt it in this
case (since it's not parameterized), but in the future, avoid this, as command
macros may be parameterized and this wouldn't work as intended

> %post
> /sbin/ldconfig
> touch --no-create %{_datadir}/icons/hicolor &>/dev/null || :
>
> %postun
> /sbin/ldconfig
> if [ $1 -eq 0 ] ; then
> touch --no-create %{_datadir}/icons/hicolor &>/dev/null
> gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || :
> fi
>
> %posttrans
> gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || :

Drop all the scriptlets here and replace with %ldconfig_scriptlets.

The icon cache scriptlets has been replaced with a file trigger since Fedora
26, and the ldconfig execution should be using %ldconfig_scriptlets as it
should be a no-op on F28+ and will work properly for 

[Bug 1551402] Review Request: falkon - Modern web browser

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1551402



--- Comment #3 from Neal Gompa  ---
Taking this review.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1551402] Review Request: falkon - Modern web browser

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1551402

Neal Gompa  changed:

   What|Removed |Added

 CC||ngomp...@gmail.com
   Assignee|nob...@fedoraproject.org|ngomp...@gmail.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1551402] Review Request: falkon - Modern web browser

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1551402



--- Comment #2 from Kevin Kofler  ---
Successful scratch build for Rawhide here:
https://koji.fedoraproject.org/koji/taskinfo?taskID=25487176

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1551402] Review Request: falkon - Modern web browser

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1551402

Kevin Kofler  changed:

   What|Removed |Added

 CC||rdie...@gmail.com
 Blocks||656997 (kde-reviews)
  Alias||falkon



--- Comment #1 from Kevin Kofler  ---
This is the browser formerly known as QupZilla. It was renamed to Falkon and
the build system was changed from QMake to CMake, which is why this is not a
simple rename review.

At this time, Falkon is considered a new browser that can coexist with the
original QupZilla. There is currently no attempt at migrating existing users
using Obsoletes/Provides nor at reading or migrating existing configuration
files, profiles, and KWallet passwords from QupZilla.


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=656997
[Bug 656997] kde-related package review tracker
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org