[Bug 1555388] Review Request: golang-github-ncw-acd - Go library for accessing the Amazon Cloud Drive

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1555388



--- Comment #9 from Fedora Update System  ---
golang-github-ncw-acd-0-0.3.20180320git887eb06.fc27 has been pushed to the
Fedora 27 stable repository. If problems still persist, please make note of it
in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/NBEWHZCR4PORL7DADCG6RDIAKLMWZRQF/

[Bug 1555388] Review Request: golang-github-ncw-acd - Go library for accessing the Amazon Cloud Drive

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1555388



--- Comment #8 from Fedora Update System  ---
golang-github-ncw-acd-0-0.3.20180320git887eb06.fc27 has been pushed to the
Fedora 27 testing repository. If problems still persist, please make note of it
in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2018-8950721dbc

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/WJLL33WK3SP75XVVUKCKSZWJ63NXHYXV/

[Bug 1555388] Review Request: golang-github-ncw-acd - Go library for accessing the Amazon Cloud Drive

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1555388



--- Comment #7 from Fedora Update System  ---
golang-github-ncw-acd-0-0.3.20180320git887eb06.fc27 has been submitted as an
update to Fedora 27.
https://bodhi.fedoraproject.org/updates/FEDORA-2018-8950721dbc

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/7SFSLUFPNPXP3PYCLTXBJCP3IN4GGAPJ/

[Bug 1555388] Review Request: golang-github-ncw-acd - Go library for accessing the Amazon Cloud Drive

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1555388

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2018-03-30 09:10:01



--- Comment #6 from Fedora Update System  ---
golang-github-ncw-acd-0-0.3.20180320git887eb06.fc28 has been pushed to the
Fedora 28 stable repository. If problems still persist, please make note of it
in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1555388] Review Request: golang-github-ncw-acd - Go library for accessing the Amazon Cloud Drive

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1555388

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #5 from Fedora Update System  ---
golang-github-ncw-acd-0-0.3.20180320git887eb06.fc28 has been pushed to the
Fedora 28 testing repository. If problems still persist, please make note of it
in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2018-1d3f76ef3c

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1555388] Review Request: golang-github-ncw-acd - Go library for accessing the Amazon Cloud Drive

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1555388

Fedora Update System  changed:

   What|Removed |Added

 Status|POST|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1555388] Review Request: golang-github-ncw-acd - Go library for accessing the Amazon Cloud Drive

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1555388



--- Comment #4 from Fedora Update System  ---
golang-github-ncw-acd-0-0.3.20180320git887eb06.fc28 has been submitted as an
update to Fedora 28.
https://bodhi.fedoraproject.org/updates/FEDORA-2018-1d3f76ef3c

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1555388] Review Request: golang-github-ncw-acd - Go library for accessing the Amazon Cloud Drive

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1555388



--- Comment #3 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/golang-github-ncw-acd

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1555388] Review Request: golang-github-ncw-acd - Go library for accessing the Amazon Cloud Drive

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1555388

Jared Smith  changed:

   What|Removed |Added

 Status|NEW |POST
 CC||jsmith.fed...@gmail.com
   Assignee|nob...@fedoraproject.org|jsmith.fed...@gmail.com
  Flags||fedora-review+



--- Comment #2 from Jared Smith  ---
Package is APPROVED.

Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "ISC", "Unknown or generated". 11 files have unknown license.
 Detailed output of licensecheck in
 /home/jsmith/Documents/Fedora/Reviews/1555388-golang-github-ncw-
 acd/licensecheck.txt
[x]: Package must own all directories that it creates.
 Note: Directories without known owners: /usr/share/gocode/src,
 /usr/share/gocode
[x]: Package does not own files or directories owned by other packages.
 Note: Dirs in package are owned also by:
 /usr/share/gocode/src/github.com/ncw(golang-github-ncw-dropbox-sdk-go-
 unofficial-devel, golang-github-ncw-go-acd-devel, golang-github-ncw-
 swift-devel), /usr/share/gocode/src/github.com/ncw/go-acd(golang-
 github-ncw-go-acd-devel), /usr/share/gocode/src/github.com(golang-
 github-zyedidia-pty-devel, golang-github-jlaffaye-ftp-devel, golang-
 github-nwidger-jsoncolor-devel, golang-github-coreos-bbolt-devel,
 golang, golang-github-chzyer-logex-devel, golang-github-AdRoll-goamz-
 devel, golang-googlecode-goprotobuf-devel, golang-github-yuin-gopher-
 lua-devel, golang-github-zyedidia-clipboard-devel, golang-github-spf13
 -pflag-devel, golang-github-grpc-ecosystem-grpc-gateway-devel, etcd-
 devel, golang-github-rfjakob-eme-devel, golang-github-Sirupsen-logrus-
 devel, golang-github-spf13-cobra-devel, golang-github-billziss-gh-
 cgofuse-devel, golang-github-mattn-go-runewidth-devel, golang-github-
 kdar-factorlog-devel, golang-github-gogo-protobuf-devel, golang-
 github-robertkrimen-otto-devel, golang-github-zyedidia-poller-devel,
 golang-github-zyedidia-glob-devel, golang-github-zyedidia-tcell-devel,
 golang-github-xanzy-ssh-agent-devel, golang-github-zyedidia-terminal-
 devel, golang-github-flynn-json5-devel, golang-github-chzyer-test-
 devel)
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain 

[Bug 1555388] Review Request: golang-github-ncw-acd - Go library for accessing the Amazon Cloud Drive

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1555388



--- Comment #1 from Robert-André Mauchin  ---
Spec URL:
https://raw.githubusercontent.com/eclipseo/packaging/b99dae7/golang-github-ncw-acd.spec
SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/eclipseo/rclone/fedora-rawhide-x86_64/00728062-golang-github-ncw-acd/golang-github-ncw-acd-0-0.3.20180314git887eb06.fc29.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org