[Bug 1556636] Review Request: golang-gopkg-readline-1 - Pure golang implementation for GNU-Readline kind library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1556636



--- Comment #13 from Fedora Update System  ---
golang-gopkg-readline-1-1.4-4.20180408gitf6d7a1f.fc27 has been pushed to the
Fedora 27 stable repository. If problems still persist, please make note of it
in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/LAYBRN7RTJMZZE4MBREC3RLWZIZWDLQ7/

[Bug 1556636] Review Request: golang-gopkg-readline-1 - Pure golang implementation for GNU-Readline kind library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1556636



--- Comment #12 from Fedora Update System  ---
golang-gopkg-readline-1-1.4-4.20180408gitf6d7a1f.fc27 has been pushed to the
Fedora 27 testing repository. If problems still persist, please make note of it
in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2018-787cef2bae

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/SUZKB57VCVFTPA7CNFJOKS3CHRPSVSPF/

[Bug 1556636] Review Request: golang-gopkg-readline-1 - Pure golang implementation for GNU-Readline kind library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1556636



--- Comment #11 from Fedora Update System  ---
golang-gopkg-readline-1-1.4-4.20180408gitf6d7a1f.fc27 has been submitted as an
update to Fedora 27.
https://bodhi.fedoraproject.org/updates/FEDORA-2018-787cef2bae

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/BMG6MWIBIVR3RFR7EACFEO7QKGWXSZNS/

[Bug 1556636] Review Request: golang-gopkg-readline-1 - Pure golang implementation for GNU-Readline kind library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1556636



--- Comment #10 from Fedora Update System  ---
golang-gopkg-readline-1-1.4-3.fc27 has been pushed to the Fedora 27 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1556636] Review Request: golang-gopkg-readline-1 - Pure golang implementation for GNU-Readline kind library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1556636

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2018-03-30 09:13:18



--- Comment #9 from Fedora Update System  ---
golang-gopkg-readline-1-1.4-3.fc28 has been pushed to the Fedora 28 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1556636] Review Request: golang-gopkg-readline-1 - Pure golang implementation for GNU-Readline kind library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1556636



--- Comment #8 from Fedora Update System  ---
golang-gopkg-readline-1-1.4-3.fc27 has been pushed to the Fedora 27 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2018-a90c00a7dd

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1556636] Review Request: golang-gopkg-readline-1 - Pure golang implementation for GNU-Readline kind library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1556636

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #7 from Fedora Update System  ---
golang-gopkg-readline-1-1.4-3.fc28 has been pushed to the Fedora 28 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2018-46f209a383

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1556636] Review Request: golang-gopkg-readline-1 - Pure golang implementation for GNU-Readline kind library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1556636



--- Comment #6 from Fedora Update System  ---
golang-gopkg-readline-1-1.4-3.fc27 has been submitted as an update to Fedora
27. https://bodhi.fedoraproject.org/updates/FEDORA-2018-a90c00a7dd

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1556636] Review Request: golang-gopkg-readline-1 - Pure golang implementation for GNU-Readline kind library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1556636

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1556636] Review Request: golang-gopkg-readline-1 - Pure golang implementation for GNU-Readline kind library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1556636



--- Comment #5 from Fedora Update System  ---
golang-gopkg-readline-1-1.4-3.fc28 has been submitted as an update to Fedora
28. https://bodhi.fedoraproject.org/updates/FEDORA-2018-46f209a383

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1556636] Review Request: golang-gopkg-readline-1 - Pure golang implementation for GNU-Readline kind library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1556636



--- Comment #4 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/golang-gopkg-readline-1

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1556636] Review Request: golang-gopkg-readline-1 - Pure golang implementation for GNU-Readline kind library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1556636

Dominik 'Rathann' Mierzejewski  changed:

   What|Removed |Added

 CC||domi...@greysector.net
 Blocks||1558953




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1558953
[Bug 1558953] Unexpected import path for chzyer's readline library
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1556636] Review Request: golang-gopkg-readline-1 - Pure golang implementation for GNU-Readline kind library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1556636

Jared Smith  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #3 from Jared Smith  ---
Package is APPROVED.


Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "MIT/X11 (BSD like)", "do What The Fuck you want to Public
 License", "Unknown or generated". 42 files have unknown license.
 Detailed output of licensecheck in
 /home/jsmith/Documents/Fedora/Reviews/1556636-golang-gopkg-
 readline-1/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: If the package is under multiple licenses, the licensing breakdown
 must be documented in the spec.
[x]: Package must own all directories that it creates.
 Note: Directories without known owners: /usr/share/gocode/src,
 /usr/share/gocode, /usr/share/gocode/src/github.com
[x]: Package does not own files or directories owned by other packages.
 Note: Dirs in package are owned also by:
 /usr/share/gocode/src/gopkg.in/readline.v1/runes(golang-gopkg-
 readline-devel), /usr/share/gocode/src/gopkg.in/readline.v1(golang-
 gopkg-readline-devel), /usr/share/gocode/src/github.com/chzyer(golang-
 github-chzyer-logex-devel, golang-github-chzyer-test-devel),
 /usr/share/gocode/src/gopkg.in(golang-gopkg-sourcemap-1-devel)
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[x]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[x]: Package contains systemd file(s) if in need.
[-]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 51200 bytes in 9 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

= SHOULD items =

Generic:
[x]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
 Note: No 

[Bug 1556636] Review Request: golang-gopkg-readline-1 - Pure golang implementation for GNU-Readline kind library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1556636



--- Comment #2 from Robert-André Mauchin  ---
Thanks for the review.

Spec URL:
https://raw.githubusercontent.com/eclipseo/packaging/56089be/golang-gopkg-readline-1.spec
SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/eclipseo/micro/fedora-rawhide-x86_64/00728791-golang-gopkg-readline-1/golang-gopkg-readline-1-1.4-3.fc29.src.rpm

Spec diff:
https://github.com/eclipseo/packaging/commit/56089be7595cc45ac6b96d238e3a1f512881d65f#diff-7dea4165b391e4c0ec22559250396d75

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1556636] Review Request: golang-gopkg-readline-1 - Pure golang implementation for GNU-Readline kind library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1556636



--- Comment #1 from Jared Smith  ---
The package has some minor issues, see below:

Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
===
- There seems to be some code licensed under the WTFPL license.
  See licensecheck information below.
- Package installs properly.
  Note: Installation errors (see attachment)
  See: https://fedoraproject.org/wiki/Packaging:Guidelines


= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "MIT/X11 (BSD like)", "do What The Fuck you want to Public
 License", "Unknown or generated". 42 files have unknown license.
 Detailed output of licensecheck in
 /home/jsmith/Documents/Fedora/Reviews/1556636-golang-gopkg-
 readline-1/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package must own all directories that it creates.
 Note: Directories without known owners: /usr/share/gocode/src,
 /usr/share/gocode, /usr/share/gocode/src/github.com
[x]: Package does not own files or directories owned by other packages.
 Note: Dirs in package are owned also by:
 /usr/share/gocode/src/github.com/chzyer(golang-github-chzyer-logex-
 devel, golang-github-chzyer-test-devel)
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 30720 bytes in 2 files.
[ ]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

= SHOULD items =

Generic:
[x]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[!]: Fully versioned dependency in subpackages if applicable.
 Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in golang-
 gopkg-readline-1-devel , compat-golang-github-chzyer-readline-devel
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file 

[Bug 1556636] Review Request: golang-gopkg-readline-1 - Pure golang implementation for GNU-Readline kind library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1556636

Jared Smith  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||jsmith.fed...@gmail.com
   Assignee|nob...@fedoraproject.org|jsmith.fed...@gmail.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org