[Bug 1557781] Review Request: libdmapsharing4 - A DMAP client and server library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1557781



--- Comment #11 from Fedora Update System  ---
libdmapsharing4-3.9.1-1.fc27 has been pushed to the Fedora 27 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1557781] Review Request: libdmapsharing4 - A DMAP client and server library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1557781

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed|2018-03-21 13:57:18 |2018-03-30 09:13:37



--- Comment #10 from Fedora Update System  ---
libdmapsharing4-3.9.1-1.fc28 has been pushed to the Fedora 28 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1557781] Review Request: libdmapsharing4 - A DMAP client and server library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1557781



--- Comment #9 from Fedora Update System  ---
libdmapsharing4-3.9.1-1.fc27 has been pushed to the Fedora 27 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2018-9ab4832284

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1557781] Review Request: libdmapsharing4 - A DMAP client and server library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1557781

Fedora Update System  changed:

   What|Removed |Added

 Status|CLOSED  |ON_QA
 Resolution|RAWHIDE |---
   Keywords||Reopened



--- Comment #8 from Fedora Update System  ---
libdmapsharing4-3.9.1-1.fc28 has been pushed to the Fedora 28 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2018-c5aef754cc

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1557781] Review Request: libdmapsharing4 - A DMAP client and server library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1557781



--- Comment #7 from Fedora Update System  ---
libdmapsharing4-3.9.1-1.fc27 has been submitted as an update to Fedora 27.
https://bodhi.fedoraproject.org/updates/FEDORA-2018-9ab4832284

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1557781] Review Request: libdmapsharing4 - A DMAP client and server library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1557781

W. Michael Petullo  changed:

   What|Removed |Added

 Status|POST|CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2018-03-21 13:57:18



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1557781] Review Request: libdmapsharing4 - A DMAP client and server library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1557781



--- Comment #6 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/libdmapsharing4

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1557781] Review Request: libdmapsharing4 - A DMAP client and server library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1557781

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|NEW |POST
   Assignee|nob...@fedoraproject.org|zebo...@gmail.com
  Flags||fedora-review+



--- Comment #5 from Robert-André Mauchin  ---
 - Group: is not needed in the subpackages either

 - Directories should be owned with the %dir macros, like:

%files
%{_libdir}/libdmapsharing-4.0.so.*
%dir %{_libdir}/girepository-1.0/
%{_libdir}/girepository-1.0/Dmap-4.0.typelib

%doc AUTHORS ChangeLog README
%license COPYING

%files devel
%{_libdir}/pkgconfig/libdmapsharing-4.0.pc
%{_includedir}/libdmapsharing-4.0/
%{_libdir}/libdmapsharing-4.0.so
%{_datadir}/gtk-doc/html/libdmapsharing-4.0
%dir %{_datadir}/gir-1.0/
%{_datadir}/gir-1.0/Dmap-4.0.gir

%files vala
%dir %{_datadir}/vala/
%dir %{_datadir}/vala/vapi/
%{_datadir}/vala/vapi/libdmapsharing-4.0.vapi


Packages otherwise approved. Fix those minor issues befoe import.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1557781] Review Request: libdmapsharing4 - A DMAP client and server library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1557781



--- Comment #4 from W. Michael Petullo  ---
Regarding the comment about the -compat package, I followed the model of
gstreamer1 and glib2.

Everything else should be fixed.

Spec URL: https://www.flyn.org/SRPMS/libdmapsharing4.spec
SRPM URL: https://www.flyn.org/SRPMS/libdmapsharing4-3.9.1-1.fc27.src.rpm

Description:
libdmapsharing implements the DMAP protocols. This includes support for
DAAP and DPAP.

This package provides the emerging libdmapsharing API which is incompatible
with the existing package.

Fedora Account System Username: mikep

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1557781] Review Request: libdmapsharing4 - A DMAP client and server library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1557781

Robert-André Mauchin  changed:

   What|Removed |Added

 CC||zebo...@gmail.com



--- Comment #3 from Robert-André Mauchin  ---
 - Group: is not needed. See
https://fedoraproject.org/wiki/Packaging:Guidelines#Tags_and_Sections

 - Requires should include the arch:

Requires: %{name}%{?_isa} = %{version}-%{release}

   See
https://fedoraproject.org/wiki/Packaging:Guidelines#Requiring_Base_Package

 - Use the new ldconfig macros. See
https://fedoraproject.org/wiki/Changes/Removing_ldconfig_scriptlets#Upgrade.2Fcompatibility_impact

   Replace:

%post -p /sbin/ldconfig

%postun -p /sbin/ldconfig

   with:

%ldconfig_scriptlets

 - Own these directories:

[!]: Package must own all directories that it creates.
 Note: Directories without known owners: /usr/lib64/girepository-1.0,
 /usr/share/vala/vapi, /usr/share/gir-1.0, /usr/share/vala

 - Shouldn't you update libdmapsharing to version 4 and then provide a compat
package for older versions?

 - %{_libdir}/girepository-1.0/Dmap-4.0.typelib should be in the main package,
not the devel subpackage.


Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "GPL", "GPL (v3 or later)", "Unknown or generated", "*No
 copyright* GPL", "MIT/X11 (BSD like)", "Public domain LGPL (v2.1 or
 later)", "GPL (v2 or later) (with incorrect FSF address)", "LGPL (v2.1
 or later)", "*No copyright* LGPL (v2.1 or later)". 118 files have
 unknown license. Detailed output of licensecheck in
 /home/bob/packaging/review/libdmapsharing4/review-
 libdmapsharing4/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[!]: Package must own all directories that it creates.
 Note: Directories without known owners: /usr/lib64/girepository-1.0,
 /usr/share/vala/vapi, /usr/share/gir-1.0, /usr/share/vala
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 153600 bytes in 3 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.

[Bug 1557781] Review Request: libdmapsharing4 - A DMAP client and server library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1557781



--- Comment #2 from W. Michael Petullo  ---
Spec URL: https://www.flyn.org/SRPMS/libdmapsharing4.spec
SRPM URL: https://www.flyn.org/SRPMS/libdmapsharing4-3.9.1-1.fc27.src.rpm

Description:
libdmapsharing implements the DMAP protocols. This includes support for
DAAP and DPAP.

This package provides the emerging libdmapsharing API which is incompatible
with the existing package.

Fedora Account System Username: mikep

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1557781] Review Request: libdmapsharing4 - A DMAP client and server library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1557781

Antonio Trande  changed:

   What|Removed |Added

 CC||anto.tra...@gmail.com



--- Comment #1 from Antonio Trande  ---
Please, re-write the SPEC file's sections in the classic sequence in order to
get a legible text for everyone:
https://fedoraproject.org/wiki/How_to_create_a_GNU_Hello_RPM_package#Inside_a_.spec_file

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org