needinfo canceled: [Bug 1558312] Review Request: etherwallet - Client-side tool for interacting with the Ethereum network

[bugzilla]

Product: Fedora
Version: rawhide
Component: Package Review

Package Review  has canceled Package
Review 's request for Rene Jr Purcell
's needinfo:
Bug 1558312: Review Request: etherwallet - Client-side tool for interacting
with the Ethereum network
https://bugzilla.redhat.com/show_bug.cgi?id=1558312



--- Comment #8 from Package Review  ---
This is an automatic action taken by review-stats script.

The ticket submitter failed to clear the NEEDINFO flag in a month.
As per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews
we consider this ticket as DEADREVIEW and proceed to close it.
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1558312] Review Request: etherwallet - Client-side tool for interacting with the Ethereum network

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1558312



--- Comment #6 from Robert-André Mauchin  ---
Repost as is and I'll review the thingie.
Don't forget to add a Provides: bundled(jquery) = 1.12.3

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1558312] Review Request: etherwallet - Client-side tool for interacting with the Ethereum network

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1558312



--- Comment #5 from Rene Jr Purcell  ---
Hi Robert, I should have updated those request. I've talked with few helping
folks on freenode after I posted those review request and they told me exactly
the same thing as your last comment. I then realised there a load of dependency
in there.. And I just can't build packages for all of those, if I remember it
was like 200 nodejs dependency..

So I don't know if things has changed since but if I really need to build
packages for every dependency than I will not have the time required to do this
unfortunately..

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1558312] Review Request: etherwallet - Client-side tool for interacting with the Ethereum network

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1558312



--- Comment #4 from Robert-André Mauchin  ---
I'm sorry I have forgotten this review.

The problem I have with this is that you're distributing the end result instead
of building from the source with gulp.

You might need to package some gulp dependencies yourself to get the whole
pipeline (may take some work).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1558312] Review Request: etherwallet - Client-side tool for interacting with the Ethereum network

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1558312



--- Comment #3 from Rene Jr Purcell  ---
I've updated the spec file according to your comment on my other package:
https://bugzilla.redhat.com/show_bug.cgi?id=1558976#c1

So the LICENSE.md file has been added and the changelog section of the spec
file has been populated. There was a new release of the upstream today, it's
now in sync with it.

Spec URL:
https://copr-be.cloud.fedoraproject.org/results/arsenick/MyLiveCrypto/fedora-27-x86_64/00731471-etherwallet/mew.spec

SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/arsenick/MyLiveCrypto/fedora-27-x86_64/00731471-etherwallet/etherwallet-3.21.03-1.fc27.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1558312] Review Request: etherwallet - Client-side tool for interacting with the Ethereum network

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1558312



--- Comment #2 from Rene Jr Purcell  ---
Thank you for your suggestions, I think I've fixed most/all of your point.

Here's the Spec and srpm updated.

Spec URL:
https://copr-be.cloud.fedoraproject.org/results/arsenick/MyLiveCrypto/fedora-27-x86_64/00730407-etherwallet/mew.spec

SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/arsenick/MyLiveCrypto/fedora-27-x86_64/00730407-etherwallet/etherwallet-3.21.02-1.fc27.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1558312] Review Request: etherwallet - Client-side tool for interacting with the Ethereum network

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1558312



--- Comment #1 from Robert-André Mauchin  ---
Just a few preliminary remarks.

 - Not needed:
- Group:
- BuildRoot: %{_tmppath}/%{name}-v%{version}-root
- %{__rm} -rf %{buildroot}
- %clean
  %{__rm} -rf %{buildroot}
- %defattr(-,root,root,-)

 - /usr/share/mew/ → %{_datadir}/mew/

 - Split the description lines to stay below 80 characters per line

 - No need to use macros for %{__install} and %{__cp}

 - Don't put this in the summary: Package maintained by Rene Jr Purcell.

 - Summary shouldn't end with a dot

 - The correct shorthand for MIT is MIT, not "MIT License". See
https://fedoraproject.org/wiki/Licensing:Main?rd=Licensing#SoftwareLicenses for
a list of valid licenses.

 - Don't depend on Firefox, let the user choose whatever browser they want

 - Latest version is v3.21.02

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1558312] Review Request: etherwallet - Client-side tool for interacting with the Ethereum network

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1558312

Robert-André Mauchin  changed:

   What|Removed |Added

 CC||zebo...@gmail.com
 Blocks||177841 (FE-NEEDSPONSOR)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org