needinfo canceled: [Bug 1558683] Review Request: python-ucsmsdk - Python SDK for Cisco UCSM

[bugzilla]

Product: Fedora
Version: rawhide
Component: Package Review

Alfredo Moralejo  has canceled Package Review
's request for Alfredo Moralejo
's needinfo:
Bug 1558683: Review Request:  python-ucsmsdk - Python SDK for Cisco UCSM
https://bugzilla.redhat.com/show_bug.cgi?id=1558683



--- Comment #40 from Alfredo Moralejo  ---
No response from the requestor after one year, so i guess this can be closed.
Feel free to reopen it if it's still required.
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure

[Bug 1558683] Review Request: python-ucsmsdk - Python SDK for Cisco UCSM

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1558683

Alfredo Moralejo  changed:

   What|Removed |Added

  Flags|needinfo?(amoralej@redhat.c |
   |om) |
 Status|ASSIGNED|CLOSED
 Resolution|--- |WONTFIX
Last Closed||2022-06-23 06:26:32



--- Comment #40 from Alfredo Moralejo  ---
No response from the requestor after one year, so i guess this can be closed.
Feel free to reopen it if it's still required.


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=1558683
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure

[Bug 1558683] Review Request: python-ucsmsdk - Python SDK for Cisco UCSM

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1558683



--- Comment #38 from Alfredo Moralejo  ---
I think this package si not longer needed and this bz can be closed?


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure

[Bug 1558683] Review Request: python-ucsmsdk - Python SDK for Cisco UCSM

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1558683

Yatin Karel  changed:

   What|Removed |Added

 CC||yka...@redhat.com
 Blocks|1550514 (RDO-ROCKY) |



--- Comment #37 from Yatin Karel  ---
The package available for queens till train since long, removing RDO-ROCKY
tracker as rocky released long ago.:-
  cloud7-openstack-queens-release: python-ucsmsdk-0.9.3.2-1.el7
  cloud7-openstack-queens-testing: python-ucsmsdk-0.9.3.2-1.el7
  cloud7-openstack-rocky-release: python-ucsmsdk-0.9.3.2-1.el7
  cloud7-openstack-rocky-testing: python-ucsmsdk-0.9.3.2-1.el7
  cloud7-openstack-stein-release: python-ucsmsdk-0.9.3.2-1.el7
  cloud7-openstack-stein-testing: python-ucsmsdk-0.9.3.2-1.el7
  cloud7-openstack-train-release: python-ucsmsdk-0.9.3.2-1.el7
  cloud7-openstack-train-testing: python-ucsmsdk-0.9.3.2-1.el7



Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1550514
[Bug 1550514] Tracker: Blockers and Review requests for new RDO Rocky packages
-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1558683] Review Request: python-ucsmsdk - Python SDK for Cisco UCSM

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1558683

Petr Pisar  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||ppi...@redhat.com
  Flags||fedora-review?




-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1558683] Review Request: python-ucsmsdk - Python SDK for Cisco UCSM

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1558683

Sandhya Dasu  changed:

   What|Removed |Added

  Flags|needinfo?(amoralej@redhat.c |
   |om) |
   |needinfo?(sad...@cisco.com) |



--- Comment #36 from Sandhya Dasu  ---
Yes. There was some mis-understanding regarding the process. Now that has been
clarified and we are in the process of adding a newer version of the package
that is python3 compatible.

(In reply to Robert-André Mauchin from comment #35)
> Sandhya Dasu: do you still need a sponsorship?

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1558683] Review Request: python-ucsmsdk - Python SDK for Cisco UCSM

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1558683

Robert-André Mauchin  changed:

   What|Removed |Added

  Flags||needinfo?(sad...@cisco.com)



--- Comment #35 from Robert-André Mauchin  ---
Sandhya Dasu: do you still need a sponsorship?

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1558683] Review Request: python-ucsmsdk - Python SDK for Cisco UCSM

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1558683

Robert-André Mauchin  changed:

   What|Removed |Added

 CC||zebo...@gmail.com
  Flags||needinfo?(amoralej@redhat.c
   ||om)



--- Comment #34 from Robert-André Mauchin  ---
What's the status of this review? Why was the (+) cancelled?

New Py2 package are not allowed, only package Py 3.

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1558683] Review Request: python-ucsmsdk - Python SDK for Cisco UCSM

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1558683

Bradley Jones  changed:

   What|Removed |Added

 CC||bradj...@cisco.com



--- Comment #33 from Bradley Jones  ---
I have submitted a PR https://github.com/rdo-common/python-ucsmsdk/pull/1 to
update to the newest version of ucsmsdk and fix a missing build dependency

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1558683] Review Request: python-ucsmsdk - Python SDK for Cisco UCSM

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1558683

Alfredo Moralejo  changed:

   What|Removed |Added

  Flags|fedora-review+  |



-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1558683] Review Request: python-ucsmsdk - Python SDK for Cisco UCSM

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1558683



--- Comment #32 from Alan Pevec  ---
We should still finish the package review here, RHEL and RDO/OSP inherit from
Fedora packaging guidelines so Fedora package review is used when importing it.

We did shortcut the process by importing as RDO dependency into
https://github.com/rdo-common/python-ucsmsdk with the understanding this Fedora
review will be eventually finished.

Until then please send updates as PRs in
https://github.com/rdo-common/python-ucsmsdk/pulls

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1558683] Review Request: python-ucsmsdk - Python SDK for Cisco UCSM

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1558683



--- Comment #31 from Sandhya Dasu  ---
It appears that this step is not necessary for OSP13. We could just include the
python-ucsmsdk package within the networking-cisco container. There is really
no need for this to be added to Fedora so it can be made part of RHEL and then
available for a "yum install" on RHEL OSP.

If this is correct, then this BZ can effectively be closed.

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1558683] Review Request: python-ucsmsdk - Python SDK for Cisco UCSM

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1558683

Sean Merrow  changed:

   What|Removed |Added

URL||https://pypi.org/project/uc
   ||smsdk/
 CC||smer...@redhat.com
 Blocks||1496480, 1476902



--- Comment #30 from Sean Merrow  ---
Adding URL to ucsmsdk 0.9.4 which adds Python 3 support

https://pypi.org/project/ucsmsdk/

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1558683] Review Request: python-ucsmsdk - Python SDK for Cisco UCSM

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1558683

Matthias Runge  changed:

   What|Removed |Added

 CC||mru...@redhat.com



--- Comment #29 from Matthias Runge  ---
- please use newer macros, like py2_build and py2_install, and the same for
python3.
- Please add a check section and execute the tests. Listing checks added and
passing in above review is wrong.
- please also link "inofficial reviews" you did here in Fedora.
- the page in pypi lists, this supports Python 3.4, in Fedora, there is Python
3.7

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/K6LQEIVPC2XZ3QOVJBV2TKEZT36EOUMV/

[Bug 1558683] Review Request: python-ucsmsdk - Python SDK for Cisco UCSM

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1558683

Alfredo Moralejo  changed:

   What|Removed |Added

  Flags|needinfo?(Brian.Demers@gmai |
   |l.com)  |



-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/FLZP5G7DPTSUDZQJO2XXRMHHRJZWFA7Z/

[Bug 1558683] Review Request: python-ucsmsdk - Python SDK for Cisco UCSM

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1558683



--- Comment #28 from Alfredo Moralejo  ---
I'm requesting a new repo for this package in
https://pagure.io/releng/fedora-scm-requests/issue/7277

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/Y74HDMRFK7D45VHKPRMYM2JHJRKSDV7E/

[Bug 1558683] Review Request: python-ucsmsdk - Python SDK for Cisco UCSM

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1558683

Alfredo Moralejo  changed:

   What|Removed |Added

 Blocks||177841 (FE-NEEDSPONSOR)



--- Comment #27 from Alfredo Moralejo  ---
Could someone sponsor Sandhya as packager to maintain this package in Fedora.

Fedora user: sdasu


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor
-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/KREM4XB2L4TU2O4GERWVU2ZFKZZZWVWE/

[Bug 1558683] Review Request: python-ucsmsdk - Python SDK for Cisco UCSM

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1558683



--- Comment #26 from Sandhya Dasu  ---
Brian Demers (brian.dem...@gmail.com) is no longer associated with the project.
I am under the impression that I did the necessary groundwork to be Fedora
packager myself.

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/MN7RLWOP73BULIPYBTNQWANGBF5UMUGJ/

[Bug 1558683] Review Request: python-ucsmsdk - Python SDK for Cisco UCSM

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1558683

Alfredo Moralejo  changed:

   What|Removed |Added

  Flags||needinfo?(Brian.Demers@gmai
   ||l.com)



--- Comment #25 from Alfredo Moralejo  ---
You can continue with the process to get the package in Fedora described in
https://fedoraproject.org/wiki/New_package_process_for_existing_contributors
(step 7).

As this requires to be a fedora packager, i guess brian.dem...@gmail.com can
assist on next steps.

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/SMOCY7SAYKPN5OUVIB2PQFL63KRF34Y2/

[Bug 1558683] Review Request: python-ucsmsdk - Python SDK for Cisco UCSM

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1558683

Alfredo Moralejo  changed:

   What|Removed |Added

  Flags||fedora-review+



--- Comment #24 from Alfredo Moralejo  ---
Official fedora review:

Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
===
- If (and only if) the source package includes the text of the license(s)
  in its own file, then that file, containing the text of the license(s)
  for the package is included in %license.
  Note: License file LicenseContents.py is not marked as %license
  See:
  http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text


= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "Apache (v2.0)", "*No copyright* Apache", "Unknown or
 generated", "*No copyright* Apache (v2.0)". 2072 files have unknown
 license. Detailed output of licensecheck in /tmp/python-
 ucsmsdk/licensecheck.txt
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: No rpmlint messages.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
 process.
[x]: A package which is used by another package via an egg interface should
 provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Description and summary sections in the package spec file contains
 translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
 architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve 

[Bug 1558683] Review Request: python-ucsmsdk - Python SDK for Cisco UCSM

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1558683



--- Comment #23 from Alfredo Moralejo  ---
Final version:

Spec URL:
https://github.com/amoralej/ucsmsdk-rpm/raw/master/python-ucsmsdk.spec
SRPM URL:
https://github.com/amoralej/ucsmsdk-rpm/raw/master/python-ucsmsdk-0.9.3.2-1.fc29.src.rpm

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/VSWVMYDLFCKH4B2QE2XKACD2Z6VQHUM4/

[Bug 1558683] Review Request: python-ucsmsdk - Python SDK for Cisco UCSM

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1558683



--- Comment #22 from Sandhya Dasu  ---
Updated .spec file with the python2-parsing runtime requirements.

Spec URL:
https://raw.githubusercontent.com/sadasu/ucsmsdk-rpm/master/python-ucsmsdk.spec
SRPM URL:
https://raw.githubusercontent.com/sadasu/ucsmsdk-rpm/master/python-ucsmsdk-0.9.3.2-1.el7.src.rpm
Description: SRPM and .spec files for python-ucsmsdk version 0.9.3.2 to be
added as a new package to Fedora.
Fedora Account System Username: sdasu

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/APVMMPIIDAY7P7JKSK6HFYMGQYP5EHKE/

[Bug 1558683] Review Request: python-ucsmsdk - Python SDK for Cisco UCSM

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1558683



--- Comment #21 from Alfredo Moralejo  ---
Last spec only has python2-pyparsing as BuildRequires. Those are build
requirements, you need to also add it as runtime requirement adding line:

Requires: python2-pyparsing

under %package -n python2-ucsmsdk subpackate (under line 22)

Note that, for fedora review automatic parsing "Spec URL" and "SRPM URL" urls
must point to raw content.

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/ER6IBZLC3XK2GA3QNCWP52KS7325SMLC/

[Bug 1558683] Review Request: python-ucsmsdk - Python SDK for Cisco UCSM

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1558683



--- Comment #20 from Sandhya Dasu  ---
Hi,
   I have updated the .spec file to add python2-pyparsing as a requirement. As
per the ucsmsdk team, version 0.9.3.2 does not support python3 yet. So, I
haven't added a section for python3. I will keep a close watch and update the
fedora package with the next version that of ucsmsdk which will start
supporting python3.

Once again:

Spec URL: https://github.com/sadasu/ucsmsdk-rpm/blob/master/python-ucsmsdk.spec
SRPM URL:
https://github.com/sadasu/ucsmsdk-rpm/blob/master/python-ucsmsdk-0.9.3.2-1.el7.src.rpm
Description: SRPM and .spec files for python-ucsmsdk version 0.9.3.2 to be
added as a new package to Fedora.
Fedora Account System Username: sdasu

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/I64D56PTXKCPYSNLBGFB3GIG6YDOWVO2/

[Bug 1558683] Review Request: python-ucsmsdk - Python SDK for Cisco UCSM

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1558683



--- Comment #19 from Alfredo Moralejo  ---
Hi,

It's still missing requirement python2-pyparsing. Could you add it?, something
like:

Requires: python2-pyparsing

IIUC, this version does support python3, could you add subpackages for both
python2 and python3. Note that python3 should have conditional to be built only
when done in fedora. You can take
https://src.fedoraproject.org/rpms/python-webob/blob/master/f/python-webob.spec
as example.

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/COZ2HPBT5KKPTCECTGK3CEEZ4LIDADBO/

[Bug 1558683] Review Request: python-ucsmsdk - Python SDK for Cisco UCSM

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1558683



--- Comment #18 from Sandhya Dasu  ---
Spec URL: https://github.com/sadasu/ucsmsdk-rpm/blob/master/python-ucsmsdk.spec
SRPM URL:
https://github.com/sadasu/ucsmsdk-rpm/blob/master/python-ucsmsdk-0.9.3.2-1.el7.src.rpm
Description: SRPM and .spec files for python-ucsmsdk version 0.9.3.2 to be
added as a new package to Fedora.
Fedora Account System Username: sdasu

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/MGSWKVFGA23476P74WJ6WFMQ4KHOROVU/

[Bug 1558683] Review Request: python-ucsmsdk - Python SDK for Cisco UCSM

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1558683



--- Comment #17 from Alfredo Moralejo  ---
Please, update the spec and srpm to fix the missing Requires on
python2-pyparsing and we can move one with this.

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1558683] Review Request: python-ucsmsdk - Python SDK for Cisco UCSM

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1558683

Alan Pevec  changed:

   What|Removed |Added

 Blocks||1550514 (RDO-ROCKY)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1550514
[Bug 1550514] Tracker: Blockers and Review requests for new RDO Rocky
packages
-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1558683] Review Request: python-ucsmsdk - Python SDK for Cisco UCSM

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1558683



--- Comment #16 from Sandhya Dasu  ---
A new python-ucsmsdk release is not expected soon. As soon as it becomes
available, I will update the .spec file and RPM to reflect that.

Until that time, can we go ahead with package approval process for ucsmsdk? Is
there something else that needs to be done from my end?

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1558683] Review Request: python-ucsmsdk - Python SDK for Cisco UCSM

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1558683



--- Comment #15 from Alfredo Moralejo  ---
(In reply to Sandhya Dasu from comment #14)
> A change to run UTs without dependency on the presence of an actual UCS
> domain has just been merged.
> 
> What are the proposed next steps? 
> 
> 1. We build an RPM with the latest release + the commit id of the UT fix?
> 2. Proceed with the current RPM and then update the RPM when a new ucsmsdk
> release with this fix is release?
> 

The best option would be go get a new release as soon as possible and build it.
If it's not possible, we can build latest release without tests and add them
when a new tag is created.

> I have a related question. Is the .spec file being used to generate your own
> RPM or is the RPM already build by us being used to add to Fedora?
> 

I'm not sure i understand the question, but the process to add a package to
fedora is to get a new repository for the spec files in
https://src.fedoraproject.org/ (once this package review is approved), then
upload the spec file using "fedpkg push" and build it in
https://koji.fedoraproject.org using fedpkg build command. The process is
described in :

https://fedoraproject.org/wiki/New_package_process_for_existing_contributors

Let me know if this is clear or you need further help.


> Thanks,
> Sandhya

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1558683] Review Request: python-ucsmsdk - Python SDK for Cisco UCSM

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1558683



--- Comment #14 from Sandhya Dasu  ---
A change to run UTs without dependency on the presence of an actual UCS domain
has just been merged.

What are the proposed next steps? 

1. We build an RPM with the latest release + the commit id of the UT fix?
2. Proceed with the current RPM and then update the RPM when a new ucsmsdk
release with this fix is release?

I have a related question. Is the .spec file being used to generate your own
RPM or is the RPM already build by us being used to add to Fedora?

Thanks,
Sandhya

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1558683] Review Request: python-ucsmsdk - Python SDK for Cisco UCSM

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1558683



--- Comment #13 from Alfredo Moralejo  ---
(In reply to Sandhya Dasu from comment #12)
> (In reply to Alfredo Moralejo from comment #11)
> > Some notes:
> > 
> > - Missing Requires on python2-pyparsing for python2-ucsmsdk package.
> Updating ucsmsdk with requirements.txt containing pyparsing. Will upload
> another RPM shortly.
> > - Does ucsmsdk support python3?, i'm trying to run unit tests in Fedora with
> > python3 and it's failing. We should build the package for python2 and
> > python3 as fedora is moving to it.
> 
> Yes, does support Python3. Will build package for both python2 and python3.
> 
> > - It'd be nice to run unit tests in %check section of the spec if possible
> > (you can look at
> > https://src.fedoraproject.org/rpms/python-kubernetes/blob/master/f/python-
> > kubernetes.spec for example)
> 
> Just spoke to original authors of ucsmsdk. UTs currently require access to a
> valid UCSM domain (UCSM or an emulator) for them to pass.

ok, then, we can skip then. However, by definition, unit tests should not be
influenced by external conditions which should be mocked.

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1558683] Review Request: python-ucsmsdk - Python SDK for Cisco UCSM

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1558683



--- Comment #12 from Sandhya Dasu  ---
(In reply to Alfredo Moralejo from comment #11)
> Some notes:
> 
> - Missing Requires on python2-pyparsing for python2-ucsmsdk package.
Updating ucsmsdk with requirements.txt containing pyparsing. Will upload
another RPM shortly.
> - Does ucsmsdk support python3?, i'm trying to run unit tests in Fedora with
> python3 and it's failing. We should build the package for python2 and
> python3 as fedora is moving to it.

Yes, does support Python3. Will build package for both python2 and python3.

> - It'd be nice to run unit tests in %check section of the spec if possible
> (you can look at
> https://src.fedoraproject.org/rpms/python-kubernetes/blob/master/f/python-
> kubernetes.spec for example)

Just spoke to original authors of ucsmsdk. UTs currently require access to a
valid UCSM domain (UCSM or an emulator) for them to pass.

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1558683] Review Request: python-ucsmsdk - Python SDK for Cisco UCSM

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1558683



--- Comment #11 from Alfredo Moralejo  ---
Some notes:

- Missing Requires on python2-pyparsing for python2-ucsmsdk package.
- Does ucsmsdk support python3?, i'm trying to run unit tests in Fedora with
python3 and it's failing. We should build the package for python2 and python3
as fedora is moving to it.
- It'd be nice to run unit tests in %check section of the spec if possible (you
can look at
https://src.fedoraproject.org/rpms/python-kubernetes/blob/master/f/python-kubernetes.spec
for example)

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1558683] Review Request: python-ucsmsdk - Python SDK for Cisco UCSM

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1558683



--- Comment #10 from Alfredo Moralejo  ---
Spec URL:
https://raw.githubusercontent.com/sadasu/ucsmsdk-rpm/master/python-ucsmsdk.spec
SRPM URL:
https://github.com/sadasu/ucsmsdk-rpm/raw/master/python-ucsmsdk-0.9.3.1-1.el7.src.rpm

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1558683] Review Request: python-ucsmsdk - Python SDK for Cisco UCSM

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1558683



--- Comment #9 from Alfredo Moralejo  ---
Spec URL:
https://raw.githubusercontent.com/sadasu/ucsmsdk-rpm/master/python-ucsmsdk.spec
SRPM URL:
https://github.com/sadasu/ucsmsdk-rpm/blob/master/python-ucsmsdk-0.9.3.1-1.el7.src.rpm?raw=true

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1558683] Review Request: python-ucsmsdk - Python SDK for Cisco UCSM

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1558683

Alfredo Moralejo  changed:

   What|Removed |Added

   Assignee|nob...@fedoraproject.org|amora...@redhat.com



-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1558683] Review Request: python-ucsmsdk - Python SDK for Cisco UCSM

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1558683



--- Comment #8 from Sandhya Dasu  ---
Spec URL: https://github.com/sadasu/ucsmsdk-rpm/blob/master/python-ucsmsdk.spec
SRPM URL:
https://github.com/sadasu/ucsmsdk-rpm/blob/master/python-ucsmsdk-0.9.3.1-1.el7.src.rpm
Description: SRPM and .spec files for python-ucsmsdk version 0.9.3.1 to be
added as a new package to Fedora.
Fedora Account System Username: sdasu

Hope this is what is expected from us.

Thanks,
Sandhya

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1558683] Review Request: python-ucsmsdk - Python SDK for Cisco UCSM

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1558683

Sandhya Dasu  changed:

   What|Removed |Added

  Flags|needinfo?(sad...@cisco.com) |



--- Comment #7 from Sandhya Dasu  ---
I created an Fedora packer account (sdasu) successfully. I have created the
spec file here: https://github.com/sadasu/ucsmsdk-rpm

Could you please provide me a link to instructions to build the RPM itself?

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1558683] Review Request: python-ucsmsdk - Python SDK for Cisco UCSM

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1558683

Alan Pevec  changed:

   What|Removed |Added

Summary|Package python-ucsmsdk to   |Review Request:
   |be added to Fedora  |python-ucsmsdk - Python SDK
   ||for Cisco UCSM



-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org