[Bug 1572969] Review Request: zipper - C++ wrapper around minizip compression library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1572969



--- Comment #11 from Fedora Update System  ---
COPASI-4.23.184-2.fc28, libCombine-0.2.2-3.20180426git8902b68.fc28,
libsbml-5.16.0-7.fc28, zipper-0.9.1-3.20170831giteee877a.fc28 has been pushed
to the Fedora 28 stable repository. If problems still persist, please make note
of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1572969] Review Request: zipper - C++ wrapper around minizip compression library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1572969

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2018-05-15 15:52:51



--- Comment #10 from Fedora Update System  ---
COPASI-4.23.184-2.fc27, libCombine-0.2.2-3.20180426git8902b68.fc27,
libsbml-5.16.0-7.fc27, zipper-0.9.1-3.20170831giteee877a.fc27 has been pushed
to the Fedora 27 stable repository. If problems still persist, please make note
of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1572969] Review Request: zipper - C++ wrapper around minizip compression library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1572969



--- Comment #9 from Fedora Update System  ---
COPASI-4.23.184-2.fc27, libCombine-0.2.2-3.20180426git8902b68.fc27,
libsbml-5.16.0-7.fc27, zipper-0.9.1-3.20170831giteee877a.fc27 has been pushed
to the Fedora 27 testing repository. If problems still persist, please make
note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2018-d516abc03f

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1572969] Review Request: zipper - C++ wrapper around minizip compression library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1572969

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #8 from Fedora Update System  ---
COPASI-4.23.184-2.fc28, libCombine-0.2.2-3.20180426git8902b68.fc28,
libsbml-5.16.0-7.fc28, zipper-0.9.1-3.20170831giteee877a.fc28 has been pushed
to the Fedora 28 testing repository. If problems still persist, please make
note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2018-f4d4225641

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1572969] Review Request: zipper - C++ wrapper around minizip compression library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1572969



--- Comment #7 from Fedora Update System  ---
COPASI-4.23.184-2.fc28 libCombine-0.2.2-3.20180426git8902b68.fc28
zipper-0.9.1-3.20170831giteee877a.fc28 libsbml-5.16.0-7.fc28 has been submitted
as an update to Fedora 28.
https://bodhi.fedoraproject.org/updates/FEDORA-2018-f4d4225641

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1572969] Review Request: zipper - C++ wrapper around minizip compression library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1572969



--- Comment #6 from Fedora Update System  ---
COPASI-4.23.184-2.fc27 libCombine-0.2.2-3.20180426git8902b68.fc27
zipper-0.9.1-3.20170831giteee877a.fc27 libsbml-5.16.0-7.fc27 has been submitted
as an update to Fedora 27.
https://bodhi.fedoraproject.org/updates/FEDORA-2018-d516abc03f

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1572969] Review Request: zipper - C++ wrapper around minizip compression library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1572969

Fedora Update System  changed:

   What|Removed |Added

 Status|POST|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1572969] Review Request: zipper - C++ wrapper around minizip compression library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1572969



--- Comment #5 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/zipper

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1572969] Review Request: zipper - C++ wrapper around minizip compression library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1572969

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|NEW |POST
   Assignee|nob...@fedoraproject.org|zebo...@gmail.com
  Flags||fedora-review+



--- Comment #4 from Robert-André Mauchin  ---
Package approved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1572969] Review Request: zipper - C++ wrapper around minizip compression library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1572969



--- Comment #3 from Antonio Trande  ---
> - Is it not possible to unbundle minizip?

No, i guess.

Spec URL:
https://copr-be.cloud.fedoraproject.org/results/sagitter/ForTesting/fedora-rawhide-x86_64/00747092-zipper/zipper.spec

SRPM URL: 
https://copr-be.cloud.fedoraproject.org/results/sagitter/ForTesting/fedora-rawhide-x86_64/00747092-zipper/zipper-0.9.1-2.20170831giteee877a.fc29.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1572969] Review Request: zipper - C++ wrapper around minizip compression library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1572969

Robert-André Mauchin  changed:

   What|Removed |Added

 CC||zebo...@gmail.com



--- Comment #2 from Robert-André Mauchin  ---
 - Is it not possible to unbundle minizip?

 - Some parts are GPL:

GPL
---
zipper/minizip/aes/fileenc.c
zipper/minizip/aes/fileenc.h
zipper/minizip/aes/hmac.c
zipper/minizip/aes/hmac.h
zipper/minizip/aes/prng.c
zipper/minizip/aes/prng.h
zipper/minizip/aes/pwd2key.c
zipper/minizip/aes/pwd2key.h
zipper/minizip/aes/sha1.c
zipper/minizip/aes/sha1.h

   Add it to License and add a comment explaining the breakdown of licenses

 - If bundled, the minizip version should be specified:

zipper.src:23: W: unversioned-explicit-provides bundled(minizip)



Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[!]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "MIT/X11 (BSD like)", "GPL", "Unknown or generated", "BSD (3
 clause)". 64 files have unknown license. Detailed output of
 licensecheck in /home/bob/packaging/review/zipper/review-
 zipper/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[!]: If the package is under multiple licenses, the licensing breakdown
 must be documented in the spec.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[x]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 10240 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: Static libraries in -static or -devel subpackage, providing -devel if
 present.
 Note: Package has .a files: zipper-static.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under 

[Bug 1572969] Review Request: zipper - C++ wrapper around minizip compression library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1572969

Antonio Trande  changed:

   What|Removed |Added

 Blocks||1572970




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1572970
[Bug 1572970] Review Request: libCombine - 
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1572969] Review Request: zipper - C++ wrapper around minizip compression library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1572969



--- Comment #1 from Antonio Trande  ---
Spec URL:
http://copr-dist-git.fedorainfracloud.org/cgit/sagitter/ForTesting/zipper.git/plain/zipper.spec
SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/sagitter/ForTesting/fedora-rawhide-x86_64/00746848-zipper/zipper-0.9.1-1.20170831giteee877a.fc29.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org