[Bug 1748471] Review Request: xtensor-python - Python bindings for xtensor
https://bugzilla.redhat.com/show_bug.cgi?id=1748471 Miro Hrončok changed: What|Removed |Added Status|POST|CLOSED Fixed In Version||xtensor-python-0.23.1-0.fc3 ||2 Resolution|--- |RAWHIDE Last Closed||2019-09-17 11:14:55 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1748471] Review Request: xtensor-python - Python bindings for xtensor
https://bugzilla.redhat.com/show_bug.cgi?id=1748471 --- Comment #12 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/xtensor-python -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1748471] Review Request: xtensor-python - Python bindings for xtensor
https://bugzilla.redhat.com/show_bug.cgi?id=1748471 --- Comment #11 from serge_sans_paille --- :-) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1748471] Review Request: xtensor-python - Python bindings for xtensor
https://bugzilla.redhat.com/show_bug.cgi?id=1748471
Miro Hrončok changed:
What|Removed |Added
Status|NEW |POST
Assignee|nob...@fedoraproject.org|mhron...@redhat.com
Flags||fedora-review+
--- Comment #9 from Miro Hrončok ---
Package Review
==
_ _ ___ __ __ _
/\ | __ \| __ \| __ \ \/ / __ \| | __ \
/ \ | |__) | |__) | |__) \ \ / / | | | |__ | | | |
/ /\ \ | ___/| ___/| _ / \ \/ /| | | | __| | | | |
/ \| || || | \ \ \ / | |__| | || |__| |
/_/\_\_||_||_| \_\ \/ \/|__|_/
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: If your application is a C or C++ application you must list a
BuildRequires against gcc, gcc-c++ or clang.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: BSD file in source RPM, not shipped in built one.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[?]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[?]: Package should compile and build into binary rpms on all supported
architectures.
[x]:
[Bug 1748471] Review Request: xtensor-python - Python bindings for xtensor
https://bugzilla.redhat.com/show_bug.cgi?id=1748471 --- Comment #8 from serge_sans_paille --- Thanks again for the review, I indeed forgot a large part of the spec file, everything got re-uploaded again. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1748471] Review Request: xtensor-python - Python bindings for xtensor
https://bugzilla.redhat.com/show_bug.cgi?id=1748471 --- Comment #7 from Miro Hrončok --- Changelog doesn't match release (and a release is zero). --- A note: xtensor-python-0.23.1/cmake/FindNumPy.cmake is MIT but is not shipped in the built RPM (OK). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1748471] Review Request: xtensor-python - Python bindings for xtensor
https://bugzilla.redhat.com/show_bug.cgi?id=1748471
--- Comment #6 from Miro Hrončok ---
This is a header only library.
See
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_packaging_header_only_libraries
%package devel
Summary:%{summary}
Provides: %{name} = %{version}-%{release}
Provides: %{name}-static = %{version}-%{release}
Requires: pybind11-devel
Requires: python3-devel
Requires: xtensor-devel
Requires: python3-numpy
%description devel %_description
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1748471] Review Request: xtensor-python - Python bindings for xtensor
https://bugzilla.redhat.com/show_bug.cgi?id=1748471 --- Comment #5 from serge_sans_paille --- My fault, fixed and uploaded, https://sergesanspaille.fedorapeople.org/xtensor-python.spec https://sergesanspaille.fedorapeople.org/xtensor-python-0.23.1-0.fc32.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1748471] Review Request: xtensor-python - Python bindings for xtensor
https://bugzilla.redhat.com/show_bug.cgi?id=1748471
--- Comment #4 from Miro Hrončok ---
I cannot build the package:
Processing files: xtensor-python-debugsource-0.23.1-0.fc32.x86_64
RPM build errors:
error: Empty %files file
/builddir/build/BUILD/xtensor-python-0.23.1/debugsourcefiles.list
I think it requires:
# there is no actual arched content - this is a header only library
%global debug_package %{nil}
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1748471] Review Request: xtensor-python - Python bindings for xtensor
https://bugzilla.redhat.com/show_bug.cgi?id=1748471 --- Comment #3 from serge_sans_paille --- @Elliott: spec file description + URL updated as suggested And I second Miro, this is not a Python package, it's a header-only C++ package. New SRPM URL: SRPM URL: https://sergesanspaille.fedorapeople.org/xtensor-python-0.23.1-0.fc32.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1748471] Review Request: xtensor-python - Python bindings for xtensor
https://bugzilla.redhat.com/show_bug.cgi?id=1748471 --- Comment #2 from Miro Hrončok --- Note that this is not a Python package. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1748471] Review Request: xtensor-python - Python bindings for xtensor
https://bugzilla.redhat.com/show_bug.cgi?id=1748471 Elliott Sales de Andrade changed: What|Removed |Added CC||quantum.anal...@gmail.com --- Comment #1 from Elliott Sales de Andrade --- Python packages MUST be named python-*, and since this one ends in -python too, you probably will want to name it python-xtensor. URL should be https:// In the description, STL-compliant should not have spaces, and it should be capitalized as NumPy. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1748471] Review Request: xtensor-python - Python bindings for xtensor
https://bugzilla.redhat.com/show_bug.cgi?id=1748471 Bug 1748471 depends on bug 1748470, which changed state. Bug 1748470 Summary: Review Request: xtensor - C++ tensors with broadcasting and lazy computing https://bugzilla.redhat.com/show_bug.cgi?id=1748470 What|Removed |Added Status|POST|CLOSED Resolution|--- |RAWHIDE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1748471] Review Request: xtensor-python - Python bindings for xtensor
https://bugzilla.redhat.com/show_bug.cgi?id=1748471 serge_sans_paille changed: What|Removed |Added Summary|xtensor-python - Python |Review Request: |bindings for xtensor|xtensor-python - Python ||bindings for xtensor -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
