[Bug 1796401] Review Request: python-requre - REQuest REcording your python code
https://bugzilla.redhat.com/show_bug.cgi?id=1796401 Jan Ščotka changed: What|Removed |Added Status|POST|CLOSED Resolution|--- |NEXTRELEASE Last Closed||2020-09-22 09:13:27 --- Comment #12 from Jan Ščotka --- already added to fedora: https://bodhi.fedoraproject.org/updates/?search=python-requre -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1796401] Review Request: python-requre - REQuest REcording your python code
https://bugzilla.redhat.com/show_bug.cgi?id=1796401 Jan Ščotka changed: What|Removed |Added Flags|needinfo?(jsco...@redhat.co | |m) | --- Comment #11 from Jan Ščotka --- Hi, I'll do it as soon as possible, to finish this BZ. Thanks for reminder Honza -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1796401] Review Request: python-requre - REQuest REcording your python code
https://bugzilla.redhat.com/show_bug.cgi?id=1796401 Fabian Affolter changed: What|Removed |Added Flags||needinfo?(jsco...@redhat.co ||m) --- Comment #10 from Fabian Affolter --- This package was never build. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1796401] Review Request: python-requre - REQuest REcording your python code
https://bugzilla.redhat.com/show_bug.cgi?id=1796401 --- Comment #9 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python-requre -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1796401] Review Request: python-requre - REQuest REcording your python code
https://bugzilla.redhat.com/show_bug.cgi?id=1796401 Robert-André Mauchin changed: What|Removed |Added Status|NEW |POST Assignee|nob...@fedoraproject.org|zebo...@gmail.com Flags||fedora-review+ --- Comment #8 from Robert-André Mauchin --- Package approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1796401] Review Request: python-requre - REQuest REcording your python code
https://bugzilla.redhat.com/show_bug.cgi?id=1796401 --- Comment #7 from Jan Ščotka --- I hope I've fixed mentioned issues, here is are new info, and hope that is is no problem that it is not merged to master from PR: https://github.com/packit-service/requre/pull/93 Spec URL: https://raw.githubusercontent.com/jscotka/requre/packaging3/python-requre.spec SRPM URL: https://fedorapeople.org/~jscotka/python-requre-0.2.4-1.fc31.src.rpm Description: REQUest REcordingRequre [rekure] - Is Library for storing output of various function and methods to persistent storage and be able to replay the stored output to functions. Thanks for help. Regards Honza -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1796401] Review Request: python-requre - REQuest REcording your python code
https://bugzilla.redhat.com/show_bug.cgi?id=1796401
Robert-André Mauchin changed:
What|Removed |Added
CC||zebo...@gmail.com
--- Comment #6 from Robert-André Mauchin ---
- %description should end with a period and summaries should start with a
capital
- several tests fail, probably because they need a network connection:
tests/test_request_response.py::StoreAnyRequest::testExecuteWrapper FAILED [
50%]
tests/test_request_response.py::StoreAnyRequest::testFunctionCustomFields
FAILED [ 51%]
tests/test_request_response.py::StoreAnyRequest::testFunctionCustomFieldsWrong
FAILED [ 52%]
tests/test_request_response.py::StoreAnyRequest::testFunctionDecorator FAILED [
53%]
tests/test_request_response.py::StoreAnyRequest::testFunctionDecoratorNotFound
PASSED [ 53%]
tests/test_request_response.py::StoreAnyRequest::testRawCall FAILED [ 54%]
Try disabling them:
%check
PYTHONPATH=$PWD PYTHONDONTWRITEBYTECODE=1 %{__python3} -m pytest --verbose
--showlocals -k "not testExecuteWrapper and not testFunctionCustomFields and
not testFunctionCustomFieldsWrong and not testFunctionDecorator and not
testFunctionDecoratorNotFound and not testRawCall" ./tests
- Remove shebang in prep for:
python3-requre.noarch: E: non-executable-script
/usr/lib/python3.8/site-packages/requre/requre_patch.py 644 /usr/bin/python3
- The summary must not exceed 80 characters:
python3-requre.noarch: E: summary-too-long C Library for testing python code
what allows store output of various objects and use stored data for testing
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated", "Expat License". 67 files have unknown
license. Detailed output of licensecheck in
/home/bob/packaging/review/python-requre/review-python-
requre/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt
[Bug 1796401] Review Request: python-requre - REQuest REcording your python code
https://bugzilla.redhat.com/show_bug.cgi?id=1796401 --- Comment #5 from Fabian Affolter --- (In reply to Fabian Affolter from comment #1) > - The URL for the spec file should point to a location where the raw file is > present. This is still not the case. fedora-review requires a plain text SPEC file. - %description should end with a period. - There are rpmlint issues $ rpmlint python-requre-0.2.4-1.fc31.src.rpm python-requre.src: E: summary-too-long C Library for testing python code what allows store output of various objects and use stored data for testing python-requre.src: W: spelling-error %description -l en_US rekure -> reek python-requre.src: W: file-size-mismatch requre-0.2.4.tar.gz = 44461, https://files.pythonhosted.org/packages/source/r/requre/requre-0.2.4.tar.gz = 45681 1 packages and 0 specfiles checked; 1 errors, 2 warnings. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1796401] Review Request: python-requre - REQuest REcording your python code
https://bugzilla.redhat.com/show_bug.cgi?id=1796401 --- Comment #4 from Jan Ščotka --- Spec URL: https://github.com/packit-service/requre/blob/0.2.4/python-requre.spec SRPM URL: https://fedorapeople.org/~jscotka/python-requre-0.2.4-1.fc31.src.rpm Description: REQUest REcordingRequre [rekure] - Is Library for storing output of various function and methods to persistent storage and be able to replay the stored output to functions Thanks for help. Regards Honza -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1796401] Review Request: python-requre - REQuest REcording your python code
https://bugzilla.redhat.com/show_bug.cgi?id=1796401
--- Comment #3 from Fabian Affolter ---
%{python3_sitelib}/%{pypi_name}
%{python3_sitelib}/%{pypi_name}-%{version}-py%{python3_version}.egg-info
with
%{python3_sitelib}/%{pypi_name}/
%{python3_sitelib}/%{pypi_name}-%{version}-py%{python3_version}.egg-info/
Additional details:
https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_reviewer_checklist
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1796401] Review Request: python-requre - REQuest REcording your python code
https://bugzilla.redhat.com/show_bug.cgi?id=1796401 --- Comment #2 from Jan Ščotka --- Hi, could you please help me to adjust ownership in %files section. I have no idea, how to adjust it. I've generated packages via pypi2rpm, and have no experiences with this part of specfile. I've read specfile instructions to improve it, but I did not find anything useful what's bad there. Thanks Honza -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1796401] Review Request: python-requre - REQuest REcording your python code
https://bugzilla.redhat.com/show_bug.cgi?id=1796401
Fabian Affolter changed:
What|Removed |Added
CC||m...@fabian-affolter.ch
--- Comment #1 from Fabian Affolter ---
Just some comments to get the review started:
- The spec file is not for the latest upstream release.
- The URL for the spec file should point to a location where the raw file is
present.
- Source0: could be replaced with %{pypi_source}
- The markdown formatting should be removed from the description. Also,
%description should end with a period.
- The tarball contains tests but the %check section is missing.
- The ownership in %files should be adjusted.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1796401] Review Request: python-requre - REQuest REcording your python code
https://bugzilla.redhat.com/show_bug.cgi?id=1796401 Jan Ščotka changed: What|Removed |Added Summary|Review Request: requre -|Review Request: |REQuest REcording your |python-requre - REQuest |python code |REcording your python code -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
