[Bug 1797362] Review Request: chordpro - Typesetting ChordPro songbooks (lyrics + chords)
https://bugzilla.redhat.com/show_bug.cgi?id=1797362 Elliott Sales de Andrade changed: What|Removed |Added Status|POST|CLOSED Fixed In Version||chordpro-0.974.1-5.fc33 Resolution|--- |RAWHIDE Last Closed||2020-08-03 00:28:18 --- Comment #12 from Elliott Sales de Andrade --- Please close your Review Requests when they are complete. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1797362] Review Request: chordpro - Typesetting ChordPro songbooks (lyrics + chords)
https://bugzilla.redhat.com/show_bug.cgi?id=1797362 Bug 1797362 depends on bug 1797367, which changed state. Bug 1797367 Summary: Review Request: perl-File-LoadLines - Loads the contents of a text file into an array of lines https://bugzilla.redhat.com/show_bug.cgi?id=1797367 What|Removed |Added Status|MODIFIED|CLOSED Resolution|--- |ERRATA -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1797362] Review Request: chordpro - Typesetting ChordPro songbooks (lyrics + chords)
https://bugzilla.redhat.com/show_bug.cgi?id=1797362 --- Comment #11 from Robert-André Mauchin --- If it has the same functionalities, I think you can Obsoletes/Provides it. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1797362] Review Request: chordpro - Typesetting ChordPro songbooks (lyrics + chords)
https://bugzilla.redhat.com/show_bug.cgi?id=1797362 --- Comment #10 from Johan Vromans --- Thanks for the approval. I still have a question about this package being successor to the chordii package. I am also maintainer of the chordii program and package and I want to deprecate it. Should I just add Obsoletes:chordii to the chordpro spec file? Should I add Provides:chordii even though it is not a plug compatible replacement? It is a full functional replacement. AFAICS this would be consistent with the discussion https://pagure.io/packaging-committee/issue/645 and the packaging guidelines. Apologies if this is not the right place to ask. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1797362] Review Request: chordpro - Typesetting ChordPro songbooks (lyrics + chords)
https://bugzilla.redhat.com/show_bug.cgi?id=1797362 --- Comment #9 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/chordpro -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1797362] Review Request: chordpro - Typesetting ChordPro songbooks (lyrics + chords)
https://bugzilla.redhat.com/show_bug.cgi?id=1797362 Robert-André Mauchin changed: What|Removed |Added Status|NEW |POST Assignee|nob...@fedoraproject.org|zebo...@gmail.com Flags||fedora-review+ --- Comment #8 from Robert-André Mauchin --- Package approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1797362] Review Request: chordpro - Typesetting ChordPro songbooks (lyrics + chords)
https://bugzilla.redhat.com/show_bug.cgi?id=1797362 --- Comment #7 from Johan Vromans --- Thanks for your feedback. I've added perl(Hash::Util) to the build dependencies. The testing problems did not show up on my f31 system. Other issues: [!]: License field in the package spec file matches the actual license. => License changed to Artistic 2.0 to match the README. [!]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. => I've asked upstream to license under GPL + Artistic and provide a LICENSE file. New files: Spec URL: https://www.chordpro.org/fedora/chordpro.spec SRPM URL: https://www.chordpro.org/fedora/chordpro-0.974.1-5.fc33.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1797362] Review Request: chordpro - Typesetting ChordPro songbooks (lyrics + chords)
https://bugzilla.redhat.com/show_bug.cgi?id=1797362
--- Comment #6 from Robert-André Mauchin ---
- According to the README, the license is Artistic License 2.0;
License: Artistic 2.0
Still ask upstream for a separate LICENSE file.
- Several tests fail:
+ make test
PERL_DL_NONLAZY=1 "/usr/bin/perl" "-MExtUtils::Command::MM" "-MTest::Harness"
"-e" "undef *Test::Harness::Switches; test_harness(0, 'blib/lib', 'blib/arch')"
t/*.t
# Using PDF::API2 for PDF generation
t/01_prereq.t . ok
# Testing App::Music::ChordPro 0.974.1, Perl 5.030002, /usr/bin/perl
t/02_load.t ... ok
t/100_basic.t . ok
t/101_empty.t . ok
t/102_new_song.t .. ok
t/103_title.t . ok
t/104_subtitles.t . ok
# Failed test 'got config'
# at t/105_chords.t line 50.
# Looks like you failed 1 test of 321.
t/105_chords.t
Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/321 subtests
# Failed test 'got config'
# at t/107_chords_latin.t line 102.
# Looks like you failed 1 test of 321.
t/107_chords_latin.t ..
Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/321 subtests
# Failed test 'got config'
# at t/108_chords_solfege.t line 102.
# Looks like you failed 1 test of 321.
t/108_chords_solfege.t
Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/321 subtests
t/109_chords_nashville.t .. ok
t/110_chords_roman.t .. ok
t/112_comment.t ... ok
t/113_comment.t ... ok
t/114_songline.t .. ok
t/115_songline.t .. ok
t/116_chorus.t ok
t/117_rechorus.t .. ok
t/118_tab.t ... ok
t/119_verse.t . ok
t/120_meta.t .. ok
t/122_memorize.t .. ok
t/130_image.t . ok
t/131_image.t . ok
t/140_chords.t ok
t/141_chords.t ok
t/142_chords.t ok
t/150_fonts.t . ok
t/151_fonts.t . ok
t/15_subst.t .. ok
t/160_diagrams.t .. ok
t/161_titles.t ok
t/162_newpage.t ... ok
t/163_columns.t ... ok
t/164_pagesize.t .. ok
t/169_custom.t ok
t/170_transpose.t . ok
t/171_transpose.t . ok
t/172_transpose.t . ok
t/173_transpose.t . ok
Can't locate Hash/Util.pm in @INC (you may need to install the Hash::Util
module) (@INC contains:
/builddir/build/BUILD/App-Music-ChordPro-0.974.1/blib/lib
/builddir/build/BUILD/App-Music-ChordPro-0.974.1/blib/arch
/usr/local/lib64/perl5/5.30 /usr/local/share/perl5/5.30
/usr/lib64/perl5/vendor_perl /usr/share/perl5/vendor_perl /usr/lib64/perl5
/usr/share/perl5 .) at
/builddir/build/BUILD/App-Music-ChordPro-0.974.1/blib/lib/App/Music/ChordPro/Config.pm
line 604.
Compilation failed in require at t/174_transpose.t line 12.
t/174_transpose.t .
Dubious, test returned 2 (wstat 512, 0x200)
No subtests run
t/175_transpose.t . ok
# Failed test 'got config'
# at t/177_transcode.t line 25.
Use of uninitialized value $t in substitution (s///) at
/builddir/build/BUILD/App-Music-ChordPro-0.974.1/blib/lib/App/Music/ChordPro/Songbook.pm
line 1090.
Use of uninitialized value $t in substitution (s///) at
/builddir/build/BUILD/App-Music-ChordPro-0.974.1/blib/lib/App/Music/ChordPro/Songbook.pm
line 1091.
Use of uninitialized value $t in substitution (s///) at
/builddir/build/BUILD/App-Music-ChordPro-0.974.1/blib/lib/App/Music/ChordPro/Songbook.pm
line 1092.
Use of uninitialized value $t in substitution (s///) at
/builddir/build/BUILD/App-Music-ChordPro-0.974.1/blib/lib/App/Music/ChordPro/Songbook.pm
line 1093.
Use of uninitialized value $t in substitution (s///) at
/builddir/build/BUILD/App-Music-ChordPro-0.974.1/blib/lib/App/Music/ChordPro/Songbook.pm
line 1094.
Use of uninitialized value $t in substitution (s///) at
/builddir/build/BUILD/App-Music-ChordPro-0.974.1/blib/lib/App/Music/ChordPro/Songbook.pm
line 1095.
Use of uninitialized value in concatenation (.) or string at
/builddir/build/BUILD/App-Music-ChordPro-0.974.1/blib/lib/App/Music/ChordPro/Songbook.pm
line 1100.
Use of uninitialized value $diagrams in pattern match (m//) at
/builddir/build/BUILD/App-Music-ChordPro-0.974.1/blib/lib/App/Music/ChordPro/Songbook.pm
line 234.
Use of uninitialized value $diagrams in pattern match (m//) at
/builddir/build/BUILD/App-Music-ChordPro-0.974.1/blib/lib/App/Music/ChordPro/Songbook.pm
line 242.
# Failed test 'Song contents'
# at t/177_transcode.t line 80.
# Structures begin differing at:
# $got->{chords} = Does not exist
# $expected->{chords} = HASH(0x55ea19dc1610)
# Looks like you failed 2 tests of 4.
t/177_transcode.t .
Dubious, test returned 2 (wstat 512, 0x200)
Failed 2/4 subtests
t/180_grids.t . ok
Can't locate Hash/Util.pm in @INC (you may need to install the Hash::Util
module) (@INC contains:
/builddir/build/BUILD/App-Music-ChordPro-0.974.1/blib/lib
/builddir/build/BUILD/App-Music-ChordPro-0.974.1/blib/arch
[Bug 1797362] Review Request: chordpro - Typesetting ChordPro songbooks (lyrics + chords)
https://bugzilla.redhat.com/show_bug.cgi?id=1797362 --- Comment #5 from Johan Vromans --- Thanks for your feedback. Your comments have been addressed. Spec URL: https://www.chordpro.org/fedora/chordpro.spec SRPM URL: https://www.chordpro.org/fedora/chordpro-0.974.1-4.fc31.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1797362] Review Request: chordpro - Typesetting ChordPro songbooks (lyrics + chords)
https://bugzilla.redhat.com/show_bug.cgi?id=1797362
Robert-André Mauchin changed:
What|Removed |Added
CC||zebo...@gmail.com
--- Comment #4 from Robert-André Mauchin ---
- Source is 404 Source:
https://cpan.metacpan.org/authors/id/J/JV/JV/%{FullName}-%{version}.tar.gz
Seems the latest version published is Version: 0.974
- Group: is not used in Fedora
- Don't use macro starting with __, they are for private rpm use only
%{__mkdir_p} → mkdir -p
- Separate your changelog entries with a new line
- Don't mix $RPM_BUILD_ROOT and %{buildroot}, use only one
- Provide a LICENSE file if you're upstream
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1797362] Review Request: chordpro - Typesetting ChordPro songbooks (lyrics + chords)
https://bugzilla.redhat.com/show_bug.cgi?id=1797362 Bug 1797362 depends on bug 1797364, which changed state. Bug 1797364 Summary: Review Request: perl-HarfBuzz-Shaper - Access to a small subset of the native HarfBuzz library https://bugzilla.redhat.com/show_bug.cgi?id=1797364 What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1797362] Review Request: chordpro - Typesetting ChordPro songbooks (lyrics + chords)
https://bugzilla.redhat.com/show_bug.cgi?id=1797362 Bug 1797362 depends on bug 1797365, which changed state. Bug 1797365 Summary: Review Request: perl-App-Packager - Abstract interface to a number of common packagers https://bugzilla.redhat.com/show_bug.cgi?id=1797365 What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1797362] Review Request: chordpro - Typesetting ChordPro songbooks (lyrics + chords)
https://bugzilla.redhat.com/show_bug.cgi?id=1797362 Bug 1797362 depends on bug 1797363, which changed state. Bug 1797363 Summary: Review Request: perl-Text-Layout - Pango style text formatting https://bugzilla.redhat.com/show_bug.cgi?id=1797363 What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1797362] Review Request: chordpro - Typesetting ChordPro songbooks (lyrics + chords)
https://bugzilla.redhat.com/show_bug.cgi?id=1797362 Bug 1797362 depends on bug 1797368, which changed state. Bug 1797368 Summary: Review Request: perl-String-Interpolate-Named - Interpolate named variables in text strings https://bugzilla.redhat.com/show_bug.cgi?id=1797368 What|Removed |Added Status|MODIFIED|CLOSED Resolution|--- |ERRATA -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1797362] Review Request: chordpro - Typesetting ChordPro songbooks (lyrics + chords)
https://bugzilla.redhat.com/show_bug.cgi?id=1797362 --- Comment #3 from Johan Vromans --- Spec URL: https://www.chordpro.org/fedora/chordpro.spec SRPM URL: https://www.chordpro.org/fedora/chordpro-0.975-4.fc31.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1797362] Review Request: chordpro - Typesetting ChordPro songbooks (lyrics + chords)
https://bugzilla.redhat.com/show_bug.cgi?id=1797362 --- Comment #2 from Johan Vromans --- Spec URL: https://www.chordpro.org/fedora/chordpro.spec SRPM URL: https://www.chordpro.org/fedora/chordpro-0.974-3.fc31.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1797362] Review Request: chordpro - Typesetting ChordPro songbooks (lyrics + chords)
https://bugzilla.redhat.com/show_bug.cgi?id=1797362 --- Comment #1 from Johan Vromans --- Spec URL: https://www.chordpro.org/fedora/chordpro.spec SRPM URL: https://www.chordpro.org/fedora/chordpro-0.974-2.fc31.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1797362] Review Request: chordpro - Typesetting ChordPro songbooks (lyrics + chords)
https://bugzilla.redhat.com/show_bug.cgi?id=1797362 Elliott Sales de Andrade changed: What|Removed |Added CC||quantum.anal...@gmail.com Depends On||1797365, 1797368, 1797367, ||1797363, 1797364 Doc Type|--- |If docs needed, set a value Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1797363 [Bug 1797363] Review Request: perl-Text-Layout - Pango style text formatting https://bugzilla.redhat.com/show_bug.cgi?id=1797364 [Bug 1797364] Review Request: perl-harfBuzz-Shaper - Interface to harfbuzz library https://bugzilla.redhat.com/show_bug.cgi?id=1797365 [Bug 1797365] Review Request: perl-App-Packager - abstract interface to a number of common packagers https://bugzilla.redhat.com/show_bug.cgi?id=1797367 [Bug 1797367] Review Request: perl-File-LoadLines - Read text files into lines array https://bugzilla.redhat.com/show_bug.cgi?id=1797368 [Bug 1797368] Review Request: perl-String-Interpolate-Named - Interpolate named variables in text strings -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
