[Bug 1801533] Review Request: memstrack - a memory allocation analyzer
https://bugzilla.redhat.com/show_bug.cgi?id=1801533 Kairui Song changed: What|Removed |Added Status|NEW |CLOSED Resolution|--- |NEXTRELEASE Last Closed||2020-03-16 05:54:24 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1801533] Review Request: memstrack - a memory allocation analyzer
https://bugzilla.redhat.com/show_bug.cgi?id=1801533 --- Comment #8 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/memstrack -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1801533] Review Request: memstrack - a memory allocation analyzer
https://bugzilla.redhat.com/show_bug.cgi?id=1801533 Attila Lakatos changed: What|Removed |Added Flags||fedora-review+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1801533] Review Request: memstrack - a memory allocation analyzer
https://bugzilla.redhat.com/show_bug.cgi?id=1801533 Kairui Song changed: What|Removed |Added Flags|needinfo?(kas...@redhat.com | |) | |needinfo?(kas...@redhat.com | |) | --- Comment #7 from Kairui Song --- Hi, I've updated the spec and srpm: Spec URL: https://gist.githubusercontent.com/ryncsn/ed41a2d265ce6c897b1d87212a7a1754/raw/ad4cc43dc00840c75f63df969f083fe89c150119/memstrack.spec SRPM URL: https://kojipkgs.fedoraproject.org//work/tasks/1518/42111518/memstrack-0-1.20200303git2afaabc.fc33.src.rpm Koji Build: https://koji.fedoraproject.org/koji/taskinfo?taskID=42111517 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1801533] Review Request: memstrack - a memory allocation analyzer
https://bugzilla.redhat.com/show_bug.cgi?id=1801533
Attila Lakatos changed:
What|Removed |Added
Flags||needinfo?(kas...@redhat.com
||)
--- Comment #6 from Attila Lakatos ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: If your application is a C or C++ application you must list a
BuildRequires against gcc, gcc-c++ or clang.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[?]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "GPL (v3 or later)", "Unknown or generated". 28 files have
unknown license. Detailed output of licensecheck in
/home/alakatos/Desktop/memstrack-review/review-
memstrack/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package requires other packages for directories it uses.
Note: No known owner of /usr/lib/dracut/module.d
[!]: Package must own all directories that it creates.
Note: Directories without known owners: /usr/lib/dracut/module.d
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[x]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Fully versioned dependency in subpackages if applicable.
Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
memstrack-dracut
Would it be benefitial to specify the base package?
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_requiring_base_package
[x]: Package functions
[Bug 1801533] Review Request: memstrack - a memory allocation analyzer
https://bugzilla.redhat.com/show_bug.cgi?id=1801533 Attila Lakatos changed: What|Removed |Added Assignee|nob...@fedoraproject.org|alaka...@redhat.com -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1801533] Review Request: memstrack - a memory allocation analyzer
https://bugzilla.redhat.com/show_bug.cgi?id=1801533
--- Comment #5 from Kairui Song ---
(In reply to Attila Lakatos from comment #4)
> 1. It is not a MUST thing but you should consider to add a man page for
> memstrack binary file. If you do not have one, work with upstream to add one
> where it makes sense. However, it's only up to you.
Thanks, I'll consider it in the furture, and there is a README should have a
brief introduction to the tool and the TUI is already inteactive and provide
basic usage info.
>
> > install -p -m 644 misc/99memstrack/module-setup.sh
> > %{buildroot}/%{dracutmoduledir}/module-setup.sh
> 2. memstrack.spec:49: Are you sure that you want to set the file permissions
> to 644? In that case it creates a non-executable script.
That's right, that's a dracut module which don't need execution permission.
>
> 3. No owner of /usr/lib/dracut/module.d
> Your package should own all of the files that are installed as part of the
> %install process.
Good catch, will fix it. That's a malformed dracut module path, this package
don't own it, so I should just install files under it and dont touch the dir
itself, and add dependency on dracut to ensure it exists.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1801533] Review Request: memstrack - a memory allocation analyzer
https://bugzilla.redhat.com/show_bug.cgi?id=1801533
Attila Lakatos changed:
What|Removed |Added
CC||alaka...@redhat.com
Flags||needinfo?(kas...@redhat.com
||)
--- Comment #4 from Attila Lakatos ---
1. It is not a MUST thing but you should consider to add a man page for
memstrack binary file. If you do not have one, work with upstream to add one
where it makes sense. However, it's only up to you.
> install -p -m 644 misc/99memstrack/module-setup.sh
> %{buildroot}/%{dracutmoduledir}/module-setup.sh
2. memstrack.spec:49: Are you sure that you want to set the file permissions to
644? In that case it creates a non-executable script.
3. No owner of /usr/lib/dracut/module.d
Your package should own all of the files that are installed as part of the
%install process.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1801533] Review Request: memstrack - a memory allocation analyzer
https://bugzilla.redhat.com/show_bug.cgi?id=1801533
--- Comment #3 from Kairui Song ---
Hi, I've updated the spec and srpm:
Spec URL:
https://gist.githubusercontent.com/ryncsn/ed41a2d265ce6c897b1d87212a7a1754/raw/ca1bdfed3a7f771eb2e4239afb464ee23997d5db/memstrack.spec
SRPM URL:
https://kojipkgs.fedoraproject.org//work/tasks/3457/41613457/memstrack-0-1.20200218git9aefb50.fc33.src.rpm
Koji Build: https://koji.fedoraproject.org/koji/taskinfo?taskID=41613456
rpmlint result:
memstrack.src:44: E: hardcoded-library-path in %{_prefix}/lib/dracut
1 packages and 0 specfiles checked; 1 errors, 0 warnings.
The hardcoded-library-path is to keep the macro definition consistent with the
one in dracut.spec (dracut package), and also avoids noarch build error.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1801533] Review Request: memstrack - a memory allocation analyzer
https://bugzilla.redhat.com/show_bug.cgi?id=1801533
--- Comment #2 from Kairui Song ---
(In reply to Artur Iwicki from comment #1)
Thank you very much for the review.
> >Spec URL: https://gist.github.com/ryncsn/ed41a2d265ce6c897b1d87212a7a1754
> This points to an HTML web-view of the file; please use "raw file" links.
OK, will fix that.
>
> >Group: Applications/System
> The Group: tag is not used in Fedora.
> https://docs.fedoraproject.org/en-US/packaging-guidelines/#_tags_and_sections
>
> >%package dracut-memstrack
> This will create a "memstack-dracut-memstack" package. Is this what you
> wanted? If you want just "dracut-memstack", you should use "%package -n".
It should be a memstrack-dracut sub package, so I'll change it to "%package
dracut"
>
> >%build
> >make
> You should use %set_build_flags before the make invocation in order to use
> Fedora's CFLAGS.
>
> >%files
> >%{_bindir}/memstrack
> >%files dracut-memstrack
> >%{dracutmoduledir}/module-setup.sh
> >%{dracutmoduledir}/start-tracing.sh
> >%{dracutmoduledir}/stop-tracing.sh
> >%doc
> 1. Please put an empty line between the main package's %files and the
> subpackages' list.
> 2. You must include the licence text.
> https://docs.fedoraproject.org/en-US/packaging-guidelines/
> LicensingGuidelines/#_license_text
> 3. The list does not include the module directory itself - RPM will complain
> that the directory is unowned.
> 4. If %doc is going to be empty, you can just remove it.
Good suggestions, will fix it.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1801533] Review Request: memstrack - a memory allocation analyzer
https://bugzilla.redhat.com/show_bug.cgi?id=1801533
Artur Iwicki changed:
What|Removed |Added
CC||fed...@svgames.pl
--- Comment #1 from Artur Iwicki ---
>Spec URL: https://gist.github.com/ryncsn/ed41a2d265ce6c897b1d87212a7a1754
This points to an HTML web-view of the file; please use "raw file" links.
>Group: Applications/System
The Group: tag is not used in Fedora.
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_tags_and_sections
>%package dracut-memstrack
This will create a "memstack-dracut-memstack" package. Is this what you wanted?
If you want just "dracut-memstack", you should use "%package -n".
>%build
>make
You should use %set_build_flags before the make invocation in order to use
Fedora's CFLAGS.
>%files
>%{_bindir}/memstrack
>%files dracut-memstrack
>%{dracutmoduledir}/module-setup.sh
>%{dracutmoduledir}/start-tracing.sh
>%{dracutmoduledir}/stop-tracing.sh
>%doc
1. Please put an empty line between the main package's %files and the
subpackages' list.
2. You must include the licence text.
https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#_license_text
3. The list does not include the module directory itself - RPM will complain
that the directory is unowned.
4. If %doc is going to be empty, you can just remove it.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
