[Bug 1810820] Review Request: quaternion - A Qt5-based IM client for Matrix
https://bugzilla.redhat.com/show_bug.cgi?id=1810820 Brendan Early changed: What|Removed |Added Status|POST|CLOSED Resolution|--- |ERRATA Last Closed||2020-04-05 16:33:04 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1810820] Review Request: quaternion - A Qt5-based IM client for Matrix
https://bugzilla.redhat.com/show_bug.cgi?id=1810820 Bug 1810820 depends on bug 1810819, which changed state. Bug 1810819 Summary: Review Request: libqmatrixclient - Qt5 library to write cross-platform clients for Matrix https://bugzilla.redhat.com/show_bug.cgi?id=1810819 What|Removed |Added Status|POST|CLOSED Resolution|--- |ERRATA -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1810820] Review Request: quaternion - A Qt5-based IM client for Matrix
https://bugzilla.redhat.com/show_bug.cgi?id=1810820 --- Comment #5 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/quaternion -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1810820] Review Request: quaternion - A Qt5-based IM client for Matrix
https://bugzilla.redhat.com/show_bug.cgi?id=1810820 Robert-André Mauchin changed: What|Removed |Added Status|NEW |POST Assignee|nob...@fedoraproject.org|zebo...@gmail.com Flags||fedora-review+ --- Comment #4 from Robert-André Mauchin --- Package approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1810820] Review Request: quaternion - A Qt5-based IM client for Matrix
https://bugzilla.redhat.com/show_bug.cgi?id=1810820 --- Comment #3 from Brendan Early --- Spec URL: https://raw.githubusercontent.com/mymindstorm/quaternion-spec/master/quaternion/quaternion.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/mymindstorm/quaternion/fedora-32-x86_64/01315147-quaternion/quaternion-0.0.9.4c-1.fc32.src.rpm Fixed issues -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1810820] Review Request: quaternion - A Qt5-based IM client for Matrix
https://bugzilla.redhat.com/show_bug.cgi?id=1810820
Robert-André Mauchin changed:
What|Removed |Added
CC||zebo...@gmail.com
--- Comment #2 from Robert-André Mauchin ---
- Use a better name for your archive:
Source0:
https://github.com/quotient-im/Quaternion/archive/%{version}/%{name}-%{version}.tar.gz
- Own these directories:
[!]: Package requires other packages for directories it uses.
Note: No known owner of
/usr/share/QMatrixClient/quaternion/translations,
/usr/share/QMatrixClient/quaternion, /usr/share/QMatrixClient
- Add RR hicolor-icon-theme for the icons
- changelog entries should not contain the Fedora release:
* Thu Mar 05 2020 Brendan Early - 0.0.9.4c-1
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: If your application is a C or C++ application you must list a
BuildRequires against gcc, gcc-c++ or clang.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated", "GPL (v3 or later)", "GNU Lesser
General Public License (v2.1 or later)", "GNU Lesser General Public
License (v3 or later)". 52 files have unknown license. Detailed output
of licensecheck in /home/bob/packaging/review/quaternion/review-
quaternion/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[!]: Package requires other packages for directories it uses.
Note: No known owner of
/usr/share/QMatrixClient/quaternion/translations,
/usr/share/QMatrixClient/quaternion, /usr/share/QMatrixClient
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[-]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 20480 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Package installs a %{name}.desktop using desktop-file-install or
desktop-file-validate if there is such a file.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are
[Bug 1810820] Review Request: quaternion - A Qt5-based IM client for Matrix
https://bugzilla.redhat.com/show_bug.cgi?id=1810820 --- Comment #1 from Brendan Early --- Spec URL: https://raw.githubusercontent.com/mymindstorm/quaternion-spec/master/quaternion/quaternion.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/mymindstorm/quaternion/fedora-32-aarch64/01285791-quaternion/quaternion-0.0.9.4c-1.fc32.src.rpm Description: Quaternion is a cross-platform desktop IM client for the Matrix protocol. Fedora Account System Username: mymindstorm COPR: https://copr.fedorainfracloud.org/coprs/mymindstorm/quaternion/package/quaternion/ Fixed a few mistakes. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1810820] Review Request: quaternion - A Qt5-based IM client for Matrix
https://bugzilla.redhat.com/show_bug.cgi?id=1810820 Brendan Early changed: What|Removed |Added Depends On||1810819 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1810819 [Bug 1810819] Review Request: libqmatrixclient - Qt5 library to write cross-platform clients for Matrix -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
