[Bug 1810897] Review Request: hello - Prints a familiar, friendly greeting
https://bugzilla.redhat.com/show_bug.cgi?id=1810897 --- Comment #19 from Fedora Update System --- FEDORA-2020-f0bfd67c52 has been pushed to the Fedora 32 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1810897] Review Request: hello - Prints a familiar, friendly greeting
https://bugzilla.redhat.com/show_bug.cgi?id=1810897 --- Comment #18 from Fedora Update System --- FEDORA-2020-0348f28a44 has been pushed to the Fedora 30 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1810897] Review Request: hello - Prints a familiar, friendly greeting
https://bugzilla.redhat.com/show_bug.cgi?id=1810897 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2020-04-16 22:40:47 --- Comment #17 from Fedora Update System --- FEDORA-2020-48b58104ed has been pushed to the Fedora 31 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1810897] Review Request: hello - Prints a familiar, friendly greeting
https://bugzilla.redhat.com/show_bug.cgi?id=1810897 --- Comment #16 from Fedora Update System --- FEDORA-2020-0348f28a44 has been pushed to the Fedora 30 testing repository. In short time you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2020-0348f28a44 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-0348f28a44 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1810897] Review Request: hello - Prints a familiar, friendly greeting
https://bugzilla.redhat.com/show_bug.cgi?id=1810897 --- Comment #15 from Fedora Update System --- FEDORA-2020-48b58104ed has been pushed to the Fedora 31 testing repository. In short time you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2020-48b58104ed \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-48b58104ed See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1810897] Review Request: hello - Prints a familiar, friendly greeting
https://bugzilla.redhat.com/show_bug.cgi?id=1810897 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #14 from Fedora Update System --- FEDORA-2020-f0bfd67c52 has been pushed to the Fedora 32 testing repository. In short time you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2020-f0bfd67c52 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-f0bfd67c52 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1810897] Review Request: hello - Prints a familiar, friendly greeting
https://bugzilla.redhat.com/show_bug.cgi?id=1810897 --- Comment #13 from Fedora Update System --- FEDORA-2020-0348f28a44 has been submitted as an update to Fedora 30. https://bodhi.fedoraproject.org/updates/FEDORA-2020-0348f28a44 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1810897] Review Request: hello - Prints a familiar, friendly greeting
https://bugzilla.redhat.com/show_bug.cgi?id=1810897 --- Comment #12 from Fedora Update System --- FEDORA-2020-48b58104ed has been submitted as an update to Fedora 31. https://bodhi.fedoraproject.org/updates/FEDORA-2020-48b58104ed -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1810897] Review Request: hello - Prints a familiar, friendly greeting
https://bugzilla.redhat.com/show_bug.cgi?id=1810897 --- Comment #11 from Fedora Update System --- FEDORA-2020-f0bfd67c52 has been submitted as an update to Fedora 32. https://bodhi.fedoraproject.org/updates/FEDORA-2020-f0bfd67c52 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1810897] Review Request: hello - Prints a familiar, friendly greeting
https://bugzilla.redhat.com/show_bug.cgi?id=1810897 Jens Petersen changed: What|Removed |Added Status|POST|MODIFIED Fixed In Version||hello-2.10-3.fc33 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1810897] Review Request: hello - Prints a familiar, friendly greeting
https://bugzilla.redhat.com/show_bug.cgi?id=1810897 --- Comment #10 from Jens Petersen --- I requested unretirement to releng in https://pagure.io/releng/issue/9377 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1810897] Review Request: hello - Prints a familiar, friendly greeting
https://bugzilla.redhat.com/show_bug.cgi?id=1810897 --- Comment #9 from Jens Petersen --- Spec URL: https://petersen.fedorapeople.org/reviews/hello/hello.spec SRPM URL: https://petersen.fedorapeople.org/reviews/hello/hello-2.10-3.fc32.src.rpm Thanks! I meant to post links too Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=42946656 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1810897] Review Request: hello - Prints a familiar, friendly greeting
https://bugzilla.redhat.com/show_bug.cgi?id=1810897 Zbigniew Jędrzejewski-Szmek changed: What|Removed |Added Status|NEW |POST Assignee|nob...@fedoraproject.org|zbys...@in.waw.pl Flags||fedora-review+ --- Comment #8 from Zbigniew Jędrzejewski-Szmek --- Looks all good now. Package is RE-APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1810897] Review Request: hello - Prints a familiar, friendly greeting
https://bugzilla.redhat.com/show_bug.cgi?id=1810897 --- Comment #7 from Jens Petersen --- (In reply to Jens Petersen from comment #6) > https://src.fedoraproject.org/fork/petersen/rpms/hello/c/ > 1317b3590753f0eea349c0a266fb51fa4a5e0d70 Okay, now with a release bump: https://src.fedoraproject.org/fork/petersen/rpms/hello/c/4ff214be2e5e0b252e2d42e3ea81baf04183e5cd -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1810897] Review Request: hello - Prints a familiar, friendly greeting
https://bugzilla.redhat.com/show_bug.cgi?id=1810897
--- Comment #6 from Jens Petersen ---
Thank you, Zbigniew, sorry for the delay.
I think I have fixed all the issues you pointed out:
(In reply to Zbigniew Jędrzejewski-Szmek from comment #3)
> > URL:http://www.gnu.org/software/hello/
>
> https please. Even GNU supports that nowadays.
:-)
> make %{?_smp_mflags} → %make_build
> make install DESTDIR=$RPM_BUILD_ROOT → %make_install
(In reply to Zbigniew Jędrzejewski-Szmek from comment #4)
> $RPM_BUILD_ROOT → %buildroot to make things more modern.
Done
(In reply to Zbigniew Jędrzejewski-Szmek from comment #5)
> Note: License file COPYING is not marked as %license
Oops, good catch
> Also: Requires: info seems suspicious.
How about Recommends?
https://src.fedoraproject.org/fork/petersen/rpms/hello/c/1317b3590753f0eea349c0a266fb51fa4a5e0d70
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1810897] Review Request: hello - Prints a familiar, friendly greeting
https://bugzilla.redhat.com/show_bug.cgi?id=1810897 --- Comment #5 from Zbigniew Jędrzejewski-Szmek --- - If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. Note: License file COPYING is not marked as %license See: https://docs.fedoraproject.org/en-US/packaging- guidelines/LicensingGuidelines/#_license_text Also: Requires: info seems suspicious. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1810897] Review Request: hello - Prints a familiar, friendly greeting
https://bugzilla.redhat.com/show_bug.cgi?id=1810897 --- Comment #4 from Zbigniew Jędrzejewski-Szmek --- $RPM_BUILD_ROOT → %buildroot to make things more modern. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1810897] Review Request: hello - Prints a familiar, friendly greeting
https://bugzilla.redhat.com/show_bug.cgi?id=1810897
Zbigniew Jędrzejewski-Szmek changed:
What|Removed |Added
CC||zbys...@in.waw.pl
--- Comment #3 from Zbigniew Jędrzejewski-Szmek ---
> URL:http://www.gnu.org/software/hello/
https please. Even GNU supports that nowadays.
make %{?_smp_mflags} → %make_build
make install DESTDIR=$RPM_BUILD_ROOT → %make_install
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1810897] Review Request: hello - Prints a familiar, friendly greeting
https://bugzilla.redhat.com/show_bug.cgi?id=1810897 --- Comment #2 from Jens Petersen --- This package was retired in 2012 (see bug 821762). The original review was bug 476936 (2009). A fork is here: https://src.fedoraproject.org/fork/petersen/rpms/hello https://koji.fedoraproject.org/koji/taskinfo?taskID=42240809 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1810897] Review Request: hello - Prints a familiar, friendly greeting
https://bugzilla.redhat.com/show_bug.cgi?id=1810897 --- Comment #1 from Jens Petersen --- Spec URL: https://petersen.fedorapeople.org/reviews/hello/hello.spec SRPM URL: https://petersen.fedorapeople.org/reviews/hello/hello-2.10-2.fc32.src.rpm add gpgverify of source -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
