[Bug 1813181] Review Request: python-jaraco-text - Module for text manipulation
https://bugzilla.redhat.com/show_bug.cgi?id=1813181 Robert-André Mauchin changed: What|Removed |Added CC||dra...@redhat.com --- Comment #10 from Robert-André Mauchin --- *** Bug 1833379 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1813181] Review Request: python-jaraco-text - Module for text manipulation
https://bugzilla.redhat.com/show_bug.cgi?id=1813181 Matthias Runge changed: What|Removed |Added Status|POST|CLOSED Fixed In Version||python-jaraco-text-3.2.0-1. ||fc33 Resolution|--- |RAWHIDE Last Closed||2020-06-22 06:31:37 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1813181] Review Request: python-jaraco-text - Module for text manipulation
https://bugzilla.redhat.com/show_bug.cgi?id=1813181 --- Comment #9 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python-jaraco-text -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1813181] Review Request: python-jaraco-text - Module for text manipulation
https://bugzilla.redhat.com/show_bug.cgi?id=1813181 Robert-André Mauchin changed: What|Removed |Added Status|NEW |POST Assignee|nob...@fedoraproject.org|zebo...@gmail.com Flags||fedora-review+ --- Comment #8 from Robert-André Mauchin --- Package approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1813181] Review Request: python-jaraco-text - Module for text manipulation
https://bugzilla.redhat.com/show_bug.cgi?id=1813181 Matthias Runge changed: What|Removed |Added Flags|needinfo?(mru...@redhat.com | |) | --- Comment #7 from Matthias Runge --- Ah sorry about that. Thank you for checking again and thank you for the reminder. Charamplos proposal solves all the issues, thank you very much! Updated SPEC: http://matthias-runge.de/fedora/python-jaraco-text.spec SRPM: http://www.matthias-runge.de/fedora/python-jaraco-text-3.2.0-1.fc33.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1813181] Review Request: python-jaraco-text - Module for text manipulation
https://bugzilla.redhat.com/show_bug.cgi?id=1813181
Robert-André Mauchin changed:
What|Removed |Added
Flags||needinfo?(mru...@redhat.com
||)
--- Comment #6 from Robert-André Mauchin ---
(In reply to Matthias Runge from comment #4)
> (In reply to Robert-André Mauchin from comment #1)
> > - Source0:
> > https://files.pythonhosted.org/packages/source/j/%{pypi_name}/%{pypi_name}-
> > %{version}.tar.gz → Source0:%{pypi_source}
> >
> > - Please use a glob or it won't work for Python >= 3.10
> >
> > %{python3_sitelib}/%{pypi_name}-%{version}-py*.egg-info
> >
> > - License is MIT:
> >
> > License:MIT
> >
> > - Not installable:
> >
> > DEBUG util.py:600: Error:
> > DEBUG util.py:600: Problem: conflicting requests
> > DEBUG util.py:600:- nothing provides python3dist(importlib-resources)
> > needed by python3-jaraco.text-3.2.0-1.fc33.noarch
> > DEBUG util.py:600:- nothing provides python3dist(pytest-black-multipy)
> > needed by python3-jaraco.text-3.2.0-1.fc33.noarch
> > DEBUG util.py:600:- nothing provides python3dist(pytest-checkdocs) >=
> > 1.2.3 needed by python3-jaraco.text-3.2.0-1.fc33.noarch
> > DEBUG util.py:602: (try to add '--skip-broken' to skip uninstallable
> > packages or '--nobest' to use not only best candidate packages)
>
>
> Thank you for your review. I'm sorry that I missed this for so long.
>
> The dependencies were misdeclarations. They are test dependencies. I'll be
> working through these slowly
> to get tests running during build in a subsequent update.
>
> jaraco.text is blocking cherrypy updates right now.
>
> SPEC: http://matthias-runge.de/fedora/python-jaraco-text.spec
> SRPM: http://matthias-runge.de/fedora/python-jaraco-text-3.2.0-1.fc32.src.rpm
You're missing:
BuildRequires: python3dist(setuptools-scm)
Also the package is still not installable:
DEBUG util.py:621: Problem: conflicting requests
DEBUG util.py:621:- nothing provides python3dist(importlib-resources)
needed by python3-jaraco.text-3.2.0-1.fc33.noarch
DEBUG util.py:623: (try to add '--skip-broken' to skip uninstallable packages
or '--nobest' to use not only best candidate packages)
Take a look at Charalampos Stratakis SPEC and update it accordingly? Requires
are not needed as they are auto detected now.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1813181] Review Request: python-jaraco-text - Module for text manipulation
https://bugzilla.redhat.com/show_bug.cgi?id=1813181 --- Comment #5 from Charalampos Stratakis --- Created attachment 1695411 --> https://bugzilla.redhat.com/attachment.cgi?id=1695411=edit Proposed SPEC Here is a proposed SPEC. With it the package builds fine, install and imports under python3. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1813181] Review Request: python-jaraco-text - Module for text manipulation
https://bugzilla.redhat.com/show_bug.cgi?id=1813181 Miro Hrončok changed: What|Removed |Added Blocks||1777494 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1777494 [Bug 1777494] python-cherrypy-18.6.0 is available -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1813181] Review Request: python-jaraco-text - Module for text manipulation
https://bugzilla.redhat.com/show_bug.cgi?id=1813181
--- Comment #4 from Matthias Runge ---
(In reply to Robert-André Mauchin from comment #1)
> - Source0:
> https://files.pythonhosted.org/packages/source/j/%{pypi_name}/%{pypi_name}-
> %{version}.tar.gz → Source0:%{pypi_source}
>
> - Please use a glob or it won't work for Python >= 3.10
>
> %{python3_sitelib}/%{pypi_name}-%{version}-py*.egg-info
>
> - License is MIT:
>
> License:MIT
>
> - Not installable:
>
> DEBUG util.py:600: Error:
> DEBUG util.py:600: Problem: conflicting requests
> DEBUG util.py:600:- nothing provides python3dist(importlib-resources)
> needed by python3-jaraco.text-3.2.0-1.fc33.noarch
> DEBUG util.py:600:- nothing provides python3dist(pytest-black-multipy)
> needed by python3-jaraco.text-3.2.0-1.fc33.noarch
> DEBUG util.py:600:- nothing provides python3dist(pytest-checkdocs) >=
> 1.2.3 needed by python3-jaraco.text-3.2.0-1.fc33.noarch
> DEBUG util.py:602: (try to add '--skip-broken' to skip uninstallable
> packages or '--nobest' to use not only best candidate packages)
Thank you for your review. I'm sorry that I missed this for so long.
The dependencies were misdeclarations. They are test dependencies. I'll be
working through these slowly
to get tests running during build in a subsequent update.
jaraco.text is blocking cherrypy updates right now.
SPEC: http://matthias-runge.de/fedora/python-jaraco-text.spec
SRPM: http://matthias-runge.de/fedora/python-jaraco-text-3.2.0-1.fc32.src.rpm
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1813181] Review Request: python-jaraco-text - Module for text manipulation
https://bugzilla.redhat.com/show_bug.cgi?id=1813181 --- Comment #3 from Matthias Runge --- all these jaraco packages are floating around in many packages, especially in cherrypy releated ones. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1813181] Review Request: python-jaraco-text - Module for text manipulation
https://bugzilla.redhat.com/show_bug.cgi?id=1813181 Charalampos Stratakis changed: What|Removed |Added CC||cstra...@redhat.com --- Comment #2 from Charalampos Stratakis --- I've recently package another one from the jaraco namespace, you can check it out here, might help fixing the issues: https://bugzilla.redhat.com/show_bug.cgi?id=1843273 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1813181] Review Request: python-jaraco-text - Module for text manipulation
https://bugzilla.redhat.com/show_bug.cgi?id=1813181
Robert-André Mauchin changed:
What|Removed |Added
CC||zebo...@gmail.com
--- Comment #1 from Robert-André Mauchin ---
- Source0:
https://files.pythonhosted.org/packages/source/j/%{pypi_name}/%{pypi_name}-%{version}.tar.gz
→ Source0:%{pypi_source}
- Please use a glob or it won't work for Python >= 3.10
%{python3_sitelib}/%{pypi_name}-%{version}-py*.egg-info
- License is MIT:
License:MIT
- Not installable:
DEBUG util.py:600: Error:
DEBUG util.py:600: Problem: conflicting requests
DEBUG util.py:600:- nothing provides python3dist(importlib-resources)
needed by python3-jaraco.text-3.2.0-1.fc33.noarch
DEBUG util.py:600:- nothing provides python3dist(pytest-black-multipy)
needed by python3-jaraco.text-3.2.0-1.fc33.noarch
DEBUG util.py:600:- nothing provides python3dist(pytest-checkdocs) >= 1.2.3
needed by python3-jaraco.text-3.2.0-1.fc33.noarch
DEBUG util.py:602: (try to add '--skip-broken' to skip uninstallable packages
or '--nobest' to use not only best candidate packages)
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
===
- Package installs properly.
Note: Installation errors (see attachment)
See: https://docs.fedoraproject.org/en-US/packaging-guidelines/
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated", "Expat License". 21 files have unknown
license. Detailed output of licensecheck in
/home/bob/packaging/review/python-jaraco-text/review-python-jaraco-
text/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package does not own files or directories owned by other packages.
Note: Dirs in package are owned also by: /usr/lib/python3.8/site-
packages/jaraco(python3-jaraco-classes, python3-jaraco),
/usr/lib/python3.8/site-packages/jaraco/__pycache__(python3-jaraco-
classes, python3-jaraco)
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
Python:
[x]: Python eggs must not download any
[Bug 1813181] Review Request: python-jaraco-text - Module for text manipulation
https://bugzilla.redhat.com/show_bug.cgi?id=1813181 Matthias Runge changed: What|Removed |Added Blocks||1813182 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1813182 [Bug 1813182] Review Request: python-jaraco-collections - Collection objects similar to those in stdlib by jaraco -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1813181] Review Request: python-jaraco-text - Module for text manipulation
https://bugzilla.redhat.com/show_bug.cgi?id=1813181 Matthias Runge changed: What|Removed |Added Blocks||1810313 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1810313 [Bug 1810313] python-cherrypy: FTBFS in Fedora 32 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
