[Bug 1816124] Review Request: python-rpmautospec - Package and CLI tool to generate release fields and changelogs
https://bugzilla.redhat.com/show_bug.cgi?id=1816124 Mattia Verga changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |CURRENTRELEASE Last Closed||2021-07-18 14:33:26 --- Comment #11 from Mattia Verga --- Package is in repos -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1816124] Review Request: python-rpmautospec - Package and CLI tool to generate release fields and changelogs
https://bugzilla.redhat.com/show_bug.cgi?id=1816124 --- Comment #10 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python-rpmautospec -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1816124] Review Request: python-rpmautospec - Package and CLI tool to generate release fields and changelogs
https://bugzilla.redhat.com/show_bug.cgi?id=1816124 Neal Gompa changed: What|Removed |Added Blocks|177841 (FE-NEEDSPONSOR) | --- Comment #9 from Neal Gompa --- I've sponsored you through. You can proceed with the next step! Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1816124] Review Request: python-rpmautospec - Package and CLI tool to generate release fields and changelogs
https://bugzilla.redhat.com/show_bug.cgi?id=1816124 Adam Saleh changed: What|Removed |Added Blocks||177841 (FE-NEEDSPONSOR) Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1816124] Review Request: python-rpmautospec - Package and CLI tool to generate release fields and changelogs
https://bugzilla.redhat.com/show_bug.cgi?id=1816124 Neal Gompa changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #8 from Neal Gompa --- > python-rpmautospec.src: W: invalid-url Source0: > https://releases.pagure.org/Fedora-Infra/rpmautospec/rpmautospec-0.0.1.tar.gz > HTTP Error 404: Not Found I assume this will be valid once this release has actually been made. Other than that, I see no other serious issues. PACKAGE APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1816124] Review Request: python-rpmautospec - Package and CLI tool to generate release fields and changelogs
https://bugzilla.redhat.com/show_bug.cgi?id=1816124
Neal Gompa changed:
What|Removed |Added
Flags|needinfo?(asa...@redhat.com |
|) |
--- Comment #7 from Neal Gompa ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
[x]: License file installed when any subpackage combination is installed.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[-]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
Python:
[x]: Python eggs must not download any dependencies during the build
process.
[x]: A package which is used by another package via an egg interface should
provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Packages MUST NOT have dependencies (either build-time or runtime) on
packages named with the unversioned python- prefix unless no properly
versioned package exists. Dependencies on Python packages instead MUST
use names beginning with python2- or python3- as appropriate.
[x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files
[x]: Binary eggs must be removed in %prep
= SHOULD items =
Generic:
[!]: Sources can be downloaded from URI in Source: tag
Note: Could not download Source0: https://releases.pagure.org/Fedora-
Infra/rpmautospec/rpmautospec-0.0.1.tar.gz
See: https://docs.fedoraproject.org/en-US/packaging-
guidelines/SourceURL/
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[?]: SourceX tarball generation or download is documented.
Note: Package contains tarball without
[Bug 1816124] Review Request: python-rpmautospec - Package and CLI tool to generate release fields and changelogs
https://bugzilla.redhat.com/show_bug.cgi?id=1816124 --- Comment #6 from Adam Saleh --- Changed the license to correspond with upstream and regenerated the srpm. Spec URL: https://raw.githubusercontent.com/AdamSaleh/python-rpmautospec/master/python-rpmautospec.spec SRPM URL: https://raw.githubusercontent.com/AdamSaleh/python-rpmautospec/master/rpms/python-rpmautospec-0.0.1-1.fc31.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1816124] Review Request: python-rpmautospec - Package and CLI tool to generate release fields and changelogs
https://bugzilla.redhat.com/show_bug.cgi?id=1816124 Neal Gompa changed: What|Removed |Added Flags||needinfo?(asa...@redhat.com ||) --- Comment #5 from Neal Gompa --- Adam, can you please regenerate the source RPM to match the spec file? fedora-review indicates that the two are quite different. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1816124] Review Request: python-rpmautospec - Package and CLI tool to generate release fields and changelogs
https://bugzilla.redhat.com/show_bug.cgi?id=1816124 --- Comment #4 from Adam Saleh --- I rearanged the spec-file to make it more readable, you can see the history of commits in the referenced repo. Another change is splitting out cli the executable to a separate package and renaming the plugin package to koji-builder-plugin-rpmautospec. Spec URL: https://raw.githubusercontent.com/AdamSaleh/python-rpmautospec/master/python-rpmautospec.spec SRPM URL: https://raw.githubusercontent.com/AdamSaleh/python-rpmautospec/master/rpms/python-rpmautospec-0.0.1-1.fc31.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1816124] Review Request: python-rpmautospec - Package and CLI tool to generate release fields and changelogs
https://bugzilla.redhat.com/show_bug.cgi?id=1816124 --- Comment #3 from Neal Gompa --- This spec file is illogically organized and hard to read. Please move subpackage definitions up with the rest of the preamble. You may also choose to organize it Mandriva-style where all the declarative parts are in one place, like so: Preamble %description %files # - %package %description %files # - %prep %build %install # - %changelog Basically, please make it readable. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1816124] Review Request: python-rpmautospec - Package and CLI tool to generate release fields and changelogs
https://bugzilla.redhat.com/show_bug.cgi?id=1816124 Neal Gompa changed: What|Removed |Added CC||ngomp...@gmail.com Assignee|nob...@fedoraproject.org|ngomp...@gmail.com Flags||fedora-review? --- Comment #2 from Neal Gompa --- Taking this review. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1816124] Review Request: python-rpmautospec - Package and CLI tool to generate release fields and changelogs
https://bugzilla.redhat.com/show_bug.cgi?id=1816124 Nils Philippsen changed: What|Removed |Added Status|NEW |ASSIGNED CC||nphil...@redhat.com Doc Type|--- |If docs needed, set a value --- Comment #1 from Nils Philippsen --- Spec URL: https://raw.githubusercontent.com/AdamSaleh/python-rpmautospec/master/python-rpmautospec.spec SRPM URL: https://raw.githubusercontent.com/AdamSaleh/python-rpmautospec/master/rpms/python-rpmautospec-0.0.1-1.fc31.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
