[Bug 1818999] Review Request: ofono - open source telephony
https://bugzilla.redhat.com/show_bug.cgi?id=1818999 Mattia Verga changed: What|Removed |Added Resolution|--- |CURRENTRELEASE Status|POST|CLOSED Last Closed||2021-08-03 16:19:31 --- Comment #9 from Mattia Verga --- Package is available in repos. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1818999] Review Request: ofono - open source telephony
https://bugzilla.redhat.com/show_bug.cgi?id=1818999 Robert-André Mauchin changed: What|Removed |Added Status|NEW |POST Assignee|nob...@fedoraproject.org|zebo...@gmail.com Flags||fedora-review+ --- Comment #8 from Robert-André Mauchin --- Package approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1818999] Review Request: ofono - open source telephony
https://bugzilla.redhat.com/show_bug.cgi?id=1818999 --- Comment #7 from Nikhil Jha --- Thanks & sorry for the late reply, I got busy with school again. - Missing isa in the devel subpackage: Fixed. - Not needed Fixed. - Error in %changelog, March 30 is a Monday: Fixed. - Explicitly add a BR against gcc Fixed. - AutoTools: Obsoleted m4s found Patched, sent patch to upstream mailing list. --- SPEC: https://gitlab.com/fedora-mobile/ofono/-/raw/master/ofono.spec COPR build: https://copr.fedorainfracloud.org/coprs/njha/mobile/build/1613145/ Direct link to SRPM: https://download.copr.fedorainfracloud.org/results/njha/mobile/fedora-rawhide-x86_64/01613145-ofono/ofono-1.31-1.fc34.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1818999] Review Request: ofono - open source telephony
https://bugzilla.redhat.com/show_bug.cgi?id=1818999
Robert-André Mauchin changed:
What|Removed |Added
CC||zebo...@gmail.com
--- Comment #6 from Robert-André Mauchin ---
- Missing isa in the devel subpackage:
Requires: %{name}%{?_isa} = %{version}-%{release}
- Not needed
BuildRequires: systemd
Requires(post): systemd
Requires(preun): systemd
Requires(postun): systemd
use:
BuildRequires: systemd-rpm-macros
- Error in %changelog, March 30 is a Monday:
warning: bogus date in %changelog: Fri Mar 30 2020 Nikhil Jha
- 1.31-1
- Explicitly add a BR against gcc
[!]: Package should not use obsolete m4 macros
Note: Some obsoleted macros found, see the attachment.
See: https://fedorahosted.org/FedoraReview/wiki/AutoTools
AutoTools: Obsoleted m4s found
--
AC_PROG_LIBTOOL found in: ofono-1.31/configure.ac:31
Patch it with LT_INIT instead and send a patch upstream. (Ref:
https://www.gnu.org/software/libtool/manual/html_node/LT_005fINIT.html)
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
===
- If your application is a C or C++ application you must list a
BuildRequires against gcc, gcc-c++ or clang.
Note: No gcc, gcc-c++ or clang found in BuildRequires
See: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/
- Package does not use a name that already exists.
Note: A package with this name already exists. Please check
https://src.fedoraproject.org/rpms/ofono
See: https://docs.fedoraproject.org/en-US/packaging-
guidelines/Naming/#_conflicting_package_names
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated", "GNU Lesser General Public License",
"GPL (v2 or later)", "GPL (v2)", "GPL (v2 or later) (with incorrect
FSF address)", "Unicode strict GPL (v2)". 203 files have unknown
license. Detailed output of licensecheck in
/home/bob/packaging/review/ofono/review-ofono/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[x]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 51200 bytes in 3 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: %config files are marked noreplace or the reason is justified.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain
[Bug 1818999] Review Request: ofono - open source telephony
https://bugzilla.redhat.com/show_bug.cgi?id=1818999 --- Comment #5 from rob.verdu...@gmail.com --- I managed to package ofono and phonesim localy but but the headset mode still failed to work with the latest pulseaudio and bluetooth on my fedora 31 kde install. I wanted it to work before even considering submitting it. ps that copr repo isn't mine. Rob -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1818999] Review Request: ofono - open source telephony
https://bugzilla.redhat.com/show_bug.cgi?id=1818999 --- Comment #4 from Nikhil Jha --- I need it for KDE Plasma Mobile on the PinePhone, but that needs oFono-phonesim too. I just haven't gotten around to making it. Are you going to submit it (probably as ofono-phonesim instead of just phonesim)? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1818999] Review Request: ofono - open source telephony
https://bugzilla.redhat.com/show_bug.cgi?id=1818999 rob.verdu...@gmail.com changed: What|Removed |Added CC||rob.verdu...@gmail.com --- Comment #3 from rob.verdu...@gmail.com --- Hello, Is this package being revived because this is required for pulseaudio to get (HSP/HFP) head-set-mode working ? https://freedesktop.org/wiki/Software/PulseAudio/Documentation/User/Bluetooth/#usingbluetoothwhenrunningpulseaudiointhesystemmode If so you are also going to need phonesim. A copr build can be found here: https://copr.fedorainfracloud.org/coprs/nielsenb/oFono-phonesim/packages/ If not... please ignore this message -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1818999] Review Request: ofono - open source telephony
https://bugzilla.redhat.com/show_bug.cgi?id=1818999 --- Comment #2 from Nikhil Jha --- Sounds good, updated the description in the specfile. That probably won't affect how it builds but I rebuilt it anyway. https://copr.fedorainfracloud.org/coprs/njha/mobile/build/1324602/ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1818999] Review Request: ofono - open source telephony
https://bugzilla.redhat.com/show_bug.cgi?id=1818999
Artur Iwicki changed:
What|Removed |Added
CC||fed...@svgames.pl
Doc Type|--- |If docs needed, set a value
--- Comment #1 from Artur Iwicki ---
Adding myself to the CC list since I maintain modem-manager-gui and it has an
ofono plugin (currently disabled from building).
>%description devel
>%{summary}.
Maybe just write something generic like "This package contains files required
to develop applications using oFono"?
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1818999] Review Request: ofono - open source telephony
https://bugzilla.redhat.com/show_bug.cgi?id=1818999 Nikhil Jha changed: What|Removed |Added CC||pbrobin...@gmail.com Blocks||1817424 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1817424 [Bug 1817424] Tracker for mobility SIG activities -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
