[Bug 1824780] Review Request: rubygem-optimist - Commandline option parser for Ruby
https://bugzilla.redhat.com/show_bug.cgi?id=1824780
--- Comment #8 from Vít Ondruch ---
(In reply to Fabio Valentini from comment #4)
> (In reply to Fabio Valentini from comment #1)
> > I think you should add "%exclude %{gem_cache}" to the %files section.
> > While it's not mentioned in the packaging guidelines, but this is generated
> > by gem2rpm, and this is what existing rubygem packages do as well.
> >
> > You also need to own "%dir %{gem_instdir}", otherwise that directory is
> > unowned.
> >
> > Please fix those two issues before importing the package.
>
> ↑ I noted this in the review, but apparently Igor didn't see that ...
Neither did I, sorry ;D
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1824780] Review Request: rubygem-optimist - Commandline option parser for Ruby
https://bugzilla.redhat.com/show_bug.cgi?id=1824780 --- Comment #7 from Igor Gnatenko --- Ah, now I see... Will fix it in a bit. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1824780] Review Request: rubygem-optimist - Commandline option parser for Ruby
https://bugzilla.redhat.com/show_bug.cgi?id=1824780
--- Comment #6 from Fabio Valentini ---
"%dir %{gem_instdir}" needs to be in the main package (not in the -doc
subpackage).
https://src.fedoraproject.org/rpms/rubygem-optimist/blob/master/f/rubygem-optimist.spec#_61
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1824780] Review Request: rubygem-optimist - Commandline option parser for Ruby
https://bugzilla.redhat.com/show_bug.cgi?id=1824780
Igor Gnatenko changed:
What|Removed |Added
Flags|needinfo?(i.gnatenko.brain@ |
|gmail.com) |
--- Comment #5 from Igor Gnatenko ---
> %dir %{gem_instdir}
is in the spec file, no?
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1824780] Review Request: rubygem-optimist - Commandline option parser for Ruby
https://bugzilla.redhat.com/show_bug.cgi?id=1824780
Fabio Valentini changed:
What|Removed |Added
Flags||needinfo?(i.gnatenko.brain@
||gmail.com)
--- Comment #4 from Fabio Valentini ---
(In reply to Fabio Valentini from comment #1)
> I think you should add "%exclude %{gem_cache}" to the %files section.
> While it's not mentioned in the packaging guidelines, but this is generated
> by gem2rpm, and this is what existing rubygem packages do as well.
>
> You also need to own "%dir %{gem_instdir}", otherwise that directory is
> unowned.
>
> Please fix those two issues before importing the package.
↑ I noted this in the review, but apparently Igor didn't see that ...
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1824780] Review Request: rubygem-optimist - Commandline option parser for Ruby
https://bugzilla.redhat.com/show_bug.cgi?id=1824780
Vít Ondruch changed:
What|Removed |Added
CC||vondr...@redhat.com
--- Comment #3 from Vít Ondruch ---
It seems that the package does not own the `%{gem_instdir}` in any way.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1824780] Review Request: rubygem-optimist - Commandline option parser for Ruby
https://bugzilla.redhat.com/show_bug.cgi?id=1824780 Igor Gnatenko changed: What|Removed |Added Status|POST|CLOSED Resolution|--- |RAWHIDE Last Closed||2020-04-17 08:40:00 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1824780] Review Request: rubygem-optimist - Commandline option parser for Ruby
https://bugzilla.redhat.com/show_bug.cgi?id=1824780 --- Comment #2 from Igor Gnatenko --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/rubygem-optimist -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1824780] Review Request: rubygem-optimist - Commandline option parser for Ruby
https://bugzilla.redhat.com/show_bug.cgi?id=1824780
--- Comment #1 from Fabio Valentini ---
I think you should add "%exclude %{gem_cache}" to the %files section.
While it's not mentioned in the packaging guidelines, but this is generated by
gem2rpm, and this is what existing rubygem packages do as well.
You also need to own "%dir %{gem_instdir}", otherwise that directory is
unowned.
Please fix those two issues before importing the package.
Full review below.
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: License field in the package spec file matches the actual license.
[-]: License file installed when any subpackage combination is installed.
[!]: Package requires other packages for directories it uses.
Note: No known owner of /usr/share/gems/gems/optimist-3.0.0
[x]: Package must own all directories that it creates.
[-]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[?]: Avoid bundling fonts in non-fonts packages.
[x]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Sources are verified with gpgverify first in %prep if upstream
publishes signatures.
Note: gpgverify is not used.
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Fully versioned dependency in subpackages if applicable.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]:
[Bug 1824780] Review Request: rubygem-optimist - Commandline option parser for Ruby
https://bugzilla.redhat.com/show_bug.cgi?id=1824780 Fabio Valentini changed: What|Removed |Added Status|NEW |POST Flags|fedora-review? |fedora-review+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1824780] Review Request: rubygem-optimist - Commandline option parser for Ruby
https://bugzilla.redhat.com/show_bug.cgi?id=1824780 Igor Gnatenko changed: What|Removed |Added Blocks||1824788 ||(rubygem-hiera-eyaml) Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1824788 [Bug 1824788] Review Request: rubygem-hiera-eyaml - Hiera backend for decrypting encrypted yaml properties -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1824780] Review Request: rubygem-optimist - Commandline option parser for Ruby
https://bugzilla.redhat.com/show_bug.cgi?id=1824780 Fabio Valentini changed: What|Removed |Added CC||decatho...@gmail.com Assignee|nob...@fedoraproject.org|decatho...@gmail.com Doc Type|--- |If docs needed, set a value Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
