[Bug 1828101] Review Request: gnome-shell-extension-emoji-selector - GNOME Shell extension for copying emojis to the clipboard
https://bugzilla.redhat.com/show_bug.cgi?id=1828101 Carl George 鸞 changed: What|Removed |Added Status|POST|CLOSED Fixed In Version||gnome-shell-extension-emoji ||-selector-19-2.fc33 Resolution|--- |RAWHIDE Last Closed||2020-06-06 03:19:56 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1828101] Review Request: gnome-shell-extension-emoji-selector - GNOME Shell extension for copying emojis to the clipboard
https://bugzilla.redhat.com/show_bug.cgi?id=1828101 --- Comment #9 from Carl George 鸞 --- https://bodhi.fedoraproject.org/updates/FEDORA-2020-8bb0db68cd -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1828101] Review Request: gnome-shell-extension-emoji-selector - GNOME Shell extension for copying emojis to the clipboard
https://bugzilla.redhat.com/show_bug.cgi?id=1828101 --- Comment #8 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/gnome-shell-extension-emoji-selector -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1828101] Review Request: gnome-shell-extension-emoji-selector - GNOME Shell extension for copying emojis to the clipboard
https://bugzilla.redhat.com/show_bug.cgi?id=1828101 Lyes Saadi changed: What|Removed |Added Status|ASSIGNED|POST Flags|fedora-review? |fedora-review+ --- Comment #7 from Lyes Saadi --- Ok! Package approved! Thank you for your work :D! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1828101] Review Request: gnome-shell-extension-emoji-selector - GNOME Shell extension for copying emojis to the clipboard
https://bugzilla.redhat.com/show_bug.cgi?id=1828101 Carl George 鸞 changed: What|Removed |Added Flags|needinfo?(c...@redhat.com) | --- Comment #6 from Carl George 鸞 --- Thanks for the sleuthing on convenience.js. I've updated the license field as requested, along with a comment explaining the license breakdown. Spec URL: https://download.copr.fedorainfracloud.org/results/carlwgeorge/reviews/fedora-rawhide-x86_64/01427033-gnome-shell-extension-emoji-selector/gnome-shell-extension-emoji-selector.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/carlwgeorge/reviews/fedora-rawhide-x86_64/01427033-gnome-shell-extension-emoji-selector/gnome-shell-extension-emoji-selector-19-2.fc33.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1828101] Review Request: gnome-shell-extension-emoji-selector - GNOME Shell extension for copying emojis to the clipboard
https://bugzilla.redhat.com/show_bug.cgi?id=1828101
Lyes Saadi changed:
What|Removed |Added
Status|NEW |ASSIGNED
Assignee|nob...@fedoraproject.org|fed...@lyes.eu
Flags||fedora-review?
||needinfo?(c...@redhat.com)
--- Comment #5 from Lyes Saadi ---
Hi! Sorry for this extremely late answer, I had things to take care of + a
computer issue :P. I'm taking this review request!
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
Issues:
===
- convenience.js has a different license. Its License ("BSD") should
be added in the License Field.
I was able to trace the origin of the file to this repo:
https://github.com/gcampax/gnome-shell-extensions/blob/master/lib/convenience.js
and to this commit: e2a76b665a1e7902d825adc7add0ad3892007d86.
This file seems to be widely used in gnome extensions, as I did find
the license "header" in 800+ GitHub repos (forks have surely greatly
inflated that number though). And I don't think it would be right to
see this as a case of bundling, since, it's not really a library,
more of a single function. Plus I found 7 other packaged extensions
in the repos including convenience.js, none providing a bundling
declaration. So, no need to add a Provide: bundled(), adding the
License is mandatory though (no need to provide a separate License
file, adding BSD to the License field is enough).
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[!]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated", "BSD 3-clause "New" or "Revised"
License", "GPL (v3 or later)". 49 files have unknown license. Detailed
output of licensecheck in
/var/home/lyes/Documents/reviews/1828101-gnome-shell-extension-emoji-
selector/licensecheck.txt
[x]: Package must own all directories that it creates.
Note: this requires gnome-shell-extension-common which requires
gnome-shell which requires glib2
Note: Directories without known owners: /usr/share/glib-2.0,
/usr/share/glib-2.0/schemas
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: The spec file handles locales properly.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[-]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
[Bug 1828101] Review Request: gnome-shell-extension-emoji-selector - GNOME Shell extension for copying emojis to the clipboard
https://bugzilla.redhat.com/show_bug.cgi?id=1828101 --- Comment #4 from Carl George --- Thanks for the suggestions Lyes. Since upstream is already includes the mo files in the tarball, I'll just use them directly. * Tue May 12 2020 Carl George - 19-1 - Latest upstream - Install locale files correctly Spec URL: https://download.copr.fedorainfracloud.org/results/carlwgeorge/reviews/fedora-rawhide-x86_64/01380479-gnome-shell-extension-emoji-selector/gnome-shell-extension-emoji-selector.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/carlwgeorge/reviews/fedora-rawhide-x86_64/01380479-gnome-shell-extension-emoji-selector/gnome-shell-extension-emoji-selector-19-1.fc33.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1828101] Review Request: gnome-shell-extension-emoji-selector - GNOME Shell extension for copying emojis to the clipboard
https://bugzilla.redhat.com/show_bug.cgi?id=1828101 --- Comment #3 from Lyes Saadi --- I've used dash-to-dock's spec to be sure that extensions need to follow Fedora's locale guidelines: https://src.fedoraproject.org/rpms/gnome-shell-extension-dash-to-dock/blob/master/f/gnome-shell-extension-dash-to-dock.spec But adding this should work (not sure, I didn't check thoroughly): ``` # With the requires BuildRequires: gettext # In the build section ./update-and-compile-translations.sh # At the end of %%install %find_lang emoji-selector # And add this to the %%files section %files -f emoji-selector.lang ``` -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1828101] Review Request: gnome-shell-extension-emoji-selector - GNOME Shell extension for copying emojis to the clipboard
https://bugzilla.redhat.com/show_bug.cgi?id=1828101 --- Comment #2 from Carl George --- Because of my own ignorance. Thanks for the suggestion. I found the section in the packaging guidelines about handling locale files, and I'm reading that now. While I do that, do you have an example of a similar package (another gnome-shell extension ideally) that has additional languages handled correctly for me to use as a reference? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1828101] Review Request: gnome-shell-extension-emoji-selector - GNOME Shell extension for copying emojis to the clipboard
https://bugzilla.redhat.com/show_bug.cgi?id=1828101 Lyes Saadi changed: What|Removed |Added CC||fed...@lyes.eu --- Comment #1 from Lyes Saadi --- Hi! This is just a question, not a review, but why aren't the locale files recompiled (using update-and-compile-translations.sh?) and why isn't there a %find_lang? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
