https://bugzilla.redhat.com/show_bug.cgi?id=1829340
Martin Liška changed:
What|Removed |Added
Status|POST|CLOSED
Resolution|---
https://bugzilla.redhat.com/show_bug.cgi?id=1829340
--- Comment #44 from Gwyn Ciesla ---
(fedscm-admin): The Pagure repository was created at
https://src.fedoraproject.org/rpms/python-pebble
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified
https://bugzilla.redhat.com/show_bug.cgi?id=1829340
--- Comment #43 from Miro Hrončok ---
(In reply to Martin Liška from comment #41)
> >
> > Also note that there are 162 skipped tests (from 241). Maybe a dependency is
> > missing?
>
> They should be run in separate pytest context:
>
https://bugzilla.redhat.com/show_bug.cgi?id=1829340
Miro Hrončok changed:
What|Removed |Added
Status|ASSIGNED|POST
Flags|fedora-review?
https://bugzilla.redhat.com/show_bug.cgi?id=1829340
--- Comment #41 from Martin Liška ---
>
> Also note that there are 162 skipped tests (from 241). Maybe a dependency is
> missing?
They should be run in separate pytest context:
https://bugzilla.redhat.com/show_bug.cgi?id=1829340
--- Comment #40 from Martin Liška ---
(In reply to Miro Hrončok from comment #38)
> It seem to me that the license should be LGPLv3+, see
> https://github.com/noxdafox/pebble/blob/4.5.3/pebble/common.py#L7 -- it says
> "or (at your option)
https://bugzilla.redhat.com/show_bug.cgi?id=1829340
--- Comment #39 from Miro Hrončok ---
> Also note that there are 162 skipped tests (from 241). Maybe a dependency is
> missing?
Seem like it's all about support for various features in Python. I'll trust
upstream the detection is OK.
--
https://bugzilla.redhat.com/show_bug.cgi?id=1829340
--- Comment #38 from Miro Hrončok ---
It seem to me that the license should be LGPLv3+, see
https://github.com/noxdafox/pebble/blob/4.5.3/pebble/common.py#L7 -- it says
"or (at your option) any later version"
Also note that there are 162
https://bugzilla.redhat.com/show_bug.cgi?id=1829340
--- Comment #37 from Martin Liška ---
Fixed:
SRPM:
https://github.com/marxin/fedora-Pebble/raw/master/python-pebble-4.5.3-1.fc31.src.rpm
SPEC:
https://raw.githubusercontent.com/marxin/fedora-Pebble/master/python-pebble.spec
--
You are
https://bugzilla.redhat.com/show_bug.cgi?id=1829340
--- Comment #36 from Miro Hrončok ---
Sources in SRPM do not match what can be downloaded from the URL.
https://files.pythonhosted.org/packages/source/P/Pebble/Pebble-4.5.1.tar.gz :
CHECKSUM(SHA256) this package :
https://bugzilla.redhat.com/show_bug.cgi?id=1829340
--- Comment #35 from Miro Hrončok ---
Running a build now.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=1829340
--- Comment #34 from Martin Liška ---
May I please ping that?
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=1829340
--- Comment #33 from Martin Liška ---
All right, I regenerated them in Fedora container:
SRPM:
https://github.com/marxin/fedora-Pebble/raw/master/python-pebble-4.5.1-1.fc31.src.rpm
SPEC:
https://bugzilla.redhat.com/show_bug.cgi?id=1829340
--- Comment #32 from Miro Hrončok ---
Into the environment you are in: $ sudo dnf build-dep xxx.spec
I personally use mock to have more reproducible setups and to avoid installing
everything to my machine. Many packagers do as well.
https://bugzilla.redhat.com/show_bug.cgi?id=1829340
--- Comment #31 from Martin Liška ---
Yep, I should have done it earlier. Ok, right now I built the package
with podman. I've just added build dependency on python3-pytest.
Btw. do you have a way how to install all BuildRequires packages
https://bugzilla.redhat.com/show_bug.cgi?id=1829340
--- Comment #30 from Miro Hrončok ---
> I'm sorry but it's all blind development. I don't an access to a Fedora
> system and
> I need apparently fedora-packager.
Oh. Can you try in docker for example?
--
You are receiving this mail
https://bugzilla.redhat.com/show_bug.cgi?id=1829340
--- Comment #29 from Martin Liška ---
I'm sorry but it's all blind development. I don't an access to a Fedora system
and
I need apparently fedora-packager.
I changed to: PYTHONPATH=%{buildroot}%{python3_sitelib} pytest
but I can't test that.
https://bugzilla.redhat.com/show_bug.cgi?id=1829340
--- Comment #28 from Miro Hrončok ---
Still doesn't build. Could you please test your changes?
+ pytest
= test session starts
==
platform linux -- Python 3.8.3rc1, pytest-4.6.10,
https://bugzilla.redhat.com/show_bug.cgi?id=1829340
--- Comment #27 from Miro Hrončok ---
Spec URL: https://github.com/marxin/fedora-Pebble/raw/master/python-pebble.spec
SRPM URL:
https://github.com/marxin/fedora-Pebble/raw/master/python-pebble-4.5.1-1.src.rpm
--
You are receiving this mail
https://bugzilla.redhat.com/show_bug.cgi?id=1829340
--- Comment #26 from Martin Liška ---
Done.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
https://bugzilla.redhat.com/show_bug.cgi?id=1829340
--- Comment #25 from Miro Hrončok ---
I need a new SRPM to do the review.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=1829340
--- Comment #24 from Martin Liška ---
Done.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
https://bugzilla.redhat.com/show_bug.cgi?id=1829340
--- Comment #23 from Miro Hrončok ---
In rawhide, we have %pytest. I plan to backport it soon. See
https://lists.fedoraproject.org/archives/list/python-de...@lists.fedoraproject.org/thread/XLPDSH362PJKMJCAYOXNJNV53Y66EF6B/
If you target
https://bugzilla.redhat.com/show_bug.cgi?id=1829340
--- Comment #22 from Martin Liška ---
(In reply to Miro Hrončok from comment #20)
> The package doesn't build as is:
>
> + /usr/bin/python3 setup.py test
> fatal: No names found, cannot describe anything.
We run 'pytest' in OBS.
Do you have
https://bugzilla.redhat.com/show_bug.cgi?id=1829340
--- Comment #21 from Martin Liška ---
(In reply to Miro Hrončok from comment #19)
> Not fixed. You've added the dist to version, not release. See
> https://docs.fedoraproject.org/en-US/packaging-guidelines/DistTag/
Ah sorry, fixed!
--
You
https://bugzilla.redhat.com/show_bug.cgi?id=1829340
--- Comment #20 from Miro Hrončok ---
The package doesn't build as is:
+ /usr/bin/python3 setup.py test
fatal: No names found, cannot describe anything.
running test
WARNING: Testing via this command is deprecated and will be removed in a
https://bugzilla.redhat.com/show_bug.cgi?id=1829340
--- Comment #19 from Miro Hrončok ---
Not fixed. You've added the dist to version, not release. See
https://docs.fedoraproject.org/en-US/packaging-guidelines/DistTag/
--
You are receiving this mail because:
You are on the CC list for the
https://bugzilla.redhat.com/show_bug.cgi?id=1829340
--- Comment #18 from Martin Liška ---
(In reply to Miro Hrončok from comment #17)
> BTW the changelog entry should say: 4.5.1-1 and the release should be
> 1%{?dist}.
Fixed!
--
You are receiving this mail because:
You are on the CC list
https://bugzilla.redhat.com/show_bug.cgi?id=1829340
--- Comment #17 from Miro Hrončok ---
BTW the changelog entry should say: 4.5.1-1 and the release should be
1%{?dist}.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to
https://bugzilla.redhat.com/show_bug.cgi?id=1829340
--- Comment #16 from Miro Hrončok ---
Spec URL: https://github.com/marxin/fedora-Pebble/raw/master/python-pebble.spec
SRPM URL:
https://github.com/marxin/fedora-Pebble/raw/master/python-pebble-4.5.1-0.src.rpm
--
You are receiving this mail
https://bugzilla.redhat.com/show_bug.cgi?id=1829340
--- Comment #15 from Martin Liška ---
Done in the git repository.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=1829340
--- Comment #14 from Miro Hrončok ---
Ok, could you please give me a new SRPM link?
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=1829340
--- Comment #13 from Martin Liška ---
Yes, both things are fixed.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=1829340
--- Comment #12 from Miro Hrončok ---
Suggestion: Run tests in %check?
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=1829340
--- Comment #11 from Miro Hrončok ---
The main package doesn't have Summary.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=1829340
--- Comment #10 from Martin Liška ---
Ok, should be fixed now, please take a look.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=1829340
--- Comment #9 from Miro Hrončok ---
The source package name should be python-pebble, the subpackage name should be
python3-pebble, see the example in
https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_example_python_spec_file
https://bugzilla.redhat.com/show_bug.cgi?id=1829340
--- Comment #8 from Martin Liška ---
All right, I've just copied the file:
https://github.com/marxin/fedora-Pebble/commit/92f7a12b1fed329ad381b7433ff962d9fc1c
--
You are receiving this mail because:
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=1829340
Miro Hrončok changed:
What|Removed |Added
Summary|Review Request: |Review Request:
39 matches
Mail list logo
