[Bug 1830322] Review Request: gap-pkg-ferret - Backtracking search in permutation groups
https://bugzilla.redhat.com/show_bug.cgi?id=1830322 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2020-05-16 03:39:14 --- Comment #9 from Fedora Update System --- FEDORA-2020-d484f75f5c has been pushed to the Fedora 32 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1830322] Review Request: gap-pkg-ferret - Backtracking search in permutation groups
https://bugzilla.redhat.com/show_bug.cgi?id=1830322 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #8 from Fedora Update System --- FEDORA-2020-d484f75f5c has been pushed to the Fedora 32 testing repository. In short time you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2020-d484f75f5c \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-d484f75f5c See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1830322] Review Request: gap-pkg-ferret - Backtracking search in permutation groups
https://bugzilla.redhat.com/show_bug.cgi?id=1830322 Fedora Update System changed: What|Removed |Added Status|POST|MODIFIED --- Comment #7 from Fedora Update System --- FEDORA-2020-d484f75f5c has been submitted as an update to Fedora 32. https://bodhi.fedoraproject.org/updates/FEDORA-2020-d484f75f5c -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1830322] Review Request: gap-pkg-ferret - Backtracking search in permutation groups
https://bugzilla.redhat.com/show_bug.cgi?id=1830322 --- Comment #6 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/gap-pkg-ferret -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1830322] Review Request: gap-pkg-ferret - Backtracking search in permutation groups
https://bugzilla.redhat.com/show_bug.cgi?id=1830322 --- Comment #5 from Jerry James --- Thank you, Ankur! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1830322] Review Request: gap-pkg-ferret - Backtracking search in permutation groups
https://bugzilla.redhat.com/show_bug.cgi?id=1830322 Ankur Sinha (FranciscoD) changed: What|Removed |Added Status|ASSIGNED|POST Flags|fedora-review? |fedora-review+ --- Comment #4 from Ankur Sinha (FranciscoD) --- OK, that looks good. XXX APPROVED XXX -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1830322] Review Request: gap-pkg-ferret - Backtracking search in permutation groups
https://bugzilla.redhat.com/show_bug.cgi?id=1830322 --- Comment #3 from Jerry James --- Thanks for catching the license issue. I have added "and Public Domain" to the License field. The other licenses identified by licensecheck are on files that are not part of the final binary package. In particular, the MIT (Expat) license is on a file that is now explicitly removed in %prep to verify that it is not used in the build, and the FSF Unlimited licenses are on libtool-related files. There is no license file in the tarball, but as noted in the comment above the License tag, one has been checked into git upstream. When upstream next makes a release, I will be sure to add a %license tag. New URLs: Spec URL: https://jjames.fedorapeople.org/gap-pkg-ferret/gap-pkg-ferret.spec SRPM URL: https://jjames.fedorapeople.org/gap-pkg-ferret/gap-pkg-ferret-1.0.2-2.fc33.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1830322] Review Request: gap-pkg-ferret - Backtracking search in permutation groups
https://bugzilla.redhat.com/show_bug.cgi?id=1830322 --- Comment #2 from Ankur Sinha (FranciscoD) --- Created attachment 1686208 --> https://bugzilla.redhat.com/attachment.cgi?id=1686208=edit license check output from fedora-review -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1830322] Review Request: gap-pkg-ferret - Backtracking search in permutation groups
https://bugzilla.redhat.com/show_bug.cgi?id=1830322
--- Comment #1 from Ankur Sinha (FranciscoD) ---
Looks good. fedora-review picked some additional licenses in the code, so once
those are double-checked, this will be good to go :)
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[-]: Package contains no static executables.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
Note: Unversioned so-files in private %_libdir subdirectory (see
attachment). Verify they are not in ld path.
^
False positive. OK for gap packages.
[x]: If your application is a C or C++ application you must list a
BuildRequires against gcc, gcc-c++ or clang.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[-]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[?]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated", "Expat License", "GPL (v2 or later)",
"FSF Unlimited License (with Retention) GNU General Public License
(v2)", "FSF Unlimited License (with Retention)", "Public domain". 211
files have unknown license. Detailed output of licensecheck in
/home/asinha/dump/fedora-reviews/1830322-gap-pkg-
ferret/licensecheck.txt
^
Please double check these to confirm what the license field should be.
[-]: License file installed when any subpackage combination is installed.
^
No license file.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[?]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
^
Is this worth looking into?
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
^
Not tested this.
[Bug 1830322] Review Request: gap-pkg-ferret - Backtracking search in permutation groups
https://bugzilla.redhat.com/show_bug.cgi?id=1830322 Ankur Sinha (FranciscoD) changed: What|Removed |Added Status|NEW |ASSIGNED CC||sanjay.an...@gmail.com Doc Type|--- |If docs needed, set a value Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1830322] Review Request: gap-pkg-ferret - Backtracking search in permutation groups
https://bugzilla.redhat.com/show_bug.cgi?id=1830322 Jerry James changed: What|Removed |Added Blocks||1830323 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1830323 [Bug 1830323] Review Request: gap-pkg-images - Minimal and canonical images in permutation groups -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
