[Bug 1837793] Review Request: golang-github-xiaq-persistent - Persistent data structures for Go
https://bugzilla.redhat.com/show_bug.cgi?id=1837793 Fedora Update System changed: What|Removed |Added Resolution|RAWHIDE |ERRATA --- Comment #5 from Fedora Update System --- FEDORA-2020-5518ca9f02 has been pushed to the Fedora 32 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1837793] Review Request: golang-github-xiaq-persistent - Persistent data structures for Go
https://bugzilla.redhat.com/show_bug.cgi?id=1837793 --- Comment #4 from Fedora Update System --- FEDORA-2020-5518ca9f02 has been pushed to the Fedora 32 testing repository. In short time you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2020-5518ca9f02 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-5518ca9f02 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1837793] Review Request: golang-github-xiaq-persistent - Persistent data structures for Go
https://bugzilla.redhat.com/show_bug.cgi?id=1837793 --- Comment #3 from Fedora Update System --- FEDORA-2020-5518ca9f02 has been submitted as an update to Fedora 32. https://bodhi.fedoraproject.org/updates/FEDORA-2020-5518ca9f02 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1837793] Review Request: golang-github-xiaq-persistent - Persistent data structures for Go
https://bugzilla.redhat.com/show_bug.cgi?id=1837793 Carson Black changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |RAWHIDE Last Closed||2020-05-28 19:31:21 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1837793] Review Request: golang-github-xiaq-persistent - Persistent data structures for Go
https://bugzilla.redhat.com/show_bug.cgi?id=1837793 --- Comment #2 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-xiaq-persistent -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1837793] Review Request: golang-github-xiaq-persistent - Persistent data structures for Go
https://bugzilla.redhat.com/show_bug.cgi?id=1837793
Fabian Affolter changed:
What|Removed |Added
Flags|fedora-review? |fedora-review+
--- Comment #1 from Fabian Affolter ---
- Could you please double check the hashing mismatch for the source before the
import?
- "%global golicenses epl-v10.html" could replace the "%license epl-v10.html"
entry in the %files section. I guess that the go2rpm script was not able to
pick the file up. Not a blocker but would be more aligned with Go spec files.
Otherwise looks good, package APPROVED.
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
===
- Sources used to build the package match the upstream source, as provided
in the spec URL.
Note: Upstream MD5sum check error, diff is in
/home/fab/Documents/repos/reviews/1837793-golang-github-xiaq-
persistent/diff.txt
See: https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: There is no build directory. Running licensecheck on vanilla
upstream sources. Licenses found: "Unknown or generated". 1 files have
unknown license. Detailed output of licensecheck in
/home/fab/Documents/repos/reviews/1837793-golang-github-xiaq-
persistent/licensecheck.txt
[x]: Package does not own files or directories owned by other packages.
Note: Dirs in package are owned also by:
/usr/share/gocode/src/github.com(golang-github-dchest-uniuri-devel,
golang-github-gopherjs-devel, golang-github-glycerine-unsnap-stream-
[...]
golang-github-nkovacs-streamquote-devel, golang-github-10gen-escaper-
devel)
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[x]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license
[Bug 1837793] Review Request: golang-github-xiaq-persistent - Persistent data structures for Go
https://bugzilla.redhat.com/show_bug.cgi?id=1837793 Fabian Affolter changed: What|Removed |Added Status|NEW |ASSIGNED CC||m...@fabian-affolter.ch Assignee|nob...@fedoraproject.org|m...@fabian-affolter.ch Doc Type|--- |If docs needed, set a value Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1837793] Review Request: golang-github-xiaq-persistent - Persistent data structures for Go
https://bugzilla.redhat.com/show_bug.cgi?id=1837793 Carson Black changed: What|Removed |Added Blocks||1837798 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1837798 [Bug 1837798] Review Request: golang-github-elves-elvish - Elvish shell -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
