[Bug 1853555] Review Request: ghc-HsOpenSSL - Partial OpenSSL binding for Haskell
https://bugzilla.redhat.com/show_bug.cgi?id=1853555 Fedora Update System changed: What|Removed |Added Resolution|CURRENTRELEASE |ERRATA --- Comment #7 from Fedora Update System --- FEDORA-2020-ed6f5ca90f has been pushed to the Fedora 32 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1853555] Review Request: ghc-HsOpenSSL - Partial OpenSSL binding for Haskell
https://bugzilla.redhat.com/show_bug.cgi?id=1853555 --- Comment #6 from Fedora Update System --- FEDORA-2020-ed6f5ca90f has been pushed to the Fedora 32 testing repository. In short time you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2020-ed6f5ca90f` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-ed6f5ca90f See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1853555] Review Request: ghc-HsOpenSSL - Partial OpenSSL binding for Haskell
https://bugzilla.redhat.com/show_bug.cgi?id=1853555 --- Comment #5 from Fedora Update System --- FEDORA-2020-ed6f5ca90f has been submitted as an update to Fedora 32. https://bodhi.fedoraproject.org/updates/FEDORA-2020-ed6f5ca90f -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1853555] Review Request: ghc-HsOpenSSL - Partial OpenSSL binding for Haskell
https://bugzilla.redhat.com/show_bug.cgi?id=1853555 Jens Petersen changed: What|Removed |Added Status|MODIFIED|CLOSED Resolution|--- |CURRENTRELEASE Last Closed||2020-08-23 06:54:18 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1853555] Review Request: ghc-HsOpenSSL - Partial OpenSSL binding for Haskell
https://bugzilla.redhat.com/show_bug.cgi?id=1853555 Jens Petersen changed: What|Removed |Added Status|POST|MODIFIED Fixed In Version||ghc-HsOpenSSL-0.11.4.18-1.f ||c33 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1853555] Review Request: ghc-HsOpenSSL - Partial OpenSSL binding for Haskell
https://bugzilla.redhat.com/show_bug.cgi?id=1853555 --- Comment #4 from Jens Petersen --- (In reply to Robert-André Mauchin from comment #1) > - You've added: > # DSA test failing for Fedora > # https://github.com/vshabanov/HsOpenSSL/issues/49 > %bcond_with tests > but you're not using it in the %check part of the SPEC. The test seems to > work. Just to comment on this: so actually %cabal_test only runs the testsuite if the bcond is turned on. (Maybe I could revert to making the condition explicit in specs to make that more obvious, hm.) I am not sure why the DSA test only seems to fail on Fedora: maybe some patch we apply to openssl? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1853555] Review Request: ghc-HsOpenSSL - Partial OpenSSL binding for Haskell
https://bugzilla.redhat.com/show_bug.cgi?id=1853555 --- Comment #3 from Igor Raits --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/ghc-HsOpenSSL -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1853555] Review Request: ghc-HsOpenSSL - Partial OpenSSL binding for Haskell
https://bugzilla.redhat.com/show_bug.cgi?id=1853555 --- Comment #2 from Jens Petersen --- Thank you for the review https://pagure.io/releng/fedora-scm-requests/issue/26827 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1853555] Review Request: ghc-HsOpenSSL - Partial OpenSSL binding for Haskell
https://bugzilla.redhat.com/show_bug.cgi?id=1853555 Robert-André Mauchin changed: What|Removed |Added Status|NEW |POST CC||zebo...@gmail.com Assignee|nob...@fedoraproject.org|zebo...@gmail.com Flags||fedora-review+ --- Comment #1 from Robert-André Mauchin --- - You've added: # DSA test failing for Fedora # https://github.com/vshabanov/HsOpenSSL/issues/49 %bcond_with tests but you're not using it in the %check part of the SPEC. The test seems to work. Package approved. Package Review == Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed = MUST items = C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "*No copyright* Creative Commons CC0 Universal 1.0 Public Domain Dedication". 55 files have unknown license. Detailed output of licensecheck in /home/bob/packaging/review/ghc-HsOpenSSL/review-ghc- HsOpenSSL/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/share/doc/ghc(ghc-Agda- doc, ghc-aeson-better-errors-doc, ghc-bitarray-doc, ghc-js-jquery-doc, ghc-EdisonCore-doc, ghc-filepattern-doc, ghc-compiler, ghc-time- manager-doc, ghc-EdisonAPI-doc, ghc-lukko-doc, ghc-cborg-doc, ghc- http2-doc, ghc-geniplate-mirror-doc, ghc-cborg-json-doc, ghc-murmur- hash-doc, ghc-parsers-doc, ghc-dns-doc, ghc-serialise-doc, ghc-uri- encode-doc, ghc-HsYAML-doc, ghc-unicode-transforms-doc, ghc-js-flot- doc), /usr/share/doc/ghc/html(ghc-Agda-doc, ghc-aeson-better-errors- doc, ghc-bitarray-doc, ghc-js-jquery-doc, ghc-EdisonCore-doc, ghc- filepattern-doc, ghc-compiler, ghc-time-manager-doc, ghc-EdisonAPI- doc, ghc-lukko-doc, ghc-cborg-doc, ghc-http2-doc, ghc-geniplate- mirror-doc, ghc-cborg-json-doc, ghc-murmur-hash-doc, ghc-parsers-doc, ghc-dns-doc, ghc-serialise-doc, ghc-uri-encode-doc, ghc-HsYAML-doc, ghc-unicode-transforms-doc, ghc-js-flot-doc), /usr/share/doc/ghc/html/libraries(ghc-Agda-doc, ghc-aeson-better- errors-doc, ghc-bitarray-doc, ghc-js-jquery-doc, ghc-EdisonCore-doc, ghc-filepattern-doc, ghc-compiler, ghc-time-manager-doc, ghc- EdisonAPI-doc, ghc-lukko-doc, ghc-cborg-doc, ghc-http2-doc, ghc- geniplate-mirror-doc, ghc-cborg-json-doc, ghc-murmur-hash-doc, ghc- parsers-doc, ghc-dns-doc, ghc-serialise-doc, ghc-uri-encode-doc, ghc- HsYAML-doc, ghc-unicode-transforms-doc, ghc-js-flot-doc) [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [-]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 51200 bytes in 10 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are
