[Bug 750009] Review Request: libburn1 - Library for reading, mastering and writing optical discs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=750009



--- Comment #15 from Fedora Update System  ---
libburn1-1.4.6-5.el7 has been pushed to the Fedora EPEL 7 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 750009] Review Request: libburn1 - Library for reading, mastering and writing optical discs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=750009

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2017-09-13 04:19:11



--- Comment #14 from Fedora Update System  ---
libburn1-1.4.6-5.el6 has been pushed to the Fedora EPEL 6 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 750009] Review Request: libburn1 - Library for reading, mastering and writing optical discs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=750009



--- Comment #13 from Fedora Update System  ---
libburn1-1.4.6-5.el7 has been pushed to the Fedora EPEL 7 testing repository.
If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-f1a4921ad4

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 750009] Review Request: libburn1 - Library for reading, mastering and writing optical discs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=750009



--- Comment #12 from Fedora Update System  ---
libburn1-1.4.6-5.el6 has been pushed to the Fedora EPEL 6 testing repository.
If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-b45f479d6b

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 750009] Review Request: libburn1 - Library for reading, mastering and writing optical discs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=750009

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #11 from Fedora Update System  ---
libburn1-1.4.6-1.el6 has been pushed to the Fedora EPEL 6 testing repository.
If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-b45f479d6b

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 750009] Review Request: libburn1 - Library for reading, mastering and writing optical discs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=750009

Fedora Update System  changed:

   What|Removed |Added

 Status|POST|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 750009] Review Request: libburn1 - Library for reading, mastering and writing optical discs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=750009



--- Comment #10 from Fedora Update System  ---
libburn1-1.4.6-1.el6 has been submitted as an update to Fedora EPEL 6.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-b45f479d6b

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 750009] Review Request: libburn1 - Library for reading, mastering and writing optical discs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=750009



--- Comment #9 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/libburn1

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 750009] Review Request: libburn1 - Library for reading, mastering and writing optical discs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=750009

Robert Scheck  changed:

   What|Removed |Added

 CC||package-review@lists.fedora
   ||project.org
  Component|Package Review  |Package Review
Version|el6 |rawhide
Product|Fedora EPEL |Fedora



--- Comment #8 from Robert Scheck  ---
Unfortunately our new fancy fedrepo_req has a bug, thus I am incorrectly
updating "Fedora EPEL" -> "Fedora" to achieve successful SCM request, see
also https://pagure.io/fedrepo_req/issue/78 for the reported bug and/or
https://pagure.io/releng/fedora-scm-requests/issue/265 with the refusal.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 750009] Review Request: libburn1 - Library for reading, mastering and writing optical discs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=750009

Björn "besser82" Esser  changed:

   What|Removed |Added

 Status|ASSIGNED|POST
  Flags|fedora-review?  |fedora-review+



--- Comment #7 from Björn "besser82" Esser  ---
From a quick view over the spec-file:

* You can drop Group, BuildRoot, `rm -rf $RPM_BUILD_ROOT`, %clean
  and %defattr.

* You may want to strip %changelog from ancient entries.

* `%{!?_licensedir:%global license %%doc}` isn't needed anymore, simply
  use plain `%license`, which works on any dist now.

* `make %{?_smp_mflags}` should be `%make_build` now.

* `make install DESDIR=…` should be `%make_install` now.

* Explicit Requires: pkgconfig in -devel isn't needed anymore.

***

Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated


Issues:
===
- Package installs properly.
  Note: Installation errors (see attachment)
  See: https://fedoraproject.org/wiki/Packaging:Guidelines

  ---> That's due the need for a bootstrap-chroot for mock, when
   building for el6.

- If (and only if) the source package includes the text of the license(s)
  in its own file, then that file, containing the text of the license(s)
  for the package is included in %license.
  Note: License file COPYING is not marked as %license
  See:
  http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text

  ---> As stated in my comments about the spec file.

- Large documentation must go in a -doc subpackage. Large could be size
  (~1MB) or number of files.
  Note: Documentation size is 1884160 bytes in 43 files.
  See:
  http://fedoraproject.org/wiki/Packaging/Guidelines#PackageDocumentation

  ---> Well, one could argue about that…  Documentation is less than 2MiB.
   I don't see any issue with that.


= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Header files in -devel subpackage, if present.
[x]: ldconfig called in %post and %postun if required.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "MIT/X11 (BSD like)", "GPL (v2 or later)", "GPL (with incorrect
 FSF address)", "Unknown or generated". 114 files have unknown license.
 Detailed output of licensecheck in
 /home/besser82/fedora/review/750009-libburn1/licensecheck.txt

 ---> MIT/X11 is comming from an autotools script, GPLv2+ from libtool
  helper script.  According to the COPYRIGHT file GPLv2+ is fine.

[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[!]: Each %files section contains %defattr if rpm < 4.4
 Note: %defattr present but not needed

 ---> Please drop it.

[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines

 ---> Some minor issues are present, but those can be fixed during import.

[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 

[Bug 750009] Review Request: libburn1 - Library for reading, mastering and writing optical discs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=750009

Björn "besser82" Esser  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||besse...@fedoraproject.org
   Assignee|herr...@owlriver.com|besse...@fedoraproject.org
  Flags|needinfo?(herrold@owlriver. |
   |com)|



--- Comment #6 from Björn "besser82" Esser  ---
Taking this…

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 750009] Review Request: libburn1 - Library for reading, mastering and writing optical discs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=750009



--- Comment #5 from Robert Scheck  ---
Spec URL: http://labs.linuxnetz.de/bugzilla/libburn1.spec
SRPM URL: http://labs.linuxnetz.de/bugzilla/libburn1-1.4.6-1.src.rpm

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 750009] Review Request: libburn1 - Library for reading, mastering and writing optical discs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=750009



--- Comment #4 from Robert Scheck  ---
Russell, could you proceed with the review, please?

Spec URL: http://labs.linuxnetz.de/bugzilla/libburn1.spec
SRPM URL: http://labs.linuxnetz.de/bugzilla/libburn1-1.4.2-2.src.rpm

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 750009] Review Request: libburn1 - Library for reading, mastering and writing optical discs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=750009

Robert Scheck redhat-bugzi...@linuxnetz.de changed:

   What|Removed |Added

 CC||herr...@owlriver.com
  Flags||needinfo?(herrold@owlriver.
   ||com)



--- Comment #3 from Robert Scheck redhat-bugzi...@linuxnetz.de ---
Spec URL: http://labs.linuxnetz.de/bugzilla/libburn1.spec
SRPM URL: http://labs.linuxnetz.de/bugzilla/libburn1-1.4.0-2.src.rpm

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 750009] Review Request: libburn1 - Library for reading, mastering and writing optical discs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=750009

R P Herrold herr...@owlriver.com changed:

   What|Removed |Added

 CC||redhat-bugzilla@linuxnetz.d
   ||e
  Flags||needinfo?(redhat-bugzilla@l
   ||inuxnetz.de)



-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 750009] Review Request: libburn1 - Library for reading, mastering and writing optical discs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=750009

R P Herrold herr...@owlriver.com changed:

   What|Removed |Added

   Assignee|nob...@fedoraproject.org|herr...@owlriver.com
  Flags||fedora-review?



--- Comment #1 from R P Herrold herr...@owlriver.com ---
rpmlint notes
libburn1.src:76: W: macro-in-comment %doc
libburn1.src:13: W: mixed-use-of-spaces-and-tabs (spaces: line 13, tab: line 3)

Robert - could you attend to these and I'll finish the review

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 750009] Review Request: libburn1 - Library for reading, mastering and writing optical discs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=750009

Robert Scheck redhat-bugzi...@linuxnetz.de changed:

   What|Removed |Added

  Flags|needinfo?(redhat-bugzilla@l |
   |inuxnetz.de)|



--- Comment #2 from Robert Scheck redhat-bugzi...@linuxnetz.de ---
Spec URL: http://labs.linuxnetz.de/bugzilla/libburn1.spec
SRPM URL: http://labs.linuxnetz.de/bugzilla/libburn1-1.3.8-3.src.rpm

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review