[Bug 967153] Review Request: phrel - Per Host RatE Limiter
https://bugzilla.redhat.com/show_bug.cgi?id=967153 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 967153] Review Request: phrel - Per Host RatE Limiter
https://bugzilla.redhat.com/show_bug.cgi?id=967153 --- Comment #12 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 967153] Review Request: phrel - Per Host RatE Limiter
https://bugzilla.redhat.com/show_bug.cgi?id=967153 Christopher Meng i...@cicku.me changed: What|Removed |Added Flags|fedora-cvs+ |fedora-cvs? --- Comment #11 from Christopher Meng i...@cicku.me --- Package Change Request == Package Name: phrel New Branches: epel7 Owners: cicku -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 967153] Review Request: phrel - Per Host RatE Limiter
https://bugzilla.redhat.com/show_bug.cgi?id=967153 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version|phrel-1.0.1-1.fc19 |phrel-1.0.2-1.el6 --- Comment #10 from Fedora Update System upda...@fedoraproject.org --- phrel-1.0.2-1.el6 has been pushed to the Fedora EPEL 6 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=atyCysrVnta=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 967153] Review Request: phrel - Per Host RatE Limiter
https://bugzilla.redhat.com/show_bug.cgi?id=967153 --- Comment #7 from Fedora Update System upda...@fedoraproject.org --- phrel-1.0.2-1.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/phrel-1.0.2-1.el6 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=yGWm0oAOhba=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 967153] Review Request: phrel - Per Host RatE Limiter
https://bugzilla.redhat.com/show_bug.cgi?id=967153 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||phrel-1.0.1-1.fc18 Resolution|--- |ERRATA Last Closed||2013-06-07 19:53:37 --- Comment #8 from Fedora Update System upda...@fedoraproject.org --- phrel-1.0.1-1.fc18 has been pushed to the Fedora 18 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=yq5gvxHInYa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 967153] Review Request: phrel - Per Host RatE Limiter
https://bugzilla.redhat.com/show_bug.cgi?id=967153 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version|phrel-1.0.1-1.fc18 |phrel-1.0.1-1.fc19 --- Comment #9 from Fedora Update System upda...@fedoraproject.org --- phrel-1.0.1-1.fc19 has been pushed to the Fedora 19 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=BLd4werkw3a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 967153] Review Request: phrel - Per Host RatE Limiter
https://bugzilla.redhat.com/show_bug.cgi?id=967153 --- Comment #5 from Fedora Update System upda...@fedoraproject.org --- phrel-1.0.1-1.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/phrel-1.0.1-1.fc18 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=cVPrmAHSM6a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 967153] Review Request: phrel - Per Host RatE Limiter
https://bugzilla.redhat.com/show_bug.cgi?id=967153 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #6 from Fedora Update System upda...@fedoraproject.org --- phrel-1.0.1-1.fc19 has been pushed to the Fedora 19 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=P3oncExGA4a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 967153] Review Request: phrel - Per Host RatE Limiter
https://bugzilla.redhat.com/show_bug.cgi?id=967153 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? | Flags||fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=h0LSH78my9a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 967153] Review Request: phrel - Per Host RatE Limiter
https://bugzilla.redhat.com/show_bug.cgi?id=967153 --- Comment #3 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=WGPT8rnpWza=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 967153] Review Request: phrel - Per Host RatE Limiter
https://bugzilla.redhat.com/show_bug.cgi?id=967153 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=rSSMun1LoOa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 967153] Review Request: phrel - Per Host RatE Limiter
https://bugzilla.redhat.com/show_bug.cgi?id=967153 --- Comment #4 from Fedora Update System upda...@fedoraproject.org --- phrel-1.0.1-1.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/phrel-1.0.1-1.fc19 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ZGgKEcgu8Va=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 967153] Review Request: phrel - Per Host RatE Limiter
https://bugzilla.redhat.com/show_bug.cgi?id=967153
Douglas Schilling Landgraf dougsl...@redhat.com changed:
What|Removed |Added
Flags||fedora-review+
--- Comment #1 from Douglas Schilling Landgraf dougsl...@redhat.com ---
Package reviewed manually + fedora-review tool.
[OK] MUST: rpmlint must be run on the source rpm and all binary rpms the build
produces. The output should be posted in the review.
Checking: phrel-1.0.1-1.fc18.x86_64.rpm
phrel.x86_64: W: spelling-error %description -l en_US login - loin, logic, lo
gin
phrel.x86_64: W: spelling-error %description -l en_US syncronization -
synchronization, systematization
phrel.x86_64: W: only-non-binary-in-usr-lib
phrel.x86_64: E: incorrect-fsf-address /usr/share/doc/phrel-1.0.1/COPYING
phrel.x86_64: E: incorrect-fsf-address /usr/share/doc/phrel-1.0.1/README
1 packages and 0 specfiles checked; 2 errors, 3 warnings.
Rpmlint (installed packages)
# rpmlint phrel
phrel.x86_64: W: spelling-error %description -l en_US login - loin, logic, lo
gin
phrel.x86_64: W: spelling-error %description -l en_US syncronization -
synchronization, systematization
phrel.x86_64: W: only-non-binary-in-usr-lib
phrel.x86_64: E: incorrect-fsf-address /usr/share/doc/phrel-1.0.1/COPYING
phrel.x86_64: E: incorrect-fsf-address /usr/share/doc/phrel-1.0.1/README
1 packages and 0 specfiles checked; 2 errors, 3 warnings.
*** Please see my suggestion in the end of this review.
[OK] MUST: The package must be named according to the Package Naming Guidelines
.
[OK] MUST: The spec file name must match the base package %{name}, in the
format %{name}.spec unless your package has an exemption
[OK] MUST: The package must meet the Packaging Guidelines .
[OK] MUST: The package must be licensed with a Fedora approved license and meet
the Licensing Guidelines .
[OK] MUST: The License field in the package spec file must match the actual
license.
[OK] MUST: The spec file must be written in American English.
[OK] MUST: The spec file for the package MUST be legible.
[OK] MUST: The sources used to build the package must match the upstream
source, as provided in the spec URL. Reviewers should use sha256sum for this
task as it is used by the sources file once imported into git. If no upstream
URL can be specified for this package, please see the Source URL Guidelines for
how to deal with this.
[OK] MUST: The package MUST successfully compile and build into binary rpms on
at least one primary architecture.
[OK] MUST: All build dependencies must be listed in BuildRequires, except for
any that are listed in the exceptions section of the Packaging Guidelines ;
inclusion of those as BuildRequires is optional. Apply common sense.
[OK] MUST: Packages must NOT bundle copies of system libraries.
[OK] MUST: A package must own all directories that it creates. If it does not
create a directory that it uses, then it should require a package which does
create that directory.
[OK] MUST: A Fedora package must not list a file more than once in the spec
file's %files listings. (Notable exception: license texts in specific
situations
[OK] MUST: Each package must consistently use macros
[OK] MUST: The package must contain code, or permissable content.
[OK] MUST: Packages must NOT contain any .la libtool archives, these must be
removed in the spec if they are built
[OK] MUST: All filenames in rpm packages must be valid UTF-8.
Should
=
[OK]: Latest version is packaged.
[OK]: Package does not include license text files separate from upstream.
[OK]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[OK]: Sources can be downloaded from URI in Source: tag
[OK]: Reviewer should test that the package builds in mock.
[OK]: Buildroot is not present
[OK]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[OK]: Dist tag is present.
[OK]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[OK]: Uses parallel make.
[OK]: SourceX tarball generation or download is documented.
[OK]: SourceX is a working URL.
[OK]: Spec use %global instead of %define.
Just a minor comment:
Can you please notify upstream to update FSF address?
phrel.x86_64: E: incorrect-fsf-address /usr/share/doc/phrel-1.0.1/README
For more info:
http://fedoraproject.org/wiki/Common_Rpmlint_issues#incorrect-fsf-address
The above minor comment can be fixed in parallel of packaging.
Status: APPROVED.
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=pgFqbJ41uua=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 967153] Review Request: phrel - Per Host RatE Limiter
https://bugzilla.redhat.com/show_bug.cgi?id=967153 Christopher Meng cicku...@gmail.com changed: What|Removed |Added Flags||fedora-cvs? --- Comment #2 from Christopher Meng cicku...@gmail.com --- New Package SCM Request === Package Name: phrel Short Description: Per Host RatE Limiter Owners: cicku Branches: f18 f19 el6 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=YdM4Z55Sfsa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 967153] Review Request: phrel - Per Host RatE Limiter
https://bugzilla.redhat.com/show_bug.cgi?id=967153 Douglas Schilling Landgraf dougsl...@redhat.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||dougsl...@redhat.com Assignee|nob...@fedoraproject.org|dougsl...@redhat.com -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=5KOM9gHD8Ha=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
