[Bug 1055838] Review Request: ghc-time-compat - Compatibility with old-time for the time package

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1055838

Jens Petersen  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |CURRENTRELEASE
Last Closed|2014-04-01 23:22:41 |2018-09-21 08:03:19



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1055838] Review Request: ghc-time-compat - Compatibility with old-time for the time package

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1055838

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #10 from Fedora Update System  ---
ghc-time-compat-0.1.0.3-6.fc27 has been pushed to the Fedora 27 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-f3d5998600

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1055838] Review Request: ghc-time-compat - Compatibility with old-time for the time package

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1055838

Fedora Update System  changed:

   What|Removed |Added

 Status|POST|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1055838] Review Request: ghc-time-compat - Compatibility with old-time for the time package

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1055838



--- Comment #9 from Fedora Update System  ---
ghc-time-compat-0.1.0.3-6.fc27 has been submitted as an update to Fedora 27.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-f3d5998600

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1055838] Review Request: ghc-time-compat - Compatibility with old-time for the time package

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1055838



--- Comment #8 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/ghc-time-compat. You may commit to the
branch "f27" in about 10 minutes.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1055838] Review Request: ghc-time-compat - Compatibility with old-time for the time package

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1055838



--- Comment #7 from Jens Petersen  ---
Thanks a lot!

https://pagure.io/releng/fedora-scm-requests/issue/2279

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1055838] Review Request: ghc-time-compat - Compatibility with old-time for the time package

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1055838

Elliott Sales de Andrade  changed:

   What|Removed |Added

 Status|ASSIGNED|POST
 Whiteboard|BuildFails  |
  Flags|fedora-review?  |fedora-review+



--- Comment #6 from Elliott Sales de Andrade  ---
Approved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1055838] Review Request: ghc-time-compat - Compatibility with old-time for the time package

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1055838



--- Comment #5 from Jens Petersen  ---
Thanks

Spec:
http://petersen.fedorapeople.org/reviews/ghc-time-compat/ghc-time-compat.spec
SRPM:
http://petersen.fedorapeople.org/reviews/ghc-time-compat/ghc-time-compat-0.1.0.3-1.fc26.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1055838] Review Request: ghc-time-compat - Compatibility with old-time for the time package

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1055838

Elliott Sales de Andrade  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1055838] Review Request: ghc-time-compat - Compatibility with old-time for the time package

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1055838

Elliott Sales de Andrade  changed:

   What|Removed |Added

 Whiteboard||BuildFails



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1055838] Review Request: ghc-time-compat - Compatibility with old-time for the time package

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1055838

Elliott Sales de Andrade  changed:

   What|Removed |Added

 CC||quantum.anal...@gmail.com
   Assignee|nob...@fedoraproject.org|quantum.anal...@gmail.com
  Flags||fedora-review?



--- Comment #4 from Elliott Sales de Andrade  ---
> %doc LICENSE

Should be changed to %license now, or it doesn't build. Probably want to
regenerate with latest template as well.



Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
 Note: Unversioned so-files in private %_libdir subdirectory (see
 attachment). Verify they are not in ld path.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "BSD (2 clause)", "Unknown or generated". 3 files have unknown
 license. Detailed output of licensecheck in
 1055838-ghc-time-compat/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[-]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 61440 bytes in 12 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is 

[Bug 1055838] Review Request: ghc-time-compat - Compatibility with old-time for the time package

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1055838

Jens Petersen  changed:

   What|Removed |Added

 Blocks||1153948




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1153948
[Bug 1153948] ghc-happstack-server-7.4.6.2 is available
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1055838] Review Request: ghc-time-compat - Compatibility with old-time for the time package

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1055838

Jens Petersen  changed:

   What|Removed |Added

 Status|CLOSED  |NEW
 Resolution|WONTFIX |---
   Keywords||Reopened



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1055838] Review Request: ghc-time-compat - Compatibility with old-time for the time package

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1055838

Jens Petersen peter...@redhat.com changed:

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution|--- |WONTFIX
Last Closed||2014-04-01 23:22:41



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1055838] Review Request: ghc-time-compat - Compatibility with old-time for the time package

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1055838

Jens Petersen peter...@redhat.com changed:

   What|Removed |Added

   Priority|unspecified |low



--- Comment #3 from Jens Petersen peter...@redhat.com ---
Bit like transformers-compat I wonder if we can't get anyway with
patching happstack-server for this instead.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1055838] Review Request: ghc-time-compat - Compatibility with old-time for the time package

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1055838

Jens Petersen peter...@redhat.com changed:

   What|Removed |Added

 Whiteboard|Ready   |



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1055838] Review Request: ghc-time-compat - Compatibility with old-time for the time package

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1055838



--- Comment #1 from Jens Petersen peter...@redhat.com ---
This package built on koji: 
http://koji.fedoraproject.org/koji/taskinfo?taskID=6432867

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1055838] Review Request: ghc-time-compat - Compatibility with old-time for the time package

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1055838

Jens Petersen peter...@redhat.com changed:

   What|Removed |Added

 CC||haskell-devel@lists.fedorap
   ||roject.org
 Blocks||892586
 Whiteboard||Ready



--- Comment #2 from Jens Petersen peter...@redhat.com ---
Needed by happstack-server  7.1.0


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=892586
[Bug 892586] ghc-happstack-server-7.3.2 is available
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1055838] Review Request: ghc-time-compat - Compatibility with old-time for the time package

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1055838

Jens Petersen peter...@redhat.com changed:

   What|Removed |Added

  Alias||ghc-time-compat



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review