[Bug 1267468] Review Request: rubygem-codeclimate-test-reporter - Uploads Ruby test coverage data to Code Climate

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1267468

Mattia Verga  changed:

   What|Removed |Added

 Status|POST|CLOSED
 Resolution|--- |CURRENTRELEASE
Last Closed||2021-06-07 13:08:22



--- Comment #15 from Mattia Verga  ---
Package imported, closing ticket.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure

[Bug 1267468] Review Request: rubygem-codeclimate-test-reporter - Uploads Ruby test coverage data to Code Climate

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1267468



--- Comment #14 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/rubygem-codeclimate-test-reporter

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1267468] Review Request: rubygem-codeclimate-test-reporter - Uploads Ruby test coverage data to Code Climate

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1267468

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|ASSIGNED|POST
  Flags|fedora-review?  |fedora-review+



--- Comment #13 from Robert-André Mauchin  ---
Ok, package approved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1267468] Review Request: rubygem-codeclimate-test-reporter - Uploads Ruby test coverage data to Code Climate

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1267468



--- Comment #12 from Ilya Gradina  ---
thx,

I fixed dependency resolution fails, and removed Group section.

new srpm:
https://github.com/ilgrad/fedora-packages/raw/master/rubygems/rubygem-codeclimate-test-reporter-1.0.8-2.fc28.src.rpm
new spec:
https://github.com/ilgrad/fedora-packages/raw/master/rubygems/rubygem-codeclimate-test-reporter.spec

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1267468] Review Request: rubygem-codeclimate-test-reporter - Uploads Ruby test coverage data to Code Climate

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1267468

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||zebo...@gmail.com
   Assignee|nob...@fedoraproject.org|zebo...@gmail.com
  Flags||fedora-review?



--- Comment #11 from Robert-André Mauchin  ---
 - Group: is not needed anymore

 - The package fails to install:

DEBUG util.py:479:  Error: 
DEBUG util.py:479:   Problem 1: conflicting requests
DEBUG util.py:479:- nothing provides rubygem(simplecov) <= 0.13 needed by
rubygem-codeclimate-test-reporter-1.0.8-1.fc28.noarch
DEBUG util.py:479:   Problem 2: package
rubygem-codeclimate-test-reporter-doc-1.0.8-1.fc28.noarch requires
rubygem-codeclimate-test-reporter = 1.0.8-1.fc28, but none of the providers can
be installed
DEBUG util.py:479:- conflicting requests
DEBUG util.py:479:- nothing provides rubygem(simplecov) <= 0.13 needed by
rubygem-codeclimate-test-reporter-1.0.8-1.fc28.noarch
DEBUG util.py:617:  Child return code was: 1


It seems the version of simplecov in Koji is indeed 0.13.0, but the dependency
resolution fails with "<= 0.13". You should relax the dependency in the gemspec
to be 0.13.0.

I've successfully used the following patch to do it:

diff -up ./codeclimate-test-reporter.gemspec.fix_require
./codeclimate-test-reporter.gemspec
--- ./codeclimate-test-reporter.gemspec.fix_require2018-01-08
17:47:53.0 +0100
+++ ./codeclimate-test-reporter.gemspec2018-01-08 17:48:48.523257739 +0100
@@ -23,7 +23,7 @@ Gem::Specification.new do |s|
 s.specification_version = 4

 if Gem::Version.new(Gem::VERSION) >= Gem::Version.new('1.2.0') then
-  s.add_runtime_dependency(%q.freeze, ["<= 0.13"])
+  s.add_runtime_dependency(%q.freeze, ["<= 0.13.0"])
   s.add_development_dependency(%q.freeze, [">= 0"])
   s.add_development_dependency(%q.freeze, [">= 0"])
   s.add_development_dependency(%q.freeze, [">= 0"])





Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
===
- Package installs properly.
  Note: Installation errors (see attachment)
  See: https://fedoraproject.org/wiki/Packaging:Guidelines


= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: There is no build directory. Running licensecheck on vanilla
 upstream sources. No licenses found. Please check the source files for
 licenses manually.
[x]: License file installed when any subpackage combination is installed.
[x]: Package must own all directories that it creates.
 Note: Directories without known owners: /usr/share/gems,
 /usr/share/gems/doc
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: 

[Bug 1267468] Review Request: rubygem-codeclimate-test-reporter - Uploads Ruby test coverage data to Code Climate

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1267468

Germano Massullo  changed:

   What|Removed |Added

 Status|ASSIGNED|NEW
 CC||germano.massu...@gmail.com
  Flags|fedora-review?  |



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1267468] Review Request: rubygem-codeclimate-test-reporter - Uploads Ruby test coverage data to Code Climate

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1267468

Germano Massullo  changed:

   What|Removed |Added

 CC|germano.massu...@gmail.com  |
   Assignee|germano.massu...@gmail.com  |nob...@fedoraproject.org
  Flags|needinfo?(germano.massullo@ |
   |gmail.com)  |



--- Comment #10 from Germano Massullo  ---
Hi Ilya, unfortunately I have to drop this package review process

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1267468] Review Request: rubygem-codeclimate-test-reporter - Uploads Ruby test coverage data to Code Climate

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1267468

Ilya Gradina  changed:

   What|Removed |Added

  Flags|fedora-review-  |fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1267468] Review Request: rubygem-codeclimate-test-reporter - Uploads Ruby test coverage data to Code Climate

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1267468



--- Comment #9 from Ilya Gradina  ---
the package looks good, only tests disabled, while you can do without them.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1267468] Review Request: rubygem-codeclimate-test-reporter - Uploads Ruby test coverage data to Code Climate

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1267468

Ilya Gradina  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review-



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1267468] Review Request: rubygem-codeclimate-test-reporter - Uploads Ruby test coverage data to Code Climate

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1267468

Germano Massullo  changed:

   What|Removed |Added

  Flags||needinfo?(germano.massullo@
   ||gmail.com)



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1267468] Review Request: rubygem-codeclimate-test-reporter - Uploads Ruby test coverage data to Code Climate

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1267468



--- Comment #8 from Ilya Gradina  ---
Hi, thx!

new srpm:
https://github.com/ilgrad/fedora-packages/raw/master/rubygems/rubygem-codeclimate-test-reporter-1.0.8-1.fc26.src.rpm

new spec:
https://raw.githubusercontent.com/ilgrad/fedora-packages/master/rubygems/rubygem-codeclimate-test-reporter.spec

error with tests: https://github.com/codeclimate/ruby-test-reporter/issues/191


- temporarily disabled tests
- update to 1.0.8

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1267468] Review Request: rubygem-codeclimate-test-reporter - Uploads Ruby test coverage data to Code Climate

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1267468

Germano Massullo  changed:

   What|Removed |Added

  Flags|needinfo?(germano.massullo@ |
   |gmail.com)  |



--- Comment #7 from Germano Massullo  ---
(In reply to Ilya Gradina from comment #4)
> New SRPM:
> https://github.com/ilgrad/fedora-packages/raw/master/rubygems/rubygem-
> codeclimate-test-reporter-0.6.0-1.fc26.src.rpm

Fedora review fails with various build errors, please fix them
Thank you

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1267468] Review Request: rubygem-codeclimate-test-reporter - Uploads Ruby test coverage data to Code Climate

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1267468



--- Comment #6 from Germano Massullo  ---
Hi, I will submit a review in next hours

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1267468] Review Request: rubygem-codeclimate-test-reporter - Uploads Ruby test coverage data to Code Climate

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1267468

Ilya Gradina  changed:

   What|Removed |Added

  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1267468] Review Request: rubygem-codeclimate-test-reporter - Uploads Ruby test coverage data to Code Climate

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1267468

Ilya Gradina  changed:

   What|Removed |Added

  Flags||needinfo?(germano.massullo@
   ||gmail.com)



--- Comment #5 from Ilya Gradina  ---
ping?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1267468] Review Request: rubygem-codeclimate-test-reporter - Uploads Ruby test coverage data to Code Climate

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1267468

Ilya Gradina  changed:

   What|Removed |Added

  Flags|needinfo?(ilya.gradina@gmai |
   |l.com)  |



--- Comment #4 from Ilya Gradina  ---
Hi Germano,

New Spec:
https://raw.githubusercontent.com/ilgrad/fedora-packages/master/rubygems/rubygem-codeclimate-test-reporter.spec
New SRPM:
https://github.com/ilgrad/fedora-packages/raw/master/rubygems/rubygem-codeclimate-test-reporter-0.6.0-1.fc26.src.rpm

But error in tests: http://paste.fedoraproject.org/427771/80700214/
I will try it to fix soon.
txh)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1267468] Review Request: rubygem-codeclimate-test-reporter - Uploads Ruby test coverage data to Code Climate

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1267468



--- Comment #3 from Germano Massullo  ---
I am sorry, I just had a talk with Francesco Locati (FAS fale) and he explained
me that the additional dependencies I added in my spec file, are not required.
Could you please build a source RPM against newest codeclimate-test-reporter
0.5.2?
Thanks
https://rubygems.org/gems/codeclimate-test-reporter/versions/0.5.2

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1267468] Review Request: rubygem-codeclimate-test-reporter - Uploads Ruby test coverage data to Code Climate

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1267468

Germano Massullo  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||ilya.grad...@gmail.com
  Flags||needinfo?(ilya.gradina@gmai
   ||l.com)



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1267468] Review Request: rubygem-codeclimate-test-reporter - Uploads Ruby test coverage data to Code Climate

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1267468



--- Comment #2 from Germano Massullo  ---
Created attachment 1169604
  --> https://bugzilla.redhat.com/attachment.cgi?id=1169604=edit
spec file with missing dependencies

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1267468] Review Request: rubygem-codeclimate-test-reporter - Uploads Ruby test coverage data to Code Climate

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1267468

Germano Massullo  changed:

   What|Removed |Added

 CC||germano.massu...@gmail.com
   Assignee|nob...@fedoraproject.org|germano.massu...@gmail.com



--- Comment #1 from Germano Massullo  ---
Hi, I was filling a Review Request for codeclimate-test-reporter when I saw
your Review Request. So we can work together on this and hopefully maintain the
package together :-)
I attach a spec file with missing dependencies, if you can use it and
re-generate the src.rpm file.
Thank you!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1267468] Review Request: rubygem-codeclimate-test-reporter - Uploads Ruby test coverage data to Code Climate

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1267468

Ilya Gradina  changed:

   What|Removed |Added

 Blocks||1268674




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1268674
[Bug 1268674] Review Request: rubygem-jwt - JSON Web Token implementation
in Ruby
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review