[Bug 1336161] Review Request: golang-github-ThomsonReutersEikon-go-ntlm - Native implementation of NTLM for Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1336161

Elliott Sales de Andrade  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |DUPLICATE
Last Closed||2017-08-31 02:37:00



--- Comment #6 from Elliott Sales de Andrade  ---
Closing in favour of new review.

*** This bug has been marked as a duplicate of bug 1486511 ***

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1336161] Review Request: golang-github-ThomsonReutersEikon-go-ntlm - Native implementation of NTLM for Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1336161



--- Comment #5 from Elliott Sales de Andrade  ---
Apologies, I didn't notice that tito bumped the version instead of the release;
here is a corrected spec:

Spec URL:
https://copr-be.cloud.fedoraproject.org/results/qulogic/git-lfs/fedora-26-x86_64/00591448-golang-github-ThomsonReutersEikon-go-ntlm/golang-github-ThomsonReutersEikon-go-ntlm.spec
SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/qulogic/git-lfs/fedora-26-x86_64/00591448-golang-github-ThomsonReutersEikon-go-ntlm/golang-github-ThomsonReutersEikon-go-ntlm-0-0.2.gitb00ec39.fc26.src.rpm
Description: Native implementation of NTLM for Go.
Fedora Account System Username: qulogic

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1336161] Review Request: golang-github-ThomsonReutersEikon-go-ntlm - Native implementation of NTLM for Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1336161

Elliott Sales de Andrade  changed:

   What|Removed |Added

 CC||quantum.anal...@gmail.com



--- Comment #4 from Elliott Sales de Andrade  ---
Here is an updated SPEC/SRPM for you:

Spec URL:
https://copr-be.cloud.fedoraproject.org/results/qulogic/git-lfs/fedora-26-x86_64/00591446-golang-github-ThomsonReutersEikon-go-ntlm/golang-github-ThomsonReutersEikon-go-ntlm.spec
SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/qulogic/git-lfs/fedora-26-x86_64/00591446-golang-github-ThomsonReutersEikon-go-ntlm/golang-github-ThomsonReutersEikon-go-ntlm-1-0.2.gitb00ec39.fc26.src.rpm
Description: Native implementation of NTLM for Go.
Fedora Account System Username: qulogic

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1336161] Review Request: golang-github-ThomsonReutersEikon-go-ntlm - Native implementation of NTLM for Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1336161



--- Comment #3 from Igor Gnatenko  ---
(In reply to clime from comment #2)
> Can this be pushed? Or do you want to hand it over, Igor?
Please, someone take over this ;)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1336161] Review Request: golang-github-ThomsonReutersEikon-go-ntlm - Native implementation of NTLM for Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1336161

cl...@redhat.com changed:

   What|Removed |Added

 CC||cl...@redhat.com



--- Comment #2 from cl...@redhat.com ---
Can this be pushed? Or do you want to hand it over, Igor?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1336161] Review Request: golang-github-ThomsonReutersEikon-go-ntlm - Native implementation of NTLM for Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1336161



--- Comment #1 from Jan Chaloupka  ---
Summary:
- licence OK
- will not build in epel6 (%license macro is not defined)
- usually structure (with_* removed)
- version is ok (hard to decode the version number from jenkins-ci-2 [1]

Nits:
- unit-test does not have license and docs (add %license License and %doc
README.md as well)

Running rpmlint
golang-github-ThomsonReutersEikon-go-ntlm-0-0.1.gitb00ec39.fc20.src.rpm
golang-github-ThomsonReutersEikon-go-ntlm-devel-0-0.1.gitb00ec39.fc20.noarch.rpm
golang-github-ThomsonReutersEikon-go-ntlm-unit-test-devel-0-0.1.gitb00ec39.fc20.x86_64.rpm
golang-github-ThomsonReutersEikon-go-ntlm-unit-test-devel.x86_64: W:
no-documentation
3 packages and 0 specfiles checked; 0 errors, 1 warnings.

Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=14858213

Up to the nit LGTM.

[1] https://github.com/ThomsonReutersEikon/go-ntlm/releases/tag/jenkins-ci-2

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1336161] Review Request: golang-github-ThomsonReutersEikon-go-ntlm - Native implementation of NTLM for Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1336161

Jan Chaloupka  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||jchal...@redhat.com
   Assignee|nob...@fedoraproject.org|jchal...@redhat.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1336161] Review Request: golang-github-ThomsonReutersEikon-go-ntlm - Native implementation of NTLM for Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1336161

Igor Gnatenko  changed:

   What|Removed |Added

 Blocks||1336168 (git-lfs)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1336168
[Bug 1336168] Review Request: git-lfs - Git extension for versioning large
files
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org