[Bug 1343977] Review Request: asciidoctor-mallard - A Project Mallard converter for AsciiDoc
https://bugzilla.redhat.com/show_bug.cgi?id=1343977 Tummala Dhanvi (c0mrad3) changed: What|Removed |Added Depends On||177841 (FE-NEEDSPONSOR) Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1343977] Review Request: asciidoctor-mallard - A Project Mallard converter for AsciiDoc
https://bugzilla.redhat.com/show_bug.cgi?id=1343977 --- Comment #8 from Tummala Dhanvi (c0mrad3) --- I have added the testing part by adding this line ruby -Ilib -e 'Dir.glob "./test/*.rb"' Hope it should do it. Updated packages here https://dhanvi.fedorapeople.org/packages/asciidoctor-mallard/ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1343977] Review Request: asciidoctor-mallard - A Project Mallard converter for AsciiDoc
https://bugzilla.redhat.com/show_bug.cgi?id=1343977 Julien Enselme changed: What|Removed |Added Blocks||1346060 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1346060 [Bug 1346060] Review Request: python-pintail-asciidoc - Use AsciiDoc pages in Pintail sites -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1343977] Review Request: asciidoctor-mallard - A Project Mallard converter for AsciiDoc
https://bugzilla.redhat.com/show_bug.cgi?id=1343977 Vít Ondruch changed: What|Removed |Added Flags|needinfo?(vondruch@redhat.c | |om) | --- Comment #7 from Vít Ondruch --- (In reply to Tummala Dhanvi (c0mrad3) from comment #6) Thx, but I still can't see any test suite executed. Is there some reason for that? Please note that in case of Ruby packages, the test suite is the only thing which can assure that the package works. There is no compiler which would at least partly cover your back ... -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1343977] Review Request: asciidoctor-mallard - A Project Mallard converter for AsciiDoc
https://bugzilla.redhat.com/show_bug.cgi?id=1343977 Tummala Dhanvi (c0mrad3) changed: What|Removed |Added Flags||needinfo?(vondruch@redhat.c ||om) --- Comment #6 from Tummala Dhanvi (c0mrad3) --- I have updated the spec and built it spec: https://dhanvi.fedorapeople.org/packages/asciidoctor-mallard/asciidoctor-mallard.spec srpm: https://dhanvi.fedorapeople.org/packages/asciidoctor-mallard/asciidoctor-mallard.spec -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1343977] Review Request: asciidoctor-mallard - A Project Mallard converter for AsciiDoc
https://bugzilla.redhat.com/show_bug.cgi?id=1343977 Tummala Dhanvi (c0mrad3) changed: What|Removed |Added Flags|needinfo?(dhanvicse@gmail.c | |om) | --- Comment #5 from Tummala Dhanvi (c0mrad3) --- (In reply to William Moreno from comment #4) > Hi dhanvi, there is a lot of time since last update, do you want to continue > with this review? If not I can take care of it. Hello William, I would like to continue with this review, but I might need your help for the same. > > Please remenber than acording to the Stalle Package Review process(0) if you > do not reponse in one week I can close this review a open a new one. I will update the spec file and continue with the feedback process before the end of this week > > Regards > > 0: https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1343977] Review Request: asciidoctor-mallard - A Project Mallard converter for AsciiDoc
https://bugzilla.redhat.com/show_bug.cgi?id=1343977 William Moreno changed: What|Removed |Added CC||williamjmore...@gmail.com Flags||needinfo?(dhanvicse@gmail.c ||om) --- Comment #4 from William Moreno --- Hi dhanvi, there is a lot of time since last update, do you want to continue with this review? If not I can take care of it. Please remenber than acording to the Stalle Package Review process(0) if you do not reponse in one week I can close this review a open a new one. Regards 0: https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1343977] Review Request: asciidoctor-mallard - A Project Mallard converter for AsciiDoc
https://bugzilla.redhat.com/show_bug.cgi?id=1343977 Vít Ondruch changed: What|Removed |Added CC||vondr...@redhat.com --- Comment #3 from Vít Ondruch --- Hi Tummala, This looks to be output of gem2rpm without any modification. Unfortunately, this is not acceptable for official review and I can spot several issues on the first look: 1. The .spec file naming. 2. Test suite is not executed. 3. License is not marked by %license macro. 4. License file is not included in the main package. I'd appreciate if you can try to do package self review prior sending package for official review [1]. Actually, it does not look you are sponsored into package group yet, so I suggest you to follow these instructions [2], where you can find plenty of useful links. [1] http://fedoraproject.org/wiki/Packaging:ReviewGuidelines [2] https://fedoraproject.org/wiki/Join_the_package_collection_maintainers -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1343977] Review Request: asciidoctor-mallard - A Project Mallard converter for AsciiDoc
https://bugzilla.redhat.com/show_bug.cgi?id=1343977 --- Comment #2 from Tummala Dhanvi (c0mrad3) --- The Spec URL is now not showing a 404, just to be sure I have added them else where Spec URL : https://dhanvi.fedorapeople.org/packages/asciidoctor-mallard/asciidoctor-mallard.spec SRPM URL : https://dhanvi.fedorapeople.org/packages/asciidoctor-mallard/rubygem-asciidoctor-mallard-0.1.0.dev-1.fc24.src.rpm Description: An extension for Asciidoctor that converts AsciiDoc documents to Mallard 1.0 Fedora Account System Username: dhanvi -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1343977] Review Request: asciidoctor-mallard - A Project Mallard converter for AsciiDoc
https://bugzilla.redhat.com/show_bug.cgi?id=1343977 Mario Blättermann changed: What|Removed |Added CC||mario.blaetterm...@gmail.co ||m --- Comment #1 from Mario Blättermann --- The spec file location is 404. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
