[Bug 1346407] Review Request: stress-ng - Stress test a computer system in various ways
https://bugzilla.redhat.com/show_bug.cgi?id=1346407 --- Comment #30 from Fedora Update System --- stress-ng-0.07.29-1.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1346407] Review Request: stress-ng - Stress test a computer system in various ways
https://bugzilla.redhat.com/show_bug.cgi?id=1346407 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed|2016-12-01 17:21:04 |2017-04-26 14:20:54 --- Comment #29 from Fedora Update System --- stress-ng-0.07.29-1.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1346407] Review Request: stress-ng - Stress test a computer system in various ways
https://bugzilla.redhat.com/show_bug.cgi?id=1346407 --- Comment #28 from Fedora Update System --- stress-ng-0.07.29-1.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-e3d9412367 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1346407] Review Request: stress-ng - Stress test a computer system in various ways
https://bugzilla.redhat.com/show_bug.cgi?id=1346407 Fedora Update System changed: What|Removed |Added Status|CLOSED |ON_QA Resolution|ERRATA |--- Keywords||Reopened --- Comment #27 from Fedora Update System --- stress-ng-0.07.29-1.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-9f60124841 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1346407] Review Request: stress-ng - Stress test a computer system in various ways
https://bugzilla.redhat.com/show_bug.cgi?id=1346407 --- Comment #26 from Fedora Update System --- stress-ng-0.07.29-1.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2017-9f60124841 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1346407] Review Request: stress-ng - Stress test a computer system in various ways
https://bugzilla.redhat.com/show_bug.cgi?id=1346407 --- Comment #25 from Fedora Update System --- stress-ng-0.07.29-1.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-e3d9412367 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1346407] Review Request: stress-ng - Stress test a computer system in various ways
https://bugzilla.redhat.com/show_bug.cgi?id=1346407 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2016-12-01 17:21:04 --- Comment #24 from Fedora Update System --- stress-ng-0.07.05-3.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1346407] Review Request: stress-ng - Stress test a computer system in various ways
https://bugzilla.redhat.com/show_bug.cgi?id=1346407 --- Comment #23 from Fedora Update System --- stress-ng-0.07.05-3.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-7960f25459 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1346407] Review Request: stress-ng - Stress test a computer system in various ways
https://bugzilla.redhat.com/show_bug.cgi?id=1346407 --- Comment #22 from Fedora Update System --- stress-ng-0.07.05-3.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-0663121c05 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1346407] Review Request: stress-ng - Stress test a computer system in various ways
https://bugzilla.redhat.com/show_bug.cgi?id=1346407 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #21 from Fedora Update System --- stress-ng-0.07.05-3.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-b925ae12fa -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1346407] Review Request: stress-ng - Stress test a computer system in various ways
https://bugzilla.redhat.com/show_bug.cgi?id=1346407 --- Comment #20 from Fedora Update System --- stress-ng-0.07.05-3.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-b925ae12fa -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1346407] Review Request: stress-ng - Stress test a computer system in various ways
https://bugzilla.redhat.com/show_bug.cgi?id=1346407 --- Comment #19 from Fedora Update System --- stress-ng-0.07.05-3.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-0663121c05 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1346407] Review Request: stress-ng - Stress test a computer system in various ways
https://bugzilla.redhat.com/show_bug.cgi?id=1346407 --- Comment #18 from Fedora Update System --- stress-ng-0.07.05-3.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2016-7960f25459 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1346407] Review Request: stress-ng - Stress test a computer system in various ways
https://bugzilla.redhat.com/show_bug.cgi?id=1346407 --- Comment #17 from Fedora Update System --- stress-ng-0.07.05-2.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-3bb7571351 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1346407] Review Request: stress-ng - Stress test a computer system in various ways
https://bugzilla.redhat.com/show_bug.cgi?id=1346407 --- Comment #16 from Fedora Update System --- stress-ng-0.07.05-2.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-3e8476982e -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1346407] Review Request: stress-ng - Stress test a computer system in various ways
https://bugzilla.redhat.com/show_bug.cgi?id=1346407 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1346407] Review Request: stress-ng - Stress test a computer system in various ways
https://bugzilla.redhat.com/show_bug.cgi?id=1346407 --- Comment #15 from Fedora Update System --- stress-ng-0.07.05-2.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2016-6ef192fa61 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1346407] Review Request: stress-ng - Stress test a computer system in various ways
https://bugzilla.redhat.com/show_bug.cgi?id=1346407 --- Comment #14 from Sascha Spreitzer --- License field changed -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1346407] Review Request: stress-ng - Stress test a computer system in various ways
https://bugzilla.redhat.com/show_bug.cgi?id=1346407 Igor Gnatenko changed: What|Removed |Added Flags|needinfo?(ignatenko@redhat. | |com)| --- Comment #13 from Igor Gnatenko --- btw, license is GPLv2+, not GPLv2 I didn't check exact build, but otherwise looks good. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1346407] Review Request: stress-ng - Stress test a computer system in various ways
https://bugzilla.redhat.com/show_bug.cgi?id=1346407 --- Comment #12 from Jon Ciesla --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/stress-ng -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1346407] Review Request: stress-ng - Stress test a computer system in various ways
https://bugzilla.redhat.com/show_bug.cgi?id=1346407 Sascha Spreitzer changed: What|Removed |Added Flags||needinfo?(ignatenko@redhat. ||com) --- Comment #11 from Sascha Spreitzer --- Spec URL: https://git.spreitzer.ch/sspreitzer/snippets/snippets/3/raw SRPM URL: https://kojipkgs.fedoraproject.org//work/tasks/5396/16545396/stress-ng-0.07.05-2.fc26.src.rpm Koji task: http://koji.fedoraproject.org/koji/taskinfo?taskID=16545395 Recommendations included -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1346407] Review Request: stress-ng - Stress test a computer system in various ways
https://bugzilla.redhat.com/show_bug.cgi?id=1346407
--- Comment #10 from Igor Gnatenko ---
* [RECOMMENDED] make %{?_smp_mflags} -> %make_build
* [MINOR] make %{?_smp_mflags} is not needed in %install
* [CRITICAL] LDFLAGS are ignored
* [RECOMMENDED] %{_mandir}/man1/stress-ng.1.gz -> %{_mandir}/man1/stress-ng.1*
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1346407] Review Request: stress-ng - Stress test a computer system in various ways
https://bugzilla.redhat.com/show_bug.cgi?id=1346407 --- Comment #9 from Sascha Spreitzer --- http://koji.fedoraproject.org/koji/taskinfo?taskID=16545046 builds perfectly now -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1346407] Review Request: stress-ng - Stress test a computer system in various ways
https://bugzilla.redhat.com/show_bug.cgi?id=1346407 Simone Caronni changed: What|Removed |Added Flags|fedora-review? |fedora-review+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1346407] Review Request: stress-ng - Stress test a computer system in various ways
https://bugzilla.redhat.com/show_bug.cgi?id=1346407
Simone Caronni changed:
What|Removed |Added
Flags|needinfo- |
--- Comment #8 from Simone Caronni ---
Can you please replace the build and install section with this?
%install
install -p -m 755 -D %{name} %{buildroot}%{_bindir}/%{name}
install -p -m 644 -D %{name}.1 %{buildroot}%{_mandir}/man1/%{name}.1
%files
%license COPYING
%doc README
%{_bindir}/%{name}
%{_mandir}/man1/%{name}.1.*
If you execute make install you need to remove (patch/sed) the additional
CFLAGS from the Makefile and re-export the same CFLAGS in the install section
or the target is different and things get relinked.
Man page can be installed uncompressed as RPM at assemble time compresses those
before packing the RPM.
With the above changes, the package builds fine on all rawhide architectures
without another build taking place in the install section.
Also, version 0.07.05 has come out, please update :)
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1346407] Review Request: stress-ng - Stress test a computer system in various ways
https://bugzilla.redhat.com/show_bug.cgi?id=1346407 Simone Caronni changed: What|Removed |Added Flags|needinfo?(negativo17@gmail. |needinfo- |com)| --- Comment #7 from Simone Caronni --- All good with the changes, I'm looking at why the build fails if you don't relink binaries again with ppc and aarch architectures. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1346407] Review Request: stress-ng - Stress test a computer system in various ways
https://bugzilla.redhat.com/show_bug.cgi?id=1346407 Sascha Spreitzer changed: What|Removed |Added CC||negativ...@gmail.com Flags||needinfo?(negativo17@gmail. ||com) --- Comment #6 from Sascha Spreitzer --- Can you please review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1346407] Review Request: stress-ng - Stress test a computer system in various ways
https://bugzilla.redhat.com/show_bug.cgi?id=1346407 Sascha Spreitzer changed: What|Removed |Added Flags|needinfo?(sspreitz@redhat.c | |om) | --- Comment #5 from Sascha Spreitzer --- Updated and included input. Spec URL: https://git.spreitzer.ch/sspreitzer/snippets/snippets/3 Koji URL: http://koji.fedoraproject.org/koji/taskinfo?taskID=16448279 SRPM URL: https://kojipkgs.fedoraproject.org//work/tasks/8280/16448280/stress-ng-0.07.04-1.fc26.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1346407] Review Request: stress-ng - Stress test a computer system in various ways
https://bugzilla.redhat.com/show_bug.cgi?id=1346407 Simone Caronni changed: What|Removed |Added CC||sspre...@redhat.com Flags||needinfo?(sspreitz@redhat.c ||om) --- Comment #4 from Simone Caronni --- Ping? Any news? 2 months have passed since my last comment. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1346407] Review Request: stress-ng - Stress test a computer system in various ways
https://bugzilla.redhat.com/show_bug.cgi?id=1346407
--- Comment #3 from Simone Caronni ---
> [!]: License field in the package spec file matches the actual license.
> Note: Checking patched sources after %prep for licenses. Licenses
> found: "*No copyright* GPL (v2 or later)", "GPL (v2 or later)",
> "Unknown or generated". 2 files have unknown license. Detailed output
> of licensecheck in /home/slaanesh/Downloads/stress-ng/licensecheck.txt
This is ok, but please ask upstream to include the proper headers in the files.
> [!]: %build honors applicable compiler flags or justifies otherwise.
> [!]: Useful -debuginfo package or justification otherwise.
> [!]: Fully versioned dependency in subpackages if applicable.
> Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in stress-
> ng-debuginfo
> Checking: stress-ng-debuginfo-0.06.06-1.fc23.x86_64.rpm
> stress-ng-debuginfo.x86_64: E: debuginfo-without-sources
This is all related to the fact that the package ships with its own compiler
flags in the Makefile:
CFLAGS += -Wall -Wextra -DVERSION='"$(VERSION)"' -O2
You can probably just fix it by export the macro generated compiler flags,
something like this:
%build
export CFLAGS=%{optflags}
make %{?_smp_mflags}
This should also generate binaries with debugging symbols that can then be
later in the build stripped and the result used for debuginfo packages.
If the all/extra/02 flags create confusion just run sed in the %prep section.
Extra stuff:
- Group is not needed, unless you plan to build also for epel-5.
- You can substitute more stress-ng with %{name} (up to you..)
- Please sort BuildRequires.
There are a lot of additional compilation options that are available in the
Makefile:
HAVE_APPARMOR
HAVE_KEYUTILS_H
HAVE_XATTR_H
HAVE_LIB_BSD
HAVE_LIB_Z
HAVE_LIB_CRYPT
HAVE_LIB_RT
HAVE_LIB_PTHREAD
HAVE_FLOAT_DECIMAL
HAVE_SECCOMP_H
HAVE_LIB_AIO
HAVE_SYS_CAP_H
HAVE_VECMATH
Maybe it's worth investing some more time into it to enable some additional
features.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1346407] Review Request: stress-ng - Stress test a computer system in various ways
https://bugzilla.redhat.com/show_bug.cgi?id=1346407 --- Comment #2 from Simone Caronni --- Rpmlint --- Checking: stress-ng-0.06.06-1.fc23.x86_64.rpm stress-ng-debuginfo-0.06.06-1.fc23.x86_64.rpm stress-ng-0.06.06-1.fc23.src.rpm stress-ng-debuginfo.x86_64: E: debuginfo-without-sources 3 packages and 0 specfiles checked; 1 errors, 0 warnings. Rpmlint (debuginfo) --- Checking: stress-ng-debuginfo-0.06.06-1.fc23.x86_64.rpm stress-ng-debuginfo.x86_64: E: debuginfo-without-sources 1 packages and 0 specfiles checked; 1 errors, 0 warnings. Rpmlint (installed packages) sh: /usr/bin/python: No such file or directory stress-ng-debuginfo.x86_64: E: debuginfo-without-sources 2 packages and 0 specfiles checked; 1 errors, 0 warnings. Requires stress-ng (rpmlib, GLIBC filtered): ld-linux-x86-64.so.2()(64bit) libaio.so.1()(64bit) libaio.so.1(LIBAIO_0.1)(64bit) libaio.so.1(LIBAIO_0.4)(64bit) libbsd.so.0()(64bit) libbsd.so.0(LIBBSD_0.0)(64bit) libbsd.so.0(LIBBSD_0.3)(64bit) libc.so.6()(64bit) libcrypt.so.1()(64bit) libm.so.6()(64bit) libpthread.so.0()(64bit) librt.so.1()(64bit) libz.so.1()(64bit) rtld(GNU_HASH) stress-ng-debuginfo (rpmlib, GLIBC filtered): Provides stress-ng: stress-ng stress-ng(x86-64) stress-ng-debuginfo: stress-ng-debuginfo stress-ng-debuginfo(x86-64) Source checksums http://kernel.ubuntu.com/~cking/tarballs/stress-ng/stress-ng-0.06.06.tar.gz : CHECKSUM(SHA256) this package : cc58c8fd63490b20c8313c47c30ecb1543a0abd092b09bc9011c161b1a2c0e50 CHECKSUM(SHA256) upstream package : cc58c8fd63490b20c8313c47c30ecb1543a0abd092b09bc9011c161b1a2c0e50 Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02 Command line :/usr/bin/fedora-review -r -b 1346407 Buildroot used: fedora-23-x86_64 Active plugins: Generic, Shell-api, C/C++ Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1346407] Review Request: stress-ng - Stress test a computer system in various ways
https://bugzilla.redhat.com/show_bug.cgi?id=1346407
Simone Caronni changed:
What|Removed |Added
Flags||fedora-review?
--- Comment #1 from Simone Caronni ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[!]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "*No copyright* GPL (v2 or later)", "GPL (v2 or later)",
"Unknown or generated". 2 files have unknown license. Detailed output
of licensecheck in /home/slaanesh/Downloads/stress-ng/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[!]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[-]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[!]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[!]: Fully versioned dependency in subpackages if applicable.
Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in stress-
ng-debuginfo
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
architectures.
[-]: %check is present and all tests pas
[Bug 1346407] Review Request: stress-ng - Stress test a computer system in various ways
https://bugzilla.redhat.com/show_bug.cgi?id=1346407 Sascha Spreitzer changed: What|Removed |Added Status|NEW |ASSIGNED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1346407] Review Request: stress-ng - Stress test a computer system in various ways
https://bugzilla.redhat.com/show_bug.cgi?id=1346407 Sascha Spreitzer changed: What|Removed |Added Assignee|nob...@fedoraproject.org|negativ...@gmail.com -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
